From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Mon, 12 Feb 2018 13:40:19 +0100 Subject: [PATCH] drm/pl111: Fix regression from fbdev CMA helper Message-ID: <20180212124019.25268-1-linus.walleij@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Commit d18df744de1a ("drm/pl111: Use drm_fb_cma_fbdev_init/fini()") refactored the driver to use fbdev handling in the core, but mistakedly limited the number of maximum connections to 0. Predictably, zero possible connections also gives zero framebuffers when using the system. So let's bump it to 1 so we get our framebuffer back. Cc: Noralf Tr?nnes Cc: Eric Anholt Fixes: d18df744de1a ("drm/pl111: Use drm_fb_cma_fbdev_init/fini()") Signed-off-by: Linus Walleij --- drivers/gpu/drm/pl111/pl111_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c index acb738c69873..306ac7cabd90 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -138,7 +138,7 @@ static int pl111_modeset_init(struct drm_device *dev) drm_mode_config_reset(dev); - drm_fb_cma_fbdev_init(dev, 32, 0); + drm_fb_cma_fbdev_init(dev, 32, 1); drm_kms_helper_poll_init(dev); -- 2.14.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: [PATCH] drm/pl111: Fix regression from fbdev CMA helper Date: Mon, 12 Feb 2018 13:40:19 +0100 Message-ID: <20180212124019.25268-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0EDC892B7 for ; Mon, 12 Feb 2018 12:40:28 +0000 (UTC) Received: by mail-lf0-x243.google.com with SMTP id 37so1370720lfs.7 for ; Mon, 12 Feb 2018 04:40:28 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Jani Nikula , Sean Paul , Eric Anholt Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Q29tbWl0IGQxOGRmNzQ0ZGUxYSAoImRybS9wbDExMTogVXNlIGRybV9mYl9jbWFfZmJkZXZfaW5p dC9maW5pKCkiKQpyZWZhY3RvcmVkIHRoZSBkcml2ZXIgdG8gdXNlIGZiZGV2IGhhbmRsaW5nIGlu IHRoZSBjb3JlLCBidXQKbWlzdGFrZWRseSBsaW1pdGVkIHRoZSBudW1iZXIgb2YgbWF4aW11bSBj b25uZWN0aW9ucyB0byAwLgoKUHJlZGljdGFibHksIHplcm8gcG9zc2libGUgY29ubmVjdGlvbnMg YWxzbyBnaXZlcyB6ZXJvCmZyYW1lYnVmZmVycyB3aGVuIHVzaW5nIHRoZSBzeXN0ZW0uIFNvIGxl dCdzIGJ1bXAgaXQgdG8gMSBzbwp3ZSBnZXQgb3VyIGZyYW1lYnVmZmVyIGJhY2suCgpDYzogTm9y YWxmIFRyw7hubmVzIDxub3JhbGZAdHJvbm5lcy5vcmc+CkNjOiBFcmljIEFuaG9sdCA8ZXJpY0Bh bmhvbHQubmV0PgpGaXhlczogZDE4ZGY3NDRkZTFhICgiZHJtL3BsMTExOiBVc2UgZHJtX2ZiX2Nt YV9mYmRldl9pbml0L2ZpbmkoKSIpClNpZ25lZC1vZmYtYnk6IExpbnVzIFdhbGxlaWogPGxpbnVz LndhbGxlaWpAbGluYXJvLm9yZz4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFfZHJ2 LmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFfZHJ2LmMgYi9kcml2ZXJz L2dwdS9kcm0vcGwxMTEvcGwxMTFfZHJ2LmMKaW5kZXggYWNiNzM4YzY5ODczLi4zMDZhYzdjYWJk OTAgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wbDExMS9wbDExMV9kcnYuYworKysgYi9k cml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFfZHJ2LmMKQEAgLTEzOCw3ICsxMzgsNyBAQCBzdGF0 aWMgaW50IHBsMTExX21vZGVzZXRfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQogCiAJZHJt X21vZGVfY29uZmlnX3Jlc2V0KGRldik7CiAKLQlkcm1fZmJfY21hX2ZiZGV2X2luaXQoZGV2LCAz MiwgMCk7CisJZHJtX2ZiX2NtYV9mYmRldl9pbml0KGRldiwgMzIsIDEpOwogCiAJZHJtX2ttc19o ZWxwZXJfcG9sbF9pbml0KGRldik7CiAKLS0gCjIuMTQuMwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==