From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:36966 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934648AbeBLOK3 (ORCPT ); Mon, 12 Feb 2018 09:10:29 -0500 Received: by mail-wm0-f42.google.com with SMTP id v71so10184283wmv.2 for ; Mon, 12 Feb 2018 06:10:29 -0800 (PST) Date: Mon, 12 Feb 2018 17:10:25 +0300 From: Alexey Dobriyan To: Andrei Vagin Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , KAMEZAWA Hiroyuki Subject: Re: [PATCH 2/4] proc: replace seq_printf on seq_putc to speed up /proc/pid/smaps Message-ID: <20180212141025.GA6623@avx2> References: <20180212074931.7227-1-avagin@openvz.org> <20180212074931.7227-2-avagin@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180212074931.7227-2-avagin@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Feb 11, 2018 at 11:49:29PM -0800, Andrei Vagin wrote: > if (vma->vm_flags & (1UL << i)) { > - seq_printf(m, "%c%c ", > - mnemonics[i][0], mnemonics[i][1]); > + seq_putc(m, mnemonics[i][0]); > + seq_putc(m, mnemonics[i][1]); > + seq_putc(m, ' '); Reviewed-by: Alexey Dobriyan