From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH 2/7] x86/alt: Clean up struct alt_instr and its users Date: Mon, 12 Feb 2018 16:52:21 +0000 Message-ID: <20180212165221.2yaxipnae4yll2tw@MacBook-Pro-de-Roger.local> References: <1518434587-22827-1-git-send-email-andrew.cooper3@citrix.com> <1518434587-22827-3-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1518434587-22827-3-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Wei Liu , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBGZWIgMTIsIDIwMTggYXQgMTE6MjM6MDJBTSArMDAwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiAgKiBSZW5hbWUgc29tZSBmaWVsZHMgZm9yIGNvbnNpc3RlbmN5IGFuZCBjbGFyaXR5 LCBhbmQgdXNlIHN0YW5kYXJkIHR5cGVzLgo+ICAqIERvbid0IG9wZW5jb2RlIHRoZSB1c2Ugb2Yg QUxUX3tPUklHLFJFUEx9X1BUUigpLgo+IAo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlLgo+IAo+IFNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CgpS ZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Cgo+IC0t LQo+IENDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5jb20+Cj4gQ0M6IEtvbnJhZCBSemVz enV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4KPiBDQzogUm9nZXIgUGF1IE1vbm7D qSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Cj4gQ0M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5j b20+Cj4gLS0tCj4gIHhlbi9hcmNoL3g4Ni9hbHRlcm5hdGl2ZS5jICAgICAgICB8IDI0ICsrKysr KysrKysrKy0tLS0tLS0tLS0tLQo+ICB4ZW4vaW5jbHVkZS9hc20teDg2L2FsdGVybmF0aXZlLmgg fCAxMiArKysrKystLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAx OCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2FsdGVybmF0aXZl LmMgYi94ZW4vYXJjaC94ODYvYWx0ZXJuYXRpdmUuYwo+IGluZGV4IDVjOGI2ZjYuLmY4ZGRhYjUg MTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L2FsdGVybmF0aXZlLmMKPiArKysgYi94ZW4vYXJj aC94ODYvYWx0ZXJuYXRpdmUuYwo+IEBAIC0xNjMsOCArMTYzLDYgQEAgdm9pZCBpbml0X29yX2xp dmVwYXRjaCBhcHBseV9hbHRlcm5hdGl2ZXMoY29uc3Qgc3RydWN0IGFsdF9pbnN0ciAqc3RhcnQs Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVj dCBhbHRfaW5zdHIgKmVuZCkKPiAgewo+ICAgICAgY29uc3Qgc3RydWN0IGFsdF9pbnN0ciAqYTsK PiAtICAgIHU4ICppbnN0ciwgKnJlcGxhY2VtZW50Owo+IC0gICAgdTggaW5zbmJ1ZltNQVhfUEFU Q0hfTEVOXTsKPiAgCj4gICAgICBwcmludGsoS0VSTl9JTkZPICJhbHQgdGFibGUgJXAgLT4gJXBc biIsIHN0YXJ0LCBlbmQpOwo+ICAKPiBAQCAtMTc5LDIzICsxNzcsMjUgQEAgdm9pZCBpbml0X29y X2xpdmVwYXRjaCBhcHBseV9hbHRlcm5hdGl2ZXMoY29uc3Qgc3RydWN0IGFsdF9pbnN0ciAqc3Rh cnQsCj4gICAgICAgKi8KPiAgICAgIGZvciAoIGEgPSBzdGFydDsgYSA8IGVuZDsgYSsrICkKPiAg ICAgIHsKPiAtICAgICAgICBpbnN0ciA9ICh1OCAqKSZhLT5pbnN0cl9vZmZzZXQgKyBhLT5pbnN0 cl9vZmZzZXQ7Cj4gLSAgICAgICAgcmVwbGFjZW1lbnQgPSAodTggKikmYS0+cmVwbF9vZmZzZXQg KyBhLT5yZXBsX29mZnNldDsKPiAtICAgICAgICBCVUdfT04oYS0+cmVwbGFjZW1lbnRsZW4gPiBh LT5pbnN0cmxlbik7Cj4gLSAgICAgICAgQlVHX09OKGEtPmluc3RybGVuID4gc2l6ZW9mKGluc25i dWYpKTsKPiArICAgICAgICB1aW50OF90ICpvcmlnID0gQUxUX09SSUdfUFRSKGEpOwo+ICsgICAg ICAgIHVpbnQ4X3QgKnJlcGwgPSBBTFRfUkVQTF9QVFIoYSk7Cj4gKyAgICAgICAgdWludDhfdCBi dWZbTUFYX1BBVENIX0xFTl07Cj4gKwo+ICsgICAgICAgIEJVR19PTihhLT5yZXBsX2xlbiA+IGEt Pm9yaWdfbGVuKTsKPiArICAgICAgICBCVUdfT04oYS0+b3JpZ19sZW4gPiBzaXplb2YoYnVmKSk7 CgpXb3VsZCBiZSBuaWNlIHRvIGhhdmUgYW4gYXNzZW1ibHkgQlVJTERfQlVHX09OIGVxdWl2YWxl bnQgc28gdGhhdCB0aGlzCmNvdWxkIGJlIHR1cm5lZCBpbnRvIGEgY29tcGlsZSB0aW1lIGNoZWNr IGFuZCBhZGRlZCB0byBBTFRJTlNUUl9FTlRSWS4KCj4gICAgICAgICAgQlVHX09OKGEtPmNwdWlk ID49IE5DQVBJTlRTICogMzIpOwo+ICsKPiAgICAgICAgICBpZiAoICFib290X2NwdV9oYXMoYS0+ Y3B1aWQpICkKPiAgICAgICAgICAgICAgY29udGludWU7Cj4gIAo+IC0gICAgICAgIG1lbWNweShp bnNuYnVmLCByZXBsYWNlbWVudCwgYS0+cmVwbGFjZW1lbnRsZW4pOwo+ICsgICAgICAgIG1lbWNw eShidWYsIHJlcGwsIGEtPnJlcGxfbGVuKTsKPiAgCj4gICAgICAgICAgLyogMHhlOC8weGU5IGFy ZSByZWxhdGl2ZSBicmFuY2hlczsgZml4IHRoZSBvZmZzZXQuICovCj4gLSAgICAgICAgaWYgKCBh LT5yZXBsYWNlbWVudGxlbiA+PSA1ICYmICgqaW5zbmJ1ZiAmIDB4ZmUpID09IDB4ZTggKQo+IC0g ICAgICAgICAgICAqKHMzMiAqKShpbnNuYnVmICsgMSkgKz0gcmVwbGFjZW1lbnQgLSBpbnN0cjsK PiArICAgICAgICBpZiAoIGEtPnJlcGxfbGVuID49IDUgJiYgKCpidWYgJiAweGZlKSA9PSAweGU4 ICkKPiArICAgICAgICAgICAgKihzMzIgKikoYnVmICsgMSkgKz0gcmVwbCAtIG9yaWc7CgooaW50 MzJfdCAqKQoKPiAgCj4gLSAgICAgICAgYWRkX25vcHMoaW5zbmJ1ZiArIGEtPnJlcGxhY2VtZW50 bGVuLAo+IC0gICAgICAgICAgICAgICAgIGEtPmluc3RybGVuIC0gYS0+cmVwbGFjZW1lbnRsZW4p Owo+IC0gICAgICAgIHRleHRfcG9rZShpbnN0ciwgaW5zbmJ1ZiwgYS0+aW5zdHJsZW4pOwo+ICsg ICAgICAgIGFkZF9ub3BzKGJ1ZiArIGEtPnJlcGxfbGVuLCBhLT5vcmlnX2xlbiAtIGEtPnJlcGxf bGVuKTsKPiArICAgICAgICB0ZXh0X3Bva2Uob3JpZywgYnVmLCBhLT5vcmlnX2xlbik7Cj4gICAg ICB9Cj4gIH0KPiAgCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvYWx0ZXJuYXRp dmUuaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvYWx0ZXJuYXRpdmUuaAo+IGluZGV4IDEzYWMxMDQu LmZlZmE4N2QgMTAwNjQ0Cj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9hbHRlcm5hdGl2ZS5o Cj4gKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9hbHRlcm5hdGl2ZS5oCj4gQEAgLTksMTUgKzks MTUgQEAKPiAgI2luY2x1ZGUgPHhlbi90eXBlcy5oPgo+ICAKPiAgc3RydWN0IGFsdF9pbnN0ciB7 Cj4gLSAgICBzMzIgaW5zdHJfb2Zmc2V0OyAgICAgICAvKiBvcmlnaW5hbCBpbnN0cnVjdGlvbiAq Lwo+IC0gICAgczMyIHJlcGxfb2Zmc2V0OyAgICAgICAgLyogb2Zmc2V0IHRvIHJlcGxhY2VtZW50 IGluc3RydWN0aW9uICovCj4gLSAgICB1MTYgY3B1aWQ7ICAgICAgICAgICAgICAvKiBjcHVpZCBi aXQgc2V0IGZvciByZXBsYWNlbWVudCAqLwo+IC0gICAgdTggIGluc3RybGVuOyAgICAgICAgICAg LyogbGVuZ3RoIG9mIG9yaWdpbmFsIGluc3RydWN0aW9uICovCj4gLSAgICB1OCAgcmVwbGFjZW1l bnRsZW47ICAgICAvKiBsZW5ndGggb2YgbmV3IGluc3RydWN0aW9uLCA8PSBpbnN0cmxlbiAqLwo+ ICsgICAgaW50MzJfdCAgb3JpZ19vZmZzZXQ7ICAgLyogb3JpZ2luYWwgaW5zdHJ1Y3Rpb24gKi8K PiArICAgIGludDMyX3QgIHJlcGxfb2Zmc2V0OyAgIC8qIG9mZnNldCB0byByZXBsYWNlbWVudCBp bnN0cnVjdGlvbiAqLwo+ICsgICAgdWludDE2X3QgY3B1aWQ7ICAgICAgICAgLyogY3B1aWQgYml0 IHNldCBmb3IgcmVwbGFjZW1lbnQgKi8KPiArICAgIHVpbnQ4X3QgIG9yaWdfbGVuOyAgICAgIC8q IGxlbmd0aCBvZiBvcmlnaW5hbCBpbnN0cnVjdGlvbiAqLwo+ICsgICAgdWludDhfdCAgcmVwbF9s ZW47ICAgICAgLyogbGVuZ3RoIG9mIG5ldyBpbnN0cnVjdGlvbiwgPD0gaW5zdHJsZW4gKi8KPiAg fTsKPiAgCj4gICNkZWZpbmUgX19BTFRfUFRSKGEsZikgICAgICAoKHU4ICopKCh2b2lkICopJihh KS0+ZiArIChhKS0+ZikpCgpXaGlsZSB0aGVyZSBtYXliZSB5b3UgY291bGQgYWxzbyBjaGFuZ2Ug dGhlIGFib3ZlIHRvIHVpbnQ4X3QuLi4KCj4gLSNkZWZpbmUgQUxUX09SSUdfUFRSKGEpICAgICBf X0FMVF9QVFIoYSwgaW5zdHJfb2Zmc2V0KQo+ICsjZGVmaW5lIEFMVF9PUklHX1BUUihhKSAgICAg X19BTFRfUFRSKGEsIG9yaWdfb2Zmc2V0KQo+ICAjZGVmaW5lIEFMVF9SRVBMX1BUUihhKSAgICAg X19BTFRfUFRSKGEsIHJlcGxfb2Zmc2V0KQo+ICAKPiAgZXh0ZXJuIHZvaWQgYWRkX25vcHModm9p ZCAqaW5zbnMsIHVuc2lnbmVkIGludCBsZW4pOwo+IC0tIAo+IDIuMS40Cj4gCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBs aXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2pl Y3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs