All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: "Leo (Sunpeng) Li" <sunpeng.li-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 14/34] drm/amd/display: Use hardware max low point when sampling OTF
Date: Mon, 12 Feb 2018 12:16:05 -0500	[thread overview]
Message-ID: <20180212171625.14325-15-harry.wentland@amd.com> (raw)
In-Reply-To: <20180212171625.14325-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>

From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>

The MAX_LOW_POINT macro should reflect the maximum low point within
hardware. Otherwise, sampling for the hardware points from the output
transfer function (OTF) will be incorrect.

Also, fix usage of MAX_LOW_POINT accordingly.

Change-Id: I6affb8e987ac786c2c9ac8fba4bee5384dc54d07
Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
Reviewed-by: Krunoslav Kovac <Krunoslav.Kovac@amd.com>
Acked-by: Harry Wentland <harry.wentland@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index 9e97cd74b0ec..bc698644d42a 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -409,7 +409,7 @@ static bool convert_to_custom_float(struct pwl_result_data *rgb_resulted,
 	return true;
 }
 
-#define MAX_LOW_POINT      11
+#define MAX_LOW_POINT      25
 #define NUMBER_REGIONS     16
 #define NUMBER_SW_SEGMENTS 16
 
@@ -443,8 +443,8 @@ dce110_translate_regamma_to_hw_format(const struct dc_transfer_func *output_tf,
 		/* 16 segments
 		 * segments are from 2^-11 to 2^5
 		 */
-		region_start = -MAX_LOW_POINT;
-		region_end = NUMBER_REGIONS - MAX_LOW_POINT;
+		region_start = -11;
+		region_end = region_start + NUMBER_REGIONS;
 
 		for (i = 0; i < NUMBER_REGIONS; i++)
 			seg_distr[i] = 4;
-- 
2.14.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-02-12 17:16 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 17:15 [PATCH 00/34] DC Patches Feb 12, 2018 Harry Wentland
     [not found] ` <20180212171625.14325-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-02-12 17:15   ` [PATCH 01/34] drm/amd/display: Rearchitecture HDMI HPD Harry Wentland
2018-02-12 17:15   ` [PATCH 02/34] drm/amd/display: VGA black screen from s3 when attached to hook Harry Wentland
2018-02-12 17:15   ` [PATCH 03/34] drm/amd/display: boot up/S4 fix mainlink off before BL Harry Wentland
2018-02-12 17:15   ` [PATCH 04/34] drm/amd/display: dal 3.1.33 Harry Wentland
2018-02-12 17:15   ` [PATCH 05/34] drm/amd/display: add force_trigger even to static screen control Harry Wentland
2018-02-12 17:15   ` [PATCH 06/34] drm/amd/display: Change blackout time to 0 on CZ/ST Harry Wentland
2018-02-12 17:15   ` [PATCH 07/34] drm/amd/display: add monitor patch for delay after DP receive power up Harry Wentland
2018-02-12 17:15   ` [PATCH 08/34] drm/amd/display: disable seamless vp adjustment for mirrored surface Harry Wentland
2018-02-12 17:16   ` [PATCH 09/34] drm/amd/display: dal 3.1.34 Harry Wentland
2018-02-12 17:16   ` [PATCH 10/34] drm/amd/display: Keep eDP stream enabled during boot Harry Wentland
2018-02-12 17:16   ` [PATCH 11/34] drm/amd/display: Remove unused DCE80 compressor Harry Wentland
2018-02-12 17:16   ` [PATCH 12/34] drm/amd/display: Re-use DCE100 display_power_gating for DCE80 Harry Wentland
2018-02-12 17:16   ` [PATCH 13/34] drm/amd/display: Make couple functions in DCE80 TG static Harry Wentland
2018-02-12 17:16   ` Harry Wentland [this message]
2018-02-12 17:16   ` [PATCH 15/34] drm/amd/display: Add color module's gamma helpers to Linux build Harry Wentland
2018-02-12 17:16   ` [PATCH 16/34] drm/amd/display: Implement color management Harry Wentland
2018-02-12 17:16   ` [PATCH 17/34] drm/amd/display: Hookup color management functions Harry Wentland
2018-02-12 17:16   ` [PATCH 18/34] drm/amd/display: Refactor max color lut entries into a macro Harry Wentland
2018-02-12 17:16   ` [PATCH 19/34] drm/amd/display: Expose dither setting functionality to Linux Harry Wentland
2018-02-12 17:16   ` [PATCH 20/34] drm/amd/display: When enabling CRC, disable dither & enable truncation Harry Wentland
2018-02-12 17:16   ` [PATCH 21/34] drm/amd/display: Rework DCE transform bit depth reduction programming Harry Wentland
2018-02-12 17:16   ` [PATCH 22/34] drm/amd/display: Expose DCE110 CRC functions for DCE8 Harry Wentland
2018-02-12 17:16   ` [PATCH 23/34] drm/amd/display: Skip 2 frames when first reading CRC Harry Wentland
2018-02-12 17:16   ` [PATCH 24/34] drm/amd/display: Remove delay on disconnect patch Harry Wentland
2018-02-12 17:16   ` [PATCH 25/34] drm/amd/display: Make FBC work without fbdev emulation Harry Wentland
2018-02-12 17:16   ` [PATCH 26/34] drm/amd/display: Remove duplicate entries from BIOS function table Harry Wentland
2018-02-12 17:16   ` [PATCH 27/34] drm/amd/display: Tread bad EDID as no EDID Harry Wentland
     [not found]     ` <20180212171625.14325-28-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-02-12 18:11       ` [PATCH v2] drm/amd/display: Treat " Harry Wentland
2018-02-12 17:16   ` [PATCH 28/34] drm/amd/display: Add missing Vega defines to dal_asic_id Harry Wentland
2018-02-12 17:16   ` [PATCH 29/34] drm/amd/display: provide an interface to query firmware version Harry Wentland
2018-02-12 17:16   ` [PATCH 30/34] drm/amd/display: Set vsc pack revision when DPCD revision is >= 1.2 Harry Wentland
2018-02-12 17:16   ` [PATCH 31/34] drm/amd/display: Add logging for aux DPCD access Harry Wentland
     [not found]     ` <20180212171625.14325-32-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-02-12 21:31       ` Andrey Grodzovsky
     [not found]         ` <b92d42b3-699f-943a-68b2-2d15f8c30e51-5C7GfCeVMHo@public.gmane.org>
2018-02-13 16:22           ` Harry Wentland
2018-02-12 17:16   ` [PATCH 32/34] drm/amd/display: Remove unused dm_pp_ interfaces Harry Wentland
2018-02-12 17:16   ` [PATCH 33/34] drm/amd/display: De PQ implementation Harry Wentland
2018-02-12 17:16   ` [PATCH 34/34] drm/amd/display: Fix increment when sampling OTF in DCE Harry Wentland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212171625.14325-15-harry.wentland@amd.com \
    --to=harry.wentland-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=sunpeng.li-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.