From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/5] drm/i915: Keep vblank irq enabled during vblank evasion. Date: Mon, 12 Feb 2018 20:06:58 +0200 Message-ID: <20180212180658.GX5453@intel.com> References: <20180209095404.76418-1-maarten.lankhorst@linux.intel.com> <20180209095404.76418-2-maarten.lankhorst@linux.intel.com> <151844821310.18923.9576212511958820242@mail.alporthouse.com> <8c1a6c2e-3979-c161-bda2-7d64db7d70df@linux.intel.com> <151844896649.18923.5061192328846431913@mail.alporthouse.com> <7025b8d6-182b-caa4-ead0-a930a4ae46b9@linux.intel.com> <151844951141.18923.6243212316836284631@mail.alporthouse.com> <4e21ca44-d9e1-faac-9821-3fa40fd15d3f@linux.intel.com> <20180212165528.GR5453@intel.com> <151845629477.18923.1903087671193460671@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C5766E230 for ; Mon, 12 Feb 2018 18:07:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <151845629477.18923.1903087671193460671@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBGZWIgMTIsIDIwMTggYXQgMDU6MjQ6NTRQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyasOkbMOkICgyMDE4LTAyLTEyIDE2OjU1OjI4KQo+ID4g T24gTW9uLCBGZWIgMTIsIDIwMTggYXQgMDQ6NDE6MDVQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gPiA+IE9wIDEyLTAyLTE4IG9tIDE2OjMxIHNjaHJlZWYgQ2hyaXMgV2lsc29u Ogo+ID4gPiA+IFF1b3RpbmcgTWFhcnRlbiBMYW5raG9yc3QgKDIwMTgtMDItMTIgMTU6Mjc6MzQp Cj4gPiA+ID4+IE9wIDEyLTAyLTE4IG9tIDE2OjIyIHNjaHJlZWYgQ2hyaXMgV2lsc29uOgo+ID4g PiA+Pj4gUXVvdGluZyBNYWFydGVuIExhbmtob3JzdCAoMjAxOC0wMi0xMiAxNToxNjozOSkKPiA+ ID4gPj4+PiBPcCAxMi0wMi0xOCBvbSAxNjoxMCBzY2hyZWVmIENocmlzIFdpbHNvbjoKPiA+ID4g Pj4+Pj4gUXVvdGluZyBNYWFydGVuIExhbmtob3JzdCAoMjAxOC0wMi0wOSAwOTo1NDowMCkKPiA+ ID4gPj4+Pj4+IFRoaXMgaXMgYSBuaWNlIHByZXBhcmF0aW9uIGZvciBncmFiYmluZyB0aGUgdW5j b3JlIGxvY2sgZHVyaW5nIGV2YXNpb24uCj4gPiA+ID4+Pj4+PiBHcmFiYmluZyB0aGUgc3Bpbmxv Y2sgd2l0aCB0aGUgbG9jayBoZWxkIG1lc3NlcyB1cCB0aGUgbG9ja2luZywKPiA+ID4gPj4+Pj4+ IHNvIGl0J3MgZWFzaWVyIHRvIGhhbmRvdmVyIHRoZSByZWZlcmVuY2UgdG8gdGhlIGV2ZQo+ID4g PiA+Pj4+Pj4KPiA+ID4gPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxt YWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4+Pj4+PiAtLS0KPiA+ID4g Pj4+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDExICsrKystLS0t LS0tCj4gPiA+ID4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNyBkZWxl dGlvbnMoLSkKPiA+ID4gPj4+Pj4+Cj4gPiA+ID4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9z cHJpdGUuYwo+ID4gPiA+Pj4+Pj4gaW5kZXggM2JlMjJjMGZjZmI1Li45NzFhMWVhMGRiNDUgMTAw NjQ0Cj4gPiA+ID4+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUu Ywo+ID4gPiA+Pj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMK PiA+ID4gPj4+Pj4+IEBAIC0xMDksMTAgKzEwOSwxMCBAQCB2b2lkIGludGVsX3BpcGVfdXBkYXRl X3N0YXJ0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiA+ ID4gPj4+Pj4+ICAKPiA+ID4gPj4+Pj4+ICAgICAgICAgbG9jYWxfaXJxX2Rpc2FibGUoKTsKPiA+ ID4gPj4+Pj4+ICAKPiA+ID4gPj4+Pj4+IC0gICAgICAgaWYgKG1pbiA8PSAwIHx8IG1heCA8PSAw KQo+ID4gPiA+Pj4+Pj4gKyAgICAgICBpZiAoV0FSTl9PTihkcm1fY3J0Y192YmxhbmtfZ2V0KCZj cnRjLT5iYXNlKSkpCj4gPiA+ID4+Pj4+PiAgICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4gPiA+ Pj4+Pj4gIAo+ID4gPiA+Pj4+Pj4gLSAgICAgICBpZiAoV0FSTl9PTihkcm1fY3J0Y192Ymxhbmtf Z2V0KCZjcnRjLT5iYXNlKSkpCj4gPiA+ID4+Pj4+PiArICAgICAgIGlmIChtaW4gPD0gMCB8fCBt YXggPD0gMCkKPiA+ID4gPj4+Pj4+ICAgICAgICAgICAgICAgICByZXR1cm47Cj4gPiA+ID4+Pj4+ PiAgCj4gPiA+ID4+Pj4+IFRoZSBjb3JyZXNwb25kaW5nIHZibGFua19wdXQgaXMgdGhlIG9uZSBs YXRlciBpbiB1cGRhdGVfc3RhcnQoKSwgcmlnaHQ/Cj4gPiA+ID4+Pj4+IEkgZG9uJ3QgdGhpbmsg eW91IGludGVuZGVkIHRvIGtlZXAgdGhpcyBjaHVuay4KPiA+ID4gPj4+Pj4gLUNocmlzCj4gPiA+ ID4+Pj4gSSdtIG5vdCBzdXJlIHdoYXQgeW91IG1lYW4/IFRoZSB2YmxhbmtfcHV0IGlzIG5vdyBp biBwaXBlX3VwZGF0ZV9lbmQsIGV4Y2VwdCBpZiB0aGUKPiA+ID4gPj4+PiBldmVudCB0YWtlcyBv dmVyIHRoZSByZWZlcmVuY2UuIEkgdGhpbmsgdGhlIGNvZGUgaXMgY29ycmVjdC4gOikKPiA+ID4g Pj4+IFRoZW4gaXQncyB1bmJhbGFuY2VkIGluIHRoZSBjYXNlIG9mIGVycm9yIHN0aWxsLgo+ID4g PiA+Pj4gLUNocmlzCj4gPiA+ID4+IEl0IGFscmVhZHkgd291bGQgaGF2ZSBiZWVuIGZvciBldmVu dHMsIGhlbmNlIHRoZSBXQVJOX09OIHRoZXJlLgo+ID4gPiA+PiBJIGRvbid0IHRoaW5rIHdlIGNh biBkbyBhbnl0aGluZyBhYm91dCBpdCwgdGhpcyBzaG91bGRuJ3QgZXZlcgo+ID4gPiA+PiBoYXBw ZW4gaW4gcHJhY3RpY2UsIGNvdWxkIGJlIGEgQlVHX09OIGZvciBhbGwgSSBjYXJlLiA6KQo+ID4g PiA+IEkgd291bGQgbXVjaCBwcmVmZXIgdGhhdCBvdmVyIGludGVudGlvbmFsbHkgYmFkIGNvZGUu Cj4gPiA+ID4KPiA+ID4gPiBCdXQgZG8gd2UgcmVhbGx5IG5lZWQgdG8gZW5hYmxlIHRoZSB2Ymxh bmsgaXJxIGhlcmU/IElmIHRoZSBldmVudAo+ID4gPiA+IHJlcXVpcmVzIGl0LCBkb2Vzbid0IGl0 IGFscmVhZHkgZW5hYmxlIHRoZSB2YmxhbmsuIEhlcmUsIHdlIG9ubHkgbmVlZCBpdAo+ID4gPiA+ IHdoZW4gc2xlZXBpbmcsIGNhbiB3ZSBub3QgZGV0ZXJtaW5lIHdlIGhhdmUgZW5vdWdoIHRpbWUg YmVmb3JlIHRoZQo+ID4gPiA+IHZibGFuayB3aXRob3V0IGVuYWJsaW5nIHRoZSBpbnRlcnJ1cHQ/ Cj4gPiA+IEknbSBub3Qgc3VyZSB3aHkgd2UgZ2V0IGEgcmVmZXJlbmNlIHRvIHRoZSB2Ymxhbmsg Y291bnRlciBoZXJlLiBQZXJoYXBzIFZpbGxlIGRvZXM/Cj4gPiAKPiA+IFdlIG5lZWQgdGhlIHZi bGFuayBpcnEgdG8gYmUgZW5hYmxlZCBiZWZvcmUgd2UgY2hlY2sgdGhlIHNjYW5saW5lIHNpbmNl Cj4gPiBvdGhlcndpc2Ugd2UgbWF5IGVuZCB1cCBkb2luZzoKPiA+IAo+ID4gMS4gY2hlY2sgc2Nh bmxpbmUKPiA+IDMuIHZibGFuayBpcnEgZmlyZXMKPiA+IDIuIGVuYWJsZSB2YmxhbmsgaXJxCj4g PiAzLiB3YWl0IGZvciB0aGUgbmV4dCB2YmxhbmsKPiA+IAo+ID4gU28gd2UnZCBlbmQgdXAgd2Fz dGluZyBhbiBlbnRpcmUgZnJhbWUuCj4gCj4gU3RlcDogMi41LCBjaGVja19zY2FubGluZT8KPiAK PiBTb21ldGhpbmcgbGlrZSwKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGlu ZGV4IDU3NGJkMDJjNWEyZS4uNzBjMmVlMWM3YjhjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfc3ByaXRlLmMKPiBAQCAtOTcsNiArOTcsNyBAQCB2b2lkIGludGVsX3BpcGVfdXBkYXRlX3N0 YXJ0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiAgICAg ICAgIGJvb2wgbmVlZF92bHZfZHNpX3dhID0gKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElT X0NIRVJSWVZJRVcoZGV2X3ByaXYpKSAmJgo+ICAgICAgICAgICAgICAgICBpbnRlbF9jcnRjX2hh c190eXBlKG5ld19jcnRjX3N0YXRlLCBJTlRFTF9PVVRQVVRfRFNJKTsKPiAgICAgICAgIERFRklO RV9XQUlUKHdhaXQpOwo+ICsgICAgICAgYm9vbCBoYXZlX3ZibGFua19pcnEgPSBmYWxzZTsKPiAg Cj4gICAgICAgICB2Ymxhbmtfc3RhcnQgPSBhZGp1c3RlZF9tb2RlLT5jcnRjX3ZibGFua19zdGFy dDsKPiAgICAgICAgIGlmIChhZGp1c3RlZF9tb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfSU5U RVJMQUNFKQo+IEBAIC0xMTIsOSArMTEzLDYgQEAgdm9pZCBpbnRlbF9waXBlX3VwZGF0ZV9zdGFy dChjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUpCj4gICAgICAg ICBpZiAobWluIDw9IDAgfHwgbWF4IDw9IDApCj4gICAgICAgICAgICAgICAgIHJldHVybjsKPiAg Cj4gLSAgICAgICBpZiAoV0FSTl9PTihkcm1fY3J0Y192YmxhbmtfZ2V0KCZjcnRjLT5iYXNlKSkp Cj4gLSAgICAgICAgICAgICAgIHJldHVybjsKPiAtCj4gICAgICAgICBjcnRjLT5kZWJ1Zy5taW5f dmJsID0gbWluOwo+ICAgICAgICAgY3J0Yy0+ZGVidWcubWF4X3ZibCA9IG1heDsKPiAgICAgICAg IHRyYWNlX2k5MTVfcGlwZV91cGRhdGVfc3RhcnQoY3J0Yyk7Cj4gQEAgLTEyNyw2ICsxMjUsMTAg QEAgdm9pZCBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqbmV3X2NydGNfc3RhdGUpCj4gICAgICAgICAgICAgICAgICAqLwo+ICAgICAgICAgICAg ICAgICBwcmVwYXJlX3RvX3dhaXQod3EsICZ3YWl0LCBUQVNLX1VOSU5URVJSVVBUSUJMRSk7Cj4g IAo+ICsgICAgICAgICAgICAgICBpZiAoIWhhdmVfdmJsYW5rX2lycSkKPiArICAgICAgICAgICAg ICAgICAgICAgICBoYXZlX3ZibGFua19pcnEgPSAhZHJtX2NydGNfdmJsYW5rX2dldCgmY3J0Yy0+ YmFzZSk7Cj4gKwoKVGhpcyBkb2Vzbid0IHNlZW0gdG8gY2hhbmdlIGFueXRoaW5nLgoKRGlkIHlv dSBtZWFuIHNvbWV0aGluZyBsaWtlIHRoaXMgcGVyaGFwcz8KCmZvciAoOzspIHsKCXByZXBhcmVf dG9fd2FpdCgpOwoKCWlmIChzY2FubGluZSBvaykKCQlicmVhazsKCglpZiAoIWhhdmVfdmJsX2ly cSkgewoJCWhhdmVfdmJsX2lycSA9ICF2YmxfZ2V0KCk7CgkJLyoKCQkgKiBDaGVjayB0aGUgc2Nh bmxpbmUgYWdhaW4gdG8gbWFrZSBzdXJlCgkJICogd2UgZGlkbid0IGp1c3QgbWlzcyB0aGUgdmJs YW5rIGludGVycnVwdC4KCQkgKi8KCQljb250aW51ZTsKCX0KCglsb2NhbF9pcnFfZW5hYmxlKCk7 CglzY2hlZHVsZV90aW1lb3V0KCk7Cglsb2NhbF9pcnFfZGlzYWJsZSgpOwp9CgpJIGd1ZXNzIHNv bWV0aGluZyBsaWtlIHRoYXQgbWlnaHQgd29yay4gVGhvdWdoIGlmIHdlJ3JlIGFjdHVhbGx5Cndv cnJpZWQgYWJvdXQgdGhlIHZibF9nZXQoKSBmYWlsaW5nLCB3ZSdsbCBuZWVkIGFub3RoZXIgZmxh ZyBiZXNpZGVzCmhhdmVfdmJsX2lycSB0byBhdm9pZCB0aGUgaW5pZmluaXRlIGxvb3AuCgo+ICAg ICAgICAgICAgICAgICBzY2FubGluZSA9IGludGVsX2dldF9jcnRjX3NjYW5saW5lKGNydGMpOwo+ ICAgICAgICAgICAgICAgICBpZiAoc2NhbmxpbmUgPCBtaW4gfHwgc2NhbmxpbmUgPiBtYXgpCj4g ICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gQEAgLTE0NSw4ICsxNDcsOCBAQCB2b2lk IGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpu ZXdfY3J0Y19zdGF0ZSkKPiAgICAgICAgIH0KPiAgCj4gICAgICAgICBmaW5pc2hfd2FpdCh3cSwg JndhaXQpOwo+IC0KPiAtICAgICAgIGRybV9jcnRjX3ZibGFua19wdXQoJmNydGMtPmJhc2UpOwo+ ICsgICAgICAgaWYgKGhhdmVfdmJsYW5rX2lycSkKPiArICAgICAgICAgICAgICAgZHJtX2NydGNf dmJsYW5rX3B1dCgmY3J0Yy0+YmFzZSk7Cj4gIAo+ICAgICAgICAgLyoKPiAgICAgICAgICAqIE9u IFZMVi9DSFYgRFNJIHRoZSBzY2FubGluZSBjb3VudGVyIHdvdWxkIGFwcGVhciB0bwoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==