From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH 05/21] regulator: arizona-ldo1: Look up a descriptor and pass to the core Date: Tue, 13 Feb 2018 11:06:31 +0000 Message-ID: <20180213110631.o3zn5bifvypofsyg@localhost.localdomain> References: <20180212131717.27193-1-linus.walleij@linaro.org> <20180212131717.27193-6-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:52136 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934079AbeBMLGg (ORCPT ); Tue, 13 Feb 2018 06:06:36 -0500 Content-Disposition: inline In-Reply-To: <20180212131717.27193-6-linus.walleij@linaro.org> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, patches@opensource.cirrus.com, Richard Fitzgerald On Mon, Feb 12, 2018 at 02:17:01PM +0100, Linus Walleij wrote: > Instead of passing a global GPIO number, pass a descriptor looked > up with the standard devm_gpiod_get_optional() call. > > We have augmented the GPIO core to look up the regulator special > GPIO "wlf,ldoena" in a separate patch. > > Cc: patches@opensource.cirrus.com > Cc: Richard Fitzgerald > Signed-off-by: Linus Walleij > --- > drivers/regulator/arizona-ldo1.c | 19 ++++++------------- > include/linux/regulator/arizona-ldo1.h | 3 --- > 2 files changed, 6 insertions(+), 16 deletions(-) > Does this patch not also need to update the hookups in arch/arm/mach-s3c64xx/mach-crag6410-module.c? There is wm5102_reva_pdata and wm5102_pdata both of which use the ldoena you are removing here? Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934411AbeBMLGi (ORCPT ); Tue, 13 Feb 2018 06:06:38 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:52136 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934079AbeBMLGg (ORCPT ); Tue, 13 Feb 2018 06:06:36 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Date: Tue, 13 Feb 2018 11:06:31 +0000 From: Charles Keepax To: Linus Walleij CC: Liam Girdwood , Mark Brown , , , , Richard Fitzgerald Subject: Re: [PATCH 05/21] regulator: arizona-ldo1: Look up a descriptor and pass to the core Message-ID: <20180213110631.o3zn5bifvypofsyg@localhost.localdomain> References: <20180212131717.27193-1-linus.walleij@linaro.org> <20180212131717.27193-6-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180212131717.27193-6-linus.walleij@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=738 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802130133 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 12, 2018 at 02:17:01PM +0100, Linus Walleij wrote: > Instead of passing a global GPIO number, pass a descriptor looked > up with the standard devm_gpiod_get_optional() call. > > We have augmented the GPIO core to look up the regulator special > GPIO "wlf,ldoena" in a separate patch. > > Cc: patches@opensource.cirrus.com > Cc: Richard Fitzgerald > Signed-off-by: Linus Walleij > --- > drivers/regulator/arizona-ldo1.c | 19 ++++++------------- > include/linux/regulator/arizona-ldo1.h | 3 --- > 2 files changed, 6 insertions(+), 16 deletions(-) > Does this patch not also need to update the hookups in arch/arm/mach-s3c64xx/mach-crag6410-module.c? There is wm5102_reva_pdata and wm5102_pdata both of which use the ldoena you are removing here? Thanks, Charles