From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965383AbeBMRHa (ORCPT ); Tue, 13 Feb 2018 12:07:30 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34536 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965057AbeBMRH1 (ORCPT ); Tue, 13 Feb 2018 12:07:27 -0500 X-Google-Smtp-Source: AH8x225ygooSvHNub/aoNWWGotb4TfWM6M/d4Fk3zpL2+QbbJL4uQPTxz32UP2B0b2PazaF1hL8PCg== Date: Tue, 13 Feb 2018 09:07:25 -0800 From: Guenter Roeck To: Jerry Hoemann Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com Subject: Re: [PATCH v2 11/11] watchdog/hpwdt: Update driver version. Message-ID: <20180213170725.GA19405@roeck-us.net> References: <20180212052111.12010-1-jerry.hoemann@hpe.com> <20180212052111.12010-12-jerry.hoemann@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180212052111.12010-12-jerry.hoemann@hpe.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 11, 2018 at 10:21:11PM -0700, Jerry Hoemann wrote: > Update driver version number to reflect changes. > > Signed-off-by: Jerry Hoemann > --- > drivers/watchdog/hpwdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index bb0dcc8709b8..78168e2f9b4e 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -23,7 +23,7 @@ > > #include > > -#define HPWDT_VERSION "1.4.0" > +#define HPWDT_VERSION "2.0.0" I would suggest to drop the version entirely. History and experience shows that it is not really useful. Guenter > #define SECS_TO_TICKS(secs) ((secs) * 1000 / 128) > #define TICKS_TO_SECS(ticks) ((ticks) * 128 / 1000) > #define HPWDT_MAX_TIMER TICKS_TO_SECS(65535) > -- > 2.13.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html