From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2120.oracle.com ([156.151.31.85]:36228 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965783AbeBMXWi (ORCPT ); Tue, 13 Feb 2018 18:22:38 -0500 Date: Tue, 13 Feb 2018 15:17:31 -0800 From: "Darrick J. Wong" Subject: Re: [PATCH] Cleanup old XFS_BTREE_* traces Message-ID: <20180213231731.GF5217@magnolia> References: <20180212130005.7199-1-cmaiolino@redhat.com> <20180212182948.GB5217@magnolia> <20180212212106.GD6778@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180212212106.GD6778@dastard> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: Carlos Maiolino , linux-xfs@vger.kernel.org On Tue, Feb 13, 2018 at 08:21:06AM +1100, Dave Chinner wrote: > On Mon, Feb 12, 2018 at 10:29:48AM -0800, Darrick J. Wong wrote: > > On Mon, Feb 12, 2018 at 02:00:05PM +0100, Carlos Maiolino wrote: > > > Remove unused legacy btree traces from IRIX era. > > > > > > Signed-off-by: Carlos Maiolino > > > --- > > > > > > Talking to Dave about it, he mentioned XFS_BTREE_TRACE_CURSOR might be worth to > > > turn into a proper ftrace trace point, so I didn't touch _CURSOR traces in this > > > patchset, and a proper conversion will be sent later, unless it's not worth at > > > all, and I should send a V2 also removing TRACE_CURSOR. > > > > TBH I wonder the opposite -- why not turn all of these into tracepoints? > > TBH, we haven't used them in at least 15 years. What value do they > provide apart from making the traces even noisier (and potentially > more lossy) than they already are? FWIW adding trace_printks to some of those functions was rather useful for checking that the unusual refcount and rmap btree semantics actually resulted in calls to the desired btree functions. I wish I'd cleaned up that debugging patch and sent it, but it's lost now. --D > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html