From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] usb: host: xhci-plat: Remove useless test before clk_disable_unprepare From: Gregory CLEMENT Message-Id: <20180214161620.4401-2-gregory.clement@bootlin.com> Date: Wed, 14 Feb 2018 17:16:19 +0100 To: Greg Kroah-Hartman , Mathias Nyman , linux-usb@vger.kernel.org Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory CLEMENT , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Antoine Tenart , =?UTF-8?q?Miqu=C3=A8l=20Raynal?= , Nadav Haklai , Shadi Ammouri , Omri Itach , Hanna Hawa , Igal Liberman , Marcin Wojtas List-ID: Y2xrX2Rpc2FibGVfdW5wcmVwYXJlKCkgYWxyZWFkeSBjaGVja3MgdGhhdCB0aGUgY2xvY2sgcG9p bnRlciBpcyB2YWxpZC4KTm8gbmVlZCB0byB0ZXN0IGl0IGJlZm9yZSBjYWxsaW5nIGl0LgoKU2ln bmVkLW9mZi1ieTogR3JlZ29yeSBDTEVNRU5UIDxncmVnb3J5LmNsZW1lbnRAYm9vdGxpbi5jb20+ Ci0tLQogZHJpdmVycy91c2IvaG9zdC94aGNpLXBsYXQuYyB8IDYgKystLS0tCiAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZl cnMvdXNiL2hvc3QveGhjaS1wbGF0LmMgYi9kcml2ZXJzL3VzYi9ob3N0L3hoY2ktcGxhdC5jCmlu ZGV4IDZmMDM4MzA2YzE0ZC4uNzlhZmFhYzU3ZWY2IDEwMDY0NAotLS0gYS9kcml2ZXJzL3VzYi9o b3N0L3hoY2ktcGxhdC5jCisrKyBiL2RyaXZlcnMvdXNiL2hvc3QveGhjaS1wbGF0LmMKQEAgLTMx OSw4ICszMTksNyBAQCBzdGF0aWMgaW50IHhoY2lfcGxhdF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQogCXVzYl9wdXRfaGNkKHhoY2ktPnNoYXJlZF9oY2QpOwogCiBkaXNhYmxl X2NsazoKLQlpZiAoIUlTX0VSUihjbGspKQotCQljbGtfZGlzYWJsZV91bnByZXBhcmUoY2xrKTsK KwljbGtfZGlzYWJsZV91bnByZXBhcmUoY2xrKTsKIAogcHV0X2hjZDoKIAl1c2JfcHV0X2hjZCho Y2QpOwpAQCAtMzQ2LDggKzM0NSw3IEBAIHN0YXRpYyBpbnQgeGhjaV9wbGF0X3JlbW92ZShzdHJ1 Y3QgcGxhdGZvcm1fZGV2aWNlICpkZXYpCiAJdXNiX3JlbW92ZV9oY2QoaGNkKTsKIAl1c2JfcHV0 X2hjZCh4aGNpLT5zaGFyZWRfaGNkKTsKIAotCWlmICghSVNfRVJSKGNsaykpCi0JCWNsa19kaXNh YmxlX3VucHJlcGFyZShjbGspOworCWNsa19kaXNhYmxlX3VucHJlcGFyZShjbGspOwogCXVzYl9w dXRfaGNkKGhjZCk7CiAKIAlwbV9ydW50aW1lX3NldF9zdXNwZW5kZWQoJmRldi0+ZGV2KTsK From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@bootlin.com (Gregory CLEMENT) Date: Wed, 14 Feb 2018 17:16:19 +0100 Subject: [PATCH 1/2] usb: host: xhci-plat: Remove useless test before clk_disable_unprepare In-Reply-To: <20180214161620.4401-1-gregory.clement@bootlin.com> References: <20180214161620.4401-1-gregory.clement@bootlin.com> Message-ID: <20180214161620.4401-2-gregory.clement@bootlin.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org clk_disable_unprepare() already checks that the clock pointer is valid. No need to test it before calling it. Signed-off-by: Gregory CLEMENT --- drivers/usb/host/xhci-plat.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 6f038306c14d..79afaac57ef6 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -319,8 +319,7 @@ static int xhci_plat_probe(struct platform_device *pdev) usb_put_hcd(xhci->shared_hcd); disable_clk: - if (!IS_ERR(clk)) - clk_disable_unprepare(clk); + clk_disable_unprepare(clk); put_hcd: usb_put_hcd(hcd); @@ -346,8 +345,7 @@ static int xhci_plat_remove(struct platform_device *dev) usb_remove_hcd(hcd); usb_put_hcd(xhci->shared_hcd); - if (!IS_ERR(clk)) - clk_disable_unprepare(clk); + clk_disable_unprepare(clk); usb_put_hcd(hcd); pm_runtime_set_suspended(&dev->dev); -- 2.15.1