From: Pierre Moreau <pmoreau@pmoreau.org>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Lyude Paul <lyude@redhat.com>, Meelis Roos <mroos@linux.ee>,
nouveau <nouveau@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [Nouveau] 4.16-rc1: UBSAN warning in nouveau/nvkm/subdev/therm/base.c + oops in nvkm_therm_clkgate_fini
Date: Wed, 14 Feb 2018 18:41:26 +0100 [thread overview]
Message-ID: <20180214174125.b5bdowaadck3vf5n@pmoreau.org> (raw)
In-Reply-To: <CAKb7UvhRt=25J5aOUZusdE51hh1JVc45aQ8OhCVeOJwzYvLOJw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]
On 2018-02-14 — 09:36, Ilia Mirkin wrote:
> On Wed, Feb 14, 2018 at 9:35 AM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> > On Wed, Feb 14, 2018 at 9:29 AM, Meelis Roos <mroos@linux.ee> wrote:
> >>> This is 4.16-rc1+todays git on a lowly P4 with NV5, worked fine in 4.15:
> >>
> >> NV5 in another PC (secondary card in x86-64) made the systrem crash on
> >> boot, in nvkm_therm_clkgate_fini.
> >
> > Mind booting with nouveau.debug=trace? That should hopefully tell us
> > more exactly which thing is dying. If you have a cross-compile/distcc
> > setup handy, a bisect may be even more useful.
>
> Erm, sorry, nevermind. You even said it -- nvkm_therm_clkgate_fini is
> somehow mis-hooked up for NV5 now. A bisect result would still make
> the culprit a lot more obvious.
CC’ing Lyude Paul as she hooked up the clockgating support.
Looking at the code, only NV40+ do have a therm engine. Therefore, shouldn’t
nvkm_therm_clkgate_enable(), nvkm_therm_clkgate_fini() and
nvkm_therm_clkgate_oneinit() all check for therm being not NULL, on top of
their check for the clkgate_* hooks being there? Or instead, maybe have the
check in nvkm_device_init() nvkm_device_init()?
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-14 17:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 20:04 4.16-rc1: UBSAN warning in nouveau/nvkm/subdev/therm/base.c + oops in nvkm_therm_clkgate_fini Meelis Roos
2018-02-14 14:29 ` Meelis Roos
2018-02-14 14:29 ` Meelis Roos
2018-02-14 14:35 ` [Nouveau] " Ilia Mirkin
2018-02-14 14:35 ` Ilia Mirkin
2018-02-14 14:36 ` Ilia Mirkin
2018-02-14 14:36 ` Ilia Mirkin
2018-02-14 17:41 ` Pierre Moreau [this message]
2018-02-14 19:11 ` Lyude Paul
2018-02-14 19:11 ` Lyude Paul
2018-02-14 20:59 ` [Nouveau] " Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214174125.b5bdowaadck3vf5n@pmoreau.org \
--to=pmoreau@pmoreau.org \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imirkin@alum.mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=mroos@linux.ee \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.