From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226ampVxa4clSrCx2jfHkFsiPvpsXzA0x6QU1hmojsaoEnO2IhfFcrBvEq6XtZSjlcwxXxhf ARC-Seal: i=1; a=rsa-sha256; t=1518639263; cv=none; d=google.com; s=arc-20160816; b=WwoKvMKXfFP9pAc7Mr7UwuTZ08DaxmarOZxEEw9/W2TkubNEqJZg3MCF8rdFt1inz6 5WxvF9+mY0WNPPHkAxRM5f0j8nNvmT6MVVHyFIbKxgsbUdmbRIX0BwkUYMQ1SPcx/yzS X+pBr0ELKUl3izyexnrP7vJClkH1Af4dF6ONTopXVhgVnX/6+0KklV3583atFFgbeOI8 J6aTi2hZRM3qjh2HWtRIHXEiiXTyC7agrltQf4EXllTgQjfCucMtIfMOmLShr3p1EgD/ vMuCoxLdLdpZjKFvgMFhvtAurkdwrjKphZj0E4RpOZKkfhVuR7OuPJfs7hhPu00vsYXB 4fOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature:delivered-to :list-id:list-subscribe:list-unsubscribe:list-help:list-post :precedence:mailing-list:arc-authentication-results; bh=HMbY14q2gYyQ3xZ9ZFfxFBGqZ3oA2aGG88VGoas1jWQ=; b=ifThpI5cEk1pObsRojO345X6Vq6dD9uMuJUT+/6GRfoGVlOg3/Ri5KFjtRHoVFefm8 EUlub22SeC/+4FBE4pHSghJihJIWe2qKzvFOrsSkFpYfBoP2dxA6Ee1NT8sNW8I3KyXZ LwjNAbo1oryDncyxNm2+SGMp4XCNM8V3dRxgnXtl6zki5YT/4VA234sk9Nw6ueHucJJj n8XTqDUZRnJp2FWrEGtqpXAA4IVhshxUrS9S6TkfDav4qywbKfirIh4uCfZUMhFrDE+x vpLR43A3eOOKiuqqr2ciElTXuNEPjARQSE8Rads8BVtYhWJq6ZaT1xy9JDiM4g0OLyrV uHqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=n9UrC9FQ; spf=pass (google.com: domain of kernel-hardening-return-11786-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11786-gregkh=linuxfoundation.org@lists.openwall.com Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=n9UrC9FQ; spf=pass (google.com: domain of kernel-hardening-return-11786-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11786-gregkh=linuxfoundation.org@lists.openwall.com Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm List-Post: List-Help: List-Unsubscribe: List-Subscribe: Date: Wed, 14 Feb 2018 12:14:00 -0800 From: Matthew Wilcox To: Christopher Lameter Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, Kees Cook , linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct Message-ID: <20180214201400.GD20627@bombadil.infradead.org> References: <20180214182618.14627-1-willy@infradead.org> <20180214182618.14627-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1592401933337716102?= X-GMAIL-MSGID: =?utf-8?q?1592408684152623008?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Feb 14, 2018 at 01:55:59PM -0600, Christopher Lameter wrote: > On Wed, 14 Feb 2018, Matthew Wilcox wrote: > > > +#define kvzalloc_struct(p, member, n, gfp) \ > > + (typeof(p))kvzalloc_ab_c(n, \ > > + sizeof(*(p)->member) + __must_be_array((p)->member), \ > > + offsetof(typeof(*(p)), member), gfp) > > + > > Uppercase like the similar KMEM_CACHE related macros in > include/linux/slab.h?> Do you think that would look better in the users? Compare: @@ -1284,7 +1284,7 @@ static long vhost_set_memory(struct vhost_dev *d, struct vhost_memory __user *m) return -EOPNOTSUPP; if (mem.nregions > max_mem_regions) return -E2BIG; - newmem = kvzalloc(size + mem.nregions * sizeof(*m->regions), GFP_KERNEL); + newmem = kvzalloc_struct(newmem, regions, mem.nregions, GFP_KERNEL); if (!newmem) return -ENOMEM; @@ -1284,7 +1284,7 @@ static long vhost_set_memory(struct vhost_dev *d, struct vhost_memory __user *m) return -EOPNOTSUPP; if (mem.nregions > max_mem_regions) return -E2BIG; - newmem = kvzalloc(size + mem.nregions * sizeof(*m->regions), GFP_KERNEL); + newmem = KVZALLOC_STRUCT(newmem, regions, mem.nregions, GFP_KERNEL); if (!newmem) return -ENOMEM; Making it look like a function is more pleasing to my eye, but I'll change it if that's the only thing keeping it from being merged. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f71.google.com (mail-pg0-f71.google.com [74.125.83.71]) by kanga.kvack.org (Postfix) with ESMTP id D6DF06B0008 for ; Wed, 14 Feb 2018 15:14:03 -0500 (EST) Received: by mail-pg0-f71.google.com with SMTP id i11so2323120pgq.10 for ; Wed, 14 Feb 2018 12:14:03 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id x16si1078948pgc.817.2018.02.14.12.14.02 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Feb 2018 12:14:02 -0800 (PST) Date: Wed, 14 Feb 2018 12:14:00 -0800 From: Matthew Wilcox Subject: Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct Message-ID: <20180214201400.GD20627@bombadil.infradead.org> References: <20180214182618.14627-1-willy@infradead.org> <20180214182618.14627-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Christopher Lameter Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, Kees Cook , linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com On Wed, Feb 14, 2018 at 01:55:59PM -0600, Christopher Lameter wrote: > On Wed, 14 Feb 2018, Matthew Wilcox wrote: > > > +#define kvzalloc_struct(p, member, n, gfp) \ > > + (typeof(p))kvzalloc_ab_c(n, \ > > + sizeof(*(p)->member) + __must_be_array((p)->member), \ > > + offsetof(typeof(*(p)), member), gfp) > > + > > Uppercase like the similar KMEM_CACHE related macros in > include/linux/slab.h?> Do you think that would look better in the users? Compare: @@ -1284,7 +1284,7 @@ static long vhost_set_memory(struct vhost_dev *d, struct vhost_memory __user *m) return -EOPNOTSUPP; if (mem.nregions > max_mem_regions) return -E2BIG; - newmem = kvzalloc(size + mem.nregions * sizeof(*m->regions), GFP_KERNEL); + newmem = kvzalloc_struct(newmem, regions, mem.nregions, GFP_KERNEL); if (!newmem) return -ENOMEM; @@ -1284,7 +1284,7 @@ static long vhost_set_memory(struct vhost_dev *d, struct vhost_memory __user *m) return -EOPNOTSUPP; if (mem.nregions > max_mem_regions) return -E2BIG; - newmem = kvzalloc(size + mem.nregions * sizeof(*m->regions), GFP_KERNEL); + newmem = KVZALLOC_STRUCT(newmem, regions, mem.nregions, GFP_KERNEL); if (!newmem) return -ENOMEM; Making it look like a function is more pleasing to my eye, but I'll change it if that's the only thing keeping it from being merged. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org