All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pau Espin Pedrol <pespin@sysmocom.de>
To: ofono@ofono.org
Subject: [PATCH] modem: ofono_modem_create: log invalid paths
Date: Thu, 15 Feb 2018 13:22:04 +0100	[thread overview]
Message-ID: <20180215122204.17349-1-pespin@sysmocom.de> (raw)
In-Reply-To: <20180213195338.30077-1-pespin@sysmocom.de>

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

---
 src/modem.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/modem.c b/src/modem.c
index d5fda7ca..698a7ca8 100644
--- a/src/modem.c
+++ b/src/modem.c
@@ -1876,8 +1876,10 @@ struct ofono_modem *ofono_modem_create(const char *name, const char *type)
 	else
 		snprintf(path, sizeof(path), "/%s", name);
 
-	if (!dbus_validate_path(path, NULL))
+	if (!dbus_validate_path(path, NULL)) {
+		DBG("Invalid dbus path for modem: %s", path);
 		return NULL;
+	}
 
 	modem = g_try_new0(struct ofono_modem, 1);
 
-- 
2.16.1


      parent reply	other threads:[~2018-02-15 12:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 19:53 [PATCH] udevng: Add OFONO_PATHNAME property to set modem dbus path name Pau Espin Pedrol
2018-02-14 17:04 ` Denis Kenzior
2018-02-14 18:15   ` Pau Espin Pedrol
2018-02-14 20:31     ` Denis Kenzior
2018-02-15  8:47       ` Christophe Ronco
2018-02-15  8:50         ` [PATCH] add syspath property to modem properties Christophe Ronco
2018-02-15 12:09           ` Pau Espin Pedrol
2018-02-15 15:59           ` Denis Kenzior
2018-02-16 15:40             ` Christophe Ronco
2018-02-16 18:19               ` Denis Kenzior
2018-02-19 14:57                 ` [PATCH 0/3] Add SystemPath property to modem interface Christophe Ronco
2018-02-19 14:57                   ` [PATCH 1/3] udevng: Add modem string SystemPath Christophe Ronco
2018-02-19 14:57                   ` [PATCH 2/3] modem: Add SystemPath dbus property Christophe Ronco
2018-02-19 14:57                   ` [PATCH 3/3] doc: Add SystemPath to Modem interface Christophe Ronco
2018-02-19 15:36                     ` Jonas Bonn
2018-02-19 17:25                       ` Denis Kenzior
2018-02-20  8:57                         ` [PATCH 1/1] " Christophe Ronco
2018-02-20 17:10                   ` [PATCH 0/3] Add SystemPath property to modem interface Denis Kenzior
2018-02-15 12:22 ` Pau Espin Pedrol [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215122204.17349-1-pespin@sysmocom.de \
    --to=pespin@sysmocom.de \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.