From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1164905AbeBORox (ORCPT ); Thu, 15 Feb 2018 12:44:53 -0500 Received: from g4t3426.houston.hpe.com ([15.241.140.75]:39214 "EHLO g4t3426.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946061AbeBORos (ORCPT ); Thu, 15 Feb 2018 12:44:48 -0500 Date: Thu, 15 Feb 2018 10:44:44 -0700 From: Jerry Hoemann To: Ingo Molnar Cc: Borislav Petkov , Tim Chen , Peter Zijlstra , Dave Hansen , hpa@zytor.com, tglx@linutronix.de, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, linux-tip-commits@vger.kernel.org, Arjan van de Ven , linux-watchdog@vger.kernel.org Subject: Re: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context Message-ID: <20180215174444.GA25970@anatevka.americas.hpqcorp.net> Reply-To: Jerry.Hoemann@hpe.com References: <20180212102211.cdrrqqd4hdw7xu5y@gmail.com> <20180212165835.GO25181@hirez.programming.kicks-ass.net> <20180213075540.3lkikkpgjoe6ocjk@gmail.com> <5c3ba123-abbe-f153-7b75-a89d31d25c72@linux.intel.com> <20180214093159.mdzfupne547bi5qx@gmail.com> <20180214094404.GA18349@pd.tnic> <20180214181342.GA27600@anatevka.americas.hpqcorp.net> <20180214231704.xv2iwqsfvljoybul@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180214231704.xv2iwqsfvljoybul@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 15, 2018 at 12:17:04AM +0100, Ingo Molnar wrote: > > * Jerry Hoemann wrote: > > > > > Ingo, > > > > I have a patch set under review that brings hpwdt into compliance > > with the watchdog core. > > > > One of the changes removes the callback into firmware in hpwdt_pretimeout > > and its associated spinlock. > > > > https://lkml.org/lkml/2018/2/12/30 > > drivers/watchdog/hpwdt.c | 490 +---------------------------------------------- > 1 file changed, 8 insertions(+), 482 deletions(-) > > Very nice, and this should solve all the NMI handling complications! > > > I will add you to the CC list of the next version of the set. > > Thanks! > > Ingo Ingo, Is your desire to remove of the firmware callback/spinlock in hpwdt_pretimeout related to David Woodhouse patch set: https://lkml.org/lkml/2018/2/14/305 ? Which I think are to mitigate performance issues resulting from the changes to address the specter/meltdown? Any there other changes to hpwdt needed related to this work? Thanks Jerry -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise -----------------------------------------------------------------------------