All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: alsa-devel@alsa-project.org, Sascha Hauer <kernel@pengutronix.de>,
	Eric Nelson <eric@nelint.com>, Stefan Agner <stefan@agner.ch>,
	Gary Bisson <gary.bisson@boundarydevices.com>,
	Max Krummenacher <max.krummenacher@toradex.com>,
	Richard Leitner <richard.leitner@skidata.com>
Subject: Re: sgtl5000 fails after suspend/resume
Date: Thu, 15 Feb 2018 18:16:32 +0000	[thread overview]
Message-ID: <20180215181632.GJ8374@sirena.org.uk> (raw)
In-Reply-To: <CAOMZO5CyE5T-H=K2Q9A=tYoY9zt0CO4YdFWK5PMS=NR2XbqPzQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 671 bytes --]

On Thu, Feb 15, 2018 at 02:36:00PM -0200, Fabio Estevam wrote:

> Reverting the commit below on top of 4.16-rc1 makes sgtl5000
> suspend/resume to work again:

> @@ -880,8 +880,6 @@ static int sgtl5000_set_bias_level(struct
> snd_soc_component *component,
>                                     SGTL5000_REFTOP_POWERUP);
>                 break;
>         case SND_SOC_BIAS_OFF:
> -               snd_soc_component_update_bits(component,
> SGTL5000_CHIP_ANA_POWER,
> -                                   SGTL5000_REFTOP_POWERUP, 0);
>                 break;
>         }

> Any suggestions for a proper fix? Eric?

Does it need a register map resync when powering on again?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  parent reply	other threads:[~2018-02-15 18:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 13:35 sgtl5000 fails after suspend/resume Fabio Estevam
2018-02-15 16:36 ` Fabio Estevam
2018-02-15 18:11   ` Fabio Estevam
2018-02-15 18:16   ` Mark Brown [this message]
2018-02-15 18:27     ` Fabio Estevam
2018-02-15 18:25   ` Max Krummenacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215181632.GJ8374@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=eric@nelint.com \
    --cc=festevam@gmail.com \
    --cc=gary.bisson@boundarydevices.com \
    --cc=kernel@pengutronix.de \
    --cc=max.krummenacher@toradex.com \
    --cc=richard.leitner@skidata.com \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.