* [PATCH] ARM: sunxi: Fix multi-cluster SMP support compilation in multi v6/v7 configs
@ 2018-02-17 5:01 ` Chen-Yu Tsai
0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2018-02-17 5:01 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Chen-Yu Tsai, linux-arm-kernel, linux-kernel
Various parts of the assembly code used in the multi-cluster SMP support
requires ARMv7-A. If the kernel config also has multi v6 support enabled,
Kbuild defaults to building for armv6k, which does not support some of
the instructions we use.
Configure the Makefile such that the multi-cluster SMP code is always
built for ARMv7-A. This is also what mach-exynos does for their MC-SMP
code.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
This addresses "[sunxi:sunxi/core-for-4.17 1/4] /tmp/ccSQM2rD.s:438:
Error: selected processor does not support `isb' in ARM mode"
reported by the kbuild test robot for arm-allmodconfig.
Should we apply it, or squash it in the original patch?
---
arch/arm/mach-sunxi/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile
index 3e741e959c7c..3c2c4384357a 100644
--- a/arch/arm/mach-sunxi/Makefile
+++ b/arch/arm/mach-sunxi/Makefile
@@ -1,3 +1,4 @@
obj-$(CONFIG_ARCH_SUNXI) += sunxi.o
obj-$(CONFIG_ARCH_SUNXI_MC_SMP) += mc_smp.o
+CFLAGS_mc_smp.o += -march=armv7-a
obj-$(CONFIG_SMP) += platsmp.o
--
2.16.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: sunxi: Fix multi-cluster SMP support compilation in multi v6/v7 configs
@ 2018-02-17 5:01 ` Chen-Yu Tsai
0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2018-02-17 5:01 UTC (permalink / raw)
To: linux-arm-kernel
Various parts of the assembly code used in the multi-cluster SMP support
requires ARMv7-A. If the kernel config also has multi v6 support enabled,
Kbuild defaults to building for armv6k, which does not support some of
the instructions we use.
Configure the Makefile such that the multi-cluster SMP code is always
built for ARMv7-A. This is also what mach-exynos does for their MC-SMP
code.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
This addresses "[sunxi:sunxi/core-for-4.17 1/4] /tmp/ccSQM2rD.s:438:
Error: selected processor does not support `isb' in ARM mode"
reported by the kbuild test robot for arm-allmodconfig.
Should we apply it, or squash it in the original patch?
---
arch/arm/mach-sunxi/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile
index 3e741e959c7c..3c2c4384357a 100644
--- a/arch/arm/mach-sunxi/Makefile
+++ b/arch/arm/mach-sunxi/Makefile
@@ -1,3 +1,4 @@
obj-$(CONFIG_ARCH_SUNXI) += sunxi.o
obj-$(CONFIG_ARCH_SUNXI_MC_SMP) += mc_smp.o
+CFLAGS_mc_smp.o += -march=armv7-a
obj-$(CONFIG_SMP) += platsmp.o
--
2.16.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: sunxi: Fix multi-cluster SMP support compilation in multi v6/v7 configs
2018-02-17 5:01 ` Chen-Yu Tsai
@ 2018-02-19 8:05 ` Maxime Ripard
-1 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2018-02-19 8:05 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]
On Sat, Feb 17, 2018 at 01:01:12PM +0800, Chen-Yu Tsai wrote:
> Various parts of the assembly code used in the multi-cluster SMP support
> requires ARMv7-A. If the kernel config also has multi v6 support enabled,
> Kbuild defaults to building for armv6k, which does not support some of
> the instructions we use.
>
> Configure the Makefile such that the multi-cluster SMP code is always
> built for ARMv7-A. This is also what mach-exynos does for their MC-SMP
> code.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>
> This addresses "[sunxi:sunxi/core-for-4.17 1/4] /tmp/ccSQM2rD.s:438:
> Error: selected processor does not support `isb' in ARM mode"
> reported by the kbuild test robot for arm-allmodconfig.
>
> Should we apply it, or squash it in the original patch?
I guess we can squash it. And while you're at it..
> ---
> arch/arm/mach-sunxi/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile
> index 3e741e959c7c..3c2c4384357a 100644
> --- a/arch/arm/mach-sunxi/Makefile
> +++ b/arch/arm/mach-sunxi/Makefile
> @@ -1,3 +1,4 @@
> obj-$(CONFIG_ARCH_SUNXI) += sunxi.o
> obj-$(CONFIG_ARCH_SUNXI_MC_SMP) += mc_smp.o
> +CFLAGS_mc_smp.o += -march=armv7-a
Can you move it to the first line of the file (before the other obj-*)
with a newline after it?
Thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: sunxi: Fix multi-cluster SMP support compilation in multi v6/v7 configs
@ 2018-02-19 8:05 ` Maxime Ripard
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2018-02-19 8:05 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Feb 17, 2018 at 01:01:12PM +0800, Chen-Yu Tsai wrote:
> Various parts of the assembly code used in the multi-cluster SMP support
> requires ARMv7-A. If the kernel config also has multi v6 support enabled,
> Kbuild defaults to building for armv6k, which does not support some of
> the instructions we use.
>
> Configure the Makefile such that the multi-cluster SMP code is always
> built for ARMv7-A. This is also what mach-exynos does for their MC-SMP
> code.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>
> This addresses "[sunxi:sunxi/core-for-4.17 1/4] /tmp/ccSQM2rD.s:438:
> Error: selected processor does not support `isb' in ARM mode"
> reported by the kbuild test robot for arm-allmodconfig.
>
> Should we apply it, or squash it in the original patch?
I guess we can squash it. And while you're at it..
> ---
> arch/arm/mach-sunxi/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile
> index 3e741e959c7c..3c2c4384357a 100644
> --- a/arch/arm/mach-sunxi/Makefile
> +++ b/arch/arm/mach-sunxi/Makefile
> @@ -1,3 +1,4 @@
> obj-$(CONFIG_ARCH_SUNXI) += sunxi.o
> obj-$(CONFIG_ARCH_SUNXI_MC_SMP) += mc_smp.o
> +CFLAGS_mc_smp.o += -march=armv7-a
Can you move it to the first line of the file (before the other obj-*)
with a newline after it?
Thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180219/e71cfd37/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: sunxi: Fix multi-cluster SMP support compilation in multi v6/v7 configs
2018-02-19 8:05 ` Maxime Ripard
@ 2018-02-20 3:17 ` Chen-Yu Tsai
-1 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2018-02-20 3:17 UTC (permalink / raw)
To: Maxime Ripard; +Cc: linux-arm-kernel, linux-kernel
On Mon, Feb 19, 2018 at 4:05 PM, Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
> On Sat, Feb 17, 2018 at 01:01:12PM +0800, Chen-Yu Tsai wrote:
>> Various parts of the assembly code used in the multi-cluster SMP support
>> requires ARMv7-A. If the kernel config also has multi v6 support enabled,
>> Kbuild defaults to building for armv6k, which does not support some of
>> the instructions we use.
>>
>> Configure the Makefile such that the multi-cluster SMP code is always
>> built for ARMv7-A. This is also what mach-exynos does for their MC-SMP
>> code.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>>
>> This addresses "[sunxi:sunxi/core-for-4.17 1/4] /tmp/ccSQM2rD.s:438:
>> Error: selected processor does not support `isb' in ARM mode"
>> reported by the kbuild test robot for arm-allmodconfig.
>>
>> Should we apply it, or squash it in the original patch?
>
> I guess we can squash it. And while you're at it..
>
>> ---
>> arch/arm/mach-sunxi/Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile
>> index 3e741e959c7c..3c2c4384357a 100644
>> --- a/arch/arm/mach-sunxi/Makefile
>> +++ b/arch/arm/mach-sunxi/Makefile
>> @@ -1,3 +1,4 @@
>> obj-$(CONFIG_ARCH_SUNXI) += sunxi.o
>> obj-$(CONFIG_ARCH_SUNXI_MC_SMP) += mc_smp.o
>> +CFLAGS_mc_smp.o += -march=armv7-a
>
> Can you move it to the first line of the file (before the other obj-*)
> with a newline after it?
Done and done.
ChenYu
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: sunxi: Fix multi-cluster SMP support compilation in multi v6/v7 configs
@ 2018-02-20 3:17 ` Chen-Yu Tsai
0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2018-02-20 3:17 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 19, 2018 at 4:05 PM, Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
> On Sat, Feb 17, 2018 at 01:01:12PM +0800, Chen-Yu Tsai wrote:
>> Various parts of the assembly code used in the multi-cluster SMP support
>> requires ARMv7-A. If the kernel config also has multi v6 support enabled,
>> Kbuild defaults to building for armv6k, which does not support some of
>> the instructions we use.
>>
>> Configure the Makefile such that the multi-cluster SMP code is always
>> built for ARMv7-A. This is also what mach-exynos does for their MC-SMP
>> code.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>>
>> This addresses "[sunxi:sunxi/core-for-4.17 1/4] /tmp/ccSQM2rD.s:438:
>> Error: selected processor does not support `isb' in ARM mode"
>> reported by the kbuild test robot for arm-allmodconfig.
>>
>> Should we apply it, or squash it in the original patch?
>
> I guess we can squash it. And while you're at it..
>
>> ---
>> arch/arm/mach-sunxi/Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile
>> index 3e741e959c7c..3c2c4384357a 100644
>> --- a/arch/arm/mach-sunxi/Makefile
>> +++ b/arch/arm/mach-sunxi/Makefile
>> @@ -1,3 +1,4 @@
>> obj-$(CONFIG_ARCH_SUNXI) += sunxi.o
>> obj-$(CONFIG_ARCH_SUNXI_MC_SMP) += mc_smp.o
>> +CFLAGS_mc_smp.o += -march=armv7-a
>
> Can you move it to the first line of the file (before the other obj-*)
> with a newline after it?
Done and done.
ChenYu
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-20 3:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-17 5:01 [PATCH] ARM: sunxi: Fix multi-cluster SMP support compilation in multi v6/v7 configs Chen-Yu Tsai
2018-02-17 5:01 ` Chen-Yu Tsai
2018-02-19 8:05 ` Maxime Ripard
2018-02-19 8:05 ` Maxime Ripard
2018-02-20 3:17 ` Chen-Yu Tsai
2018-02-20 3:17 ` Chen-Yu Tsai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.