All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, Ilan Peer <ilan.peer@intel.com>,
	Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 7/9] iwlwifi: mvm: Direct multicast frames to the correct station
Date: Sat, 17 Feb 2018 10:33:52 +0200	[thread overview]
Message-ID: <20180217083354.31160-8-luca@coelho.fi> (raw)
In-Reply-To: <20180217083354.31160-1-luca@coelho.fi>

From: Ilan Peer <ilan.peer@intel.com>

Multicast frames for NL80211_IFTYPE_AP and NL80211_IFTYPE_ADHOC were
directed to the broadcast station, however, as the broadcast station
did not have keys configured, these frames were sent unencrypted.

Fix this by using the multicast station which is the station for which
encryption keys are configured.

Signed-off-by: Ilan Peer <ilan.peer@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
index 57ad6019ffad..af6dfceab6b8 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
@@ -648,7 +648,11 @@ int iwl_mvm_tx_skb_non_sta(struct iwl_mvm *mvm, struct sk_buff *skb)
 		if (info.control.vif->type == NL80211_IFTYPE_P2P_DEVICE ||
 		    info.control.vif->type == NL80211_IFTYPE_AP ||
 		    info.control.vif->type == NL80211_IFTYPE_ADHOC) {
-			sta_id = mvmvif->bcast_sta.sta_id;
+			if (info.control.vif->type == NL80211_IFTYPE_P2P_DEVICE)
+				sta_id = mvmvif->bcast_sta.sta_id;
+			else
+				sta_id = mvmvif->mcast_sta.sta_id;
+
 			queue = iwl_mvm_get_ctrl_vif_queue(mvm, &info,
 							   hdr->frame_control);
 			if (queue < 0)
-- 
2.15.1

  parent reply	other threads:[~2018-02-17  8:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-17  8:33 [PATCH 0/9] iwlwifi: fixes intended for 4.16 2018-02-17 Luca Coelho
2018-02-17  8:33 ` [PATCH 1/9] iwlwifi: Cancel and set MARKER_CMD timer during suspend-resume Luca Coelho
2018-02-17  8:33 ` [PATCH 2/9] iwlwifi: mvm: fix TX of CCMP 256 Luca Coelho
2018-02-17  8:33 ` [PATCH 3/9] iwlwifi: mvm: Fix channel switch for count 0 and 1 Luca Coelho
2018-02-17  8:33 ` [PATCH 4/9] iwlwifi: mvm: fix assert 0x2B00 on older FWs Luca Coelho
2018-02-17  8:33 ` [PATCH 5/9] iwlwifi: avoid collecting firmware dump if not loaded Luca Coelho
2018-02-17  8:33 ` [PATCH 6/9] iwlwifi: mvm: fix "failed to remove key" message Luca Coelho
2018-02-17  8:33 ` Luca Coelho [this message]
2018-02-17  8:33 ` [PATCH 8/9] iwlwifi: mvm: Correctly set the tid for mcast queue Luca Coelho
2018-02-17  8:33 ` [PATCH 9/9] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180217083354.31160-8-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=ilan.peer@intel.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.