From: Ingo Molnar <mingo@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Baoquan He <bhe@redhat.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org,
douly.fnst@cn.fujitsu.com, joro@8bytes.org, uobergfe@redhat.com,
prarit@redhat.com
Subject: Re: [PATCH v5 0/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump
Date: Sat, 17 Feb 2018 11:17:59 +0100 [thread overview]
Message-ID: <20180217101759.4hn7tdqgudxcq4rk@gmail.com> (raw)
In-Reply-To: <87a7w8wxr1.fsf@xmission.com>
* Eric W. Biederman <ebiederm@xmission.com> wrote:
> Ingo Molnar <mingo@kernel.org> writes:
>
> > * Baoquan He <bhe@redhat.com> wrote:
> >
> >> This is v5 post. Newly added patch 0002 includes the change
> >> related to KEXEC_JUMP path. Patch 0003 only includes the
> >> regression fix.
> >>
> >> A regression bug was introduced in below commit.
> >> commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC")
> >>
> >> It caused the action to fail that we try to restore boot irq mode
> >> in reboot and kexec/kdump. Details can be seen in patch 0003.
> >>
> >> Warning can always be seen during kdump kernel boot on qemu/kvm
> >> platform. Our customer even saw casual kdump kernel hang once in
> >> ~30 attempts during stress testing of kdump on KVM machine.
> >>
> >> v4->v5:
> >> Take out the change related to KEXEC_JUMP to a new patch 0002
> >> according to Eric's suggestion.
> >> Patch 0003 in this series only includes the regression fix.
> >>
> >> v3->v4:
> >> Eric pointed out that in patch 0002 the change related to
> >> KEXEC_JUMP is not right.
> >> Correct it.
> >>
> >> Add Fixes tag and Cc to stable.
> >
> > Eric, are these patches looking good to you now?
>
> The result of applying the patches looks good.
> Barring whatever fix to header files that kbuild seems to find necessary.
>
> I wish patches 1 2 and 4 were all the same patch. That I think would
> make reading the patches a bit easier, and make the backports clearer.
> But at this point that is just me bike-shedding.
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Thank you!
Ingo
prev parent reply other threads:[~2018-02-17 10:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 5:46 [PATCH v5 0/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump Baoquan He
2018-02-14 5:46 ` [PATCH v5 1/6] x86/apic: Split out restore_boot_irq_mode from disable_IO_APIC Baoquan He
2018-02-17 11:41 ` [tip:x86/apic] x86/apic: Split out restore_boot_irq_mode() from disable_IO_APIC() tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 2/6] x86/apic: Replace disable_IO_APIC for KEXEC_JUMP Baoquan He
2018-02-17 11:41 ` [tip:x86/apic] x86/apic: Split disable_IO_APIC() into two functions to fix CONFIG_KEXEC_JUMP=y tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 3/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump Baoquan He
2018-02-17 11:42 ` [tip:x86/apic] x86/apic: Fix restoring boot IRQ " tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 4/6] x86/apic: Remove useless disable_IO_APIC Baoquan He
2018-02-17 11:42 ` [tip:x86/apic] x86/apic: Remove the (now) unused disable_IO_APIC() function tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 5/6] x86/apic: Rename variable/function related to x86_io_apic_ops Baoquan He
2018-02-17 11:43 ` [tip:x86/apic] x86/apic: Rename variables and functions " tip-bot for Baoquan He
2018-02-14 5:46 ` [PATCH v5 6/6] x86/apic: Set up through-local-APIC on boot CPU if 'noapic' specified Baoquan He
2018-02-17 11:43 ` [tip:x86/apic] x86/apic: Set up through-local-APIC mode on the " tip-bot for Baoquan He
2018-02-16 9:38 ` [PATCH v5 0/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump Ingo Molnar
2018-02-16 10:24 ` Baoquan He
2018-02-17 10:46 ` Ingo Molnar
2018-02-17 11:28 ` Baoquan He
2018-02-16 19:16 ` Eric W. Biederman
2018-02-17 10:17 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180217101759.4hn7tdqgudxcq4rk@gmail.com \
--to=mingo@kernel.org \
--cc=bhe@redhat.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=uobergfe@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.