From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 50DF11C05C2 for ; Sat, 17 Feb 2018 12:28:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4D47488922 for ; Sat, 17 Feb 2018 12:28:52 +0000 (UTC) Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aZL3YkocZB8Z for ; Sat, 17 Feb 2018 12:28:51 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by fraxinus.osuosl.org (Postfix) with ESMTPS id CD6408891B for ; Sat, 17 Feb 2018 12:28:51 +0000 (UTC) Date: Sat, 17 Feb 2018 13:12:02 +0100 From: Greg KH Subject: Re: [PATCH] Staging: ks7010: Fix Unnecessary parentheses in ks_hostif.c Message-ID: <20180217121202.GB10940@kroah.com> References: <20180217072846.10721-1-yashomer0007@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180217072846.10721-1-yashomer0007@gmail.com> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Yash Omer Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, driverdev-devel@linuxdriverproject.org, Larry.Finger@lwfinger.net On Sat, Feb 17, 2018 at 12:58:46PM +0530, Yash Omer wrote: > This patch fixes up unnecessary parenthesis issue found by checkpatch.pl > > Signed-off-by: Yash Omer > --- > drivers/staging/ks7010/ks_hostif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index 975dbbb3abd0..7bd567e233d7 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -850,7 +850,7 @@ void hostif_scan_indication(struct ks_wlan_private *priv) > DPRINTK(4, " scan_ind_count=%d :: aplist.size=%d\n", > priv->scan_ind_count, priv->aplist.size); > get_ap_information(priv, (struct ap_info_t *)(priv->rxp), > - &(priv->aplist.ap[priv->scan_ind_count - 1])); > + &(priv->aplist.ap priv->scan_ind_count - 1)); Did you actually compile this? Please, step back and go learn the C language first really really well. The change you made here is obviously not correct at all. I suggest you work on userspace programs first for a few years before working on the kernel, it is not a place to learn how to program. good luck! greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel