All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <mmarek@suse.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/3] Kconfig: disable PROFILE_ALL_BRANCHES for compile testing
Date: Sat, 17 Feb 2018 14:32:24 +0100	[thread overview]
Message-ID: <20180217133224.GA25994@kroah.com> (raw)
In-Reply-To: <CAK8P3a1ZvA3dk8qRXaF_yjirYTYkvuCggh8x7QU_p+vMxpTPNA@mail.gmail.com>

On Fri, Feb 16, 2018 at 11:14:42PM +0100, Arnd Bergmann wrote:
> On Fri, Feb 16, 2018 at 11:03 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Fri, 16 Feb 2018 22:41:11 +0100
> > Arnd Bergmann <arnd@arndb.de> wrote:
> >
> >> This can easily double the time for compiling a driver but does not
> >> provide any benefit for the compile tester, so it's better left disabled.
> >>
> >> In addition, any 'inline' function that is not also 'static' and that
> >> contains an 'if' causes a warning like
> >>
> >> include/linux/string.h:212:2: note: in expansion of macro 'if'
> >>   if (strscpy(p, q, p_size < q_size ? p_size : q_size) < 0)
> >>   ^~
> >> include/linux/compiler.h:162:4: warning: '______f' is static but declared in inline function 'strcpy' which is not static
> >>
> >> without this patch, and I could not come up with a nice fix for that.
> >> In combination with my patch to always enable 'CONFIG_COMPILE_TEST'
> >> during 'randconfig' builds, we can at least hide these warnings for
> >> most users.
> >
> > This looks like it fixes the same issue that was already fixed and is
> > in Linus's tree.
> >
> >  http://lkml.kernel.org/r/9199446b-a141-c0c3-9678-a3f9107f2750@infradead.org
> >
> > See commit 68e76e034b6b1 ("tracing: Prevent PROFILE_ALL_BRANCHES when
> > FORTIFY_SOURCE=y")
> 
> Ah, right. I missed that when I wrote the new changelog text for this old
> patch of mine. It also means I should rebase the patch so it applies
> on mainline, as I still want PROFILE_ALL_BRANCHES to be disabled
> in COMPILE_TEST kernels for the build speed aspect.
> 
> Greg, could you add the 68e76e034b6b1 commit to 4.14-stable and
> 4.15-stable in the meantime?

It's already in 4.15, so I'll just queue it up to 4.14.y.

thanks,

greg k-h

  parent reply	other threads:[~2018-02-17 13:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 21:41 [PATCH 0/3] fixing the last failures in randconfig builds Arnd Bergmann
2018-02-16 21:41 ` [PATCH 1/3] Kconfig: disable PROFILE_ALL_BRANCHES for compile testing Arnd Bergmann
2018-02-16 22:03   ` Steven Rostedt
2018-02-16 22:14     ` Arnd Bergmann
2018-02-16 22:40       ` Arnd Bergmann
2018-02-16 22:50         ` Steven Rostedt
2018-02-17 13:32       ` Greg Kroah-Hartman [this message]
2018-02-20  9:32   ` Masahiro Yamada
2018-02-16 21:41 ` [PATCH 2/3] Kconfig: improve handling for all{rand,yes,no,}.config fragments Arnd Bergmann
2018-02-20  9:26   ` Masahiro Yamada
2018-02-20  9:59     ` Arnd Bergmann
2018-02-20 17:04       ` Masahiro Yamada
2018-02-21 16:57         ` Arnd Bergmann
2018-02-22 17:27           ` Masahiro Yamada
2018-02-23  4:13           ` Masahiro Yamada
2018-02-16 21:41 ` [PATCH 3/3] Kconfig: add a default allrandom.config Arnd Bergmann
2018-02-20  9:16   ` Masahiro Yamada
2018-02-20  9:16     ` Masahiro Yamada
2018-02-20 11:11     ` Arnd Bergmann
2018-02-20 16:51       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180217133224.GA25994@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.