From: Luca Coelho <luca@coelho.fi>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
Sara Sharon <sara.sharon@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH v2 01/13] mac80211: fix a possible leak of station stats
Date: Mon, 19 Feb 2018 14:48:35 +0200 [thread overview]
Message-ID: <20180219124847.27169-2-luca@coelho.fi> (raw)
In-Reply-To: <20180219124847.27169-1-luca@coelho.fi>
From: Sara Sharon <sara.sharon@intel.com>
If sta_info_alloc fails after allocating the per CPU statistics,
they are not properly freed.
Fixes: c9c5962b56c1 ("mac80211: enable collecting station statistics per-CPU")
Signed-off-by: Sara Sharon <sara.sharon@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
net/mac80211/sta_info.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 0c5627f8a104..8d7e3732bb61 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -433,6 +433,7 @@ struct sta_info *sta_info_alloc(struct ieee80211_sub_if_data *sdata,
if (sta->sta.txq[0])
kfree(to_txq_info(sta->sta.txq[0]));
free:
+ free_percpu(sta->pcpu_rx_stats);
#ifdef CONFIG_MAC80211_MESH
kfree(sta->mesh);
#endif
--
2.15.1
next prev parent reply other threads:[~2018-02-19 12:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 12:48 [PATCH v2 00/13] cfg80211/mac80211 patches from our internal tree 2018-02-16 Luca Coelho
2018-02-19 12:48 ` Luca Coelho [this message]
2018-02-19 12:48 ` [PATCH v2 02/13] mac80211: ibss: send a probe request instead of allocating station Luca Coelho
2018-02-19 12:56 ` Luca Coelho
2018-02-19 12:48 ` [PATCH v2 03/13] mac80211: fix calling sleeping function in atomic context Luca Coelho
2018-02-19 12:48 ` [PATCH v2 04/13] cfg80211: clear wep keys after disconnection Luca Coelho
2018-02-19 12:48 ` [PATCH v2 05/13] mac80211: support reporting A-MPDU EOF bit value/known Luca Coelho
2018-02-19 12:48 ` [PATCH v2 06/13] mac80211: add get TID helper Luca Coelho
2018-02-19 12:48 ` [PATCH v2 07/13] mac80211: Call mgd_prep_tx before transmitting deauthentication Luca Coelho
2018-02-19 12:48 ` [PATCH v2 08/13] mac80211: Do not disconnect on invalid operating class Luca Coelho
2018-02-19 12:48 ` [PATCH v2 09/13] mac80211: Fix sending ADDBA response for an ongoing session Luca Coelho
2018-02-19 12:48 ` [PATCH v2 10/13] mac80211: agg-rx: Accept ADDBA request update if timeout did not change Luca Coelho
2018-02-19 12:48 ` [PATCH v2 11/13] cfg80211: read wmm rules from regulatory database Luca Coelho
2018-02-19 13:30 ` Johannes Berg
2018-02-27 22:19 ` Seth Forshee
2018-02-28 8:06 ` Johannes Berg
2018-02-19 12:48 ` [PATCH v2 12/13] mac80211: limit wmm params to comply with ETSI requirements Luca Coelho
2018-02-19 12:48 ` [PATCH v2 13/13] cfg80211: Add API to allow querying regdb for wmm_rule Luca Coelho
2018-02-27 10:39 ` Johannes Berg
2018-02-27 11:38 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219124847.27169-2-luca@coelho.fi \
--to=luca@coelho.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=sara.sharon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.