From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832AbeBSOrj (ORCPT ); Mon, 19 Feb 2018 09:47:39 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:36282 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbeBSOrh (ORCPT ); Mon, 19 Feb 2018 09:47:37 -0500 X-Google-Smtp-Source: AH8x227m+4uh50vfC2STiPNvKPMWKMgH0suDxGGF1aWznDW/kH9cAf8DN/UkAMI8H1MGvvFGEfpzTw== Date: Mon, 19 Feb 2018 08:47:35 -0600 From: Rob Herring To: Ludovic Barre Cc: Ulf Hansson , Maxime Coquelin , Alexandre Torgue , Gerald Baeza , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 1/5] dt-bindings: mmc: document the stm32 sdmmc bindings Message-ID: <20180219144735.sbxa76z6aik3w453@rob-hp-laptop> References: <1518701697-14242-1-git-send-email-ludovic.Barre@st.com> <1518701697-14242-2-git-send-email-ludovic.Barre@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518701697-14242-2-git-send-email-ludovic.Barre@st.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 15, 2018 at 02:34:53PM +0100, Ludovic Barre wrote: > From: Ludovic Barre > > Document the binding for stm32 sdmmc controller. > > Signed-off-by: Ludovic Barre > --- > .../devicetree/bindings/mmc/st,stm32-sdmmc.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt b/Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt > new file mode 100644 > index 0000000..52eb1f8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt > @@ -0,0 +1,35 @@ > +* STMicroelectronics STM32 SDMMC controller > + > +The highspeed MMC host controller on STM32 soc family > +provides an interface for MMC, SD and SDIO types of memory cards. > + > +This file documents differences between the core properties described > +by mmc.txt and the properties used by the sdmmc driver. > + > +Required properties: > + - compatible: Should be "st,stm32h7-sdmmc" > + - reg: mmc controller base registers > + - interrupts: Should contain the interrupt number > + - clocks: Should contain phandle for the clock feeding the controller > + - resets: Should contain phandle for the reset feeding the controller > + > +Optional property: > +- st,dirpol: Allow to select direction polarity of external voltage This doesn't need to be so terse. Perhaps "st,dir-output-high". > + transceiver (which manage data and command direction). > + if set: Voltage transceiver IOs are driven as output when direction signals are high, > + else: Voltage transceiver IOs are driven as output when direction signals are low. > +- st,negedge: generate data & command on sdmmc clock falling edge st,neg-edge > +- st,pin-ckin: use sdmmc_ckin pin from an external driver to sample > + the receive data (example: with voltage switch transceiver). st,use-ckin > + > +Example: > + sdmmc1: sdmmc@52007000 { mmc@... > + compatible = "st,stm32h7-sdmmc"; > + reg = <0x52007000 0x1000>; > + interrupts = <49>; > + clocks = <&rcc SDMMC1_CK>; > + resets = <&rcc SDMMC1_R>; > + bus-width = <4>; > + cap-sd-highspeed; > + cap-mmc-highspeed; > + }; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/5] dt-bindings: mmc: document the stm32 sdmmc bindings Date: Mon, 19 Feb 2018 08:47:35 -0600 Message-ID: <20180219144735.sbxa76z6aik3w453@rob-hp-laptop> References: <1518701697-14242-1-git-send-email-ludovic.Barre@st.com> <1518701697-14242-2-git-send-email-ludovic.Barre@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1518701697-14242-2-git-send-email-ludovic.Barre@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ludovic Barre Cc: devicetree@vger.kernel.org, Ulf Hansson , Alexandre Torgue , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Gerald Baeza , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Thu, Feb 15, 2018 at 02:34:53PM +0100, Ludovic Barre wrote: > From: Ludovic Barre > > Document the binding for stm32 sdmmc controller. > > Signed-off-by: Ludovic Barre > --- > .../devicetree/bindings/mmc/st,stm32-sdmmc.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt b/Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt > new file mode 100644 > index 0000000..52eb1f8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt > @@ -0,0 +1,35 @@ > +* STMicroelectronics STM32 SDMMC controller > + > +The highspeed MMC host controller on STM32 soc family > +provides an interface for MMC, SD and SDIO types of memory cards. > + > +This file documents differences between the core properties described > +by mmc.txt and the properties used by the sdmmc driver. > + > +Required properties: > + - compatible: Should be "st,stm32h7-sdmmc" > + - reg: mmc controller base registers > + - interrupts: Should contain the interrupt number > + - clocks: Should contain phandle for the clock feeding the controller > + - resets: Should contain phandle for the reset feeding the controller > + > +Optional property: > +- st,dirpol: Allow to select direction polarity of external voltage This doesn't need to be so terse. Perhaps "st,dir-output-high". > + transceiver (which manage data and command direction). > + if set: Voltage transceiver IOs are driven as output when direction signals are high, > + else: Voltage transceiver IOs are driven as output when direction signals are low. > +- st,negedge: generate data & command on sdmmc clock falling edge st,neg-edge > +- st,pin-ckin: use sdmmc_ckin pin from an external driver to sample > + the receive data (example: with voltage switch transceiver). st,use-ckin > + > +Example: > + sdmmc1: sdmmc@52007000 { mmc@... > + compatible = "st,stm32h7-sdmmc"; > + reg = <0x52007000 0x1000>; > + interrupts = <49>; > + clocks = <&rcc SDMMC1_CK>; > + resets = <&rcc SDMMC1_R>; > + bus-width = <4>; > + cap-sd-highspeed; > + cap-mmc-highspeed; > + }; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Mon, 19 Feb 2018 08:47:35 -0600 Subject: [PATCH 1/5] dt-bindings: mmc: document the stm32 sdmmc bindings In-Reply-To: <1518701697-14242-2-git-send-email-ludovic.Barre@st.com> References: <1518701697-14242-1-git-send-email-ludovic.Barre@st.com> <1518701697-14242-2-git-send-email-ludovic.Barre@st.com> Message-ID: <20180219144735.sbxa76z6aik3w453@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Feb 15, 2018 at 02:34:53PM +0100, Ludovic Barre wrote: > From: Ludovic Barre > > Document the binding for stm32 sdmmc controller. > > Signed-off-by: Ludovic Barre > --- > .../devicetree/bindings/mmc/st,stm32-sdmmc.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt b/Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt > new file mode 100644 > index 0000000..52eb1f8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/st,stm32-sdmmc.txt > @@ -0,0 +1,35 @@ > +* STMicroelectronics STM32 SDMMC controller > + > +The highspeed MMC host controller on STM32 soc family > +provides an interface for MMC, SD and SDIO types of memory cards. > + > +This file documents differences between the core properties described > +by mmc.txt and the properties used by the sdmmc driver. > + > +Required properties: > + - compatible: Should be "st,stm32h7-sdmmc" > + - reg: mmc controller base registers > + - interrupts: Should contain the interrupt number > + - clocks: Should contain phandle for the clock feeding the controller > + - resets: Should contain phandle for the reset feeding the controller > + > +Optional property: > +- st,dirpol: Allow to select direction polarity of external voltage This doesn't need to be so terse. Perhaps "st,dir-output-high". > + transceiver (which manage data and command direction). > + if set: Voltage transceiver IOs are driven as output when direction signals are high, > + else: Voltage transceiver IOs are driven as output when direction signals are low. > +- st,negedge: generate data & command on sdmmc clock falling edge st,neg-edge > +- st,pin-ckin: use sdmmc_ckin pin from an external driver to sample > + the receive data (example: with voltage switch transceiver). st,use-ckin > + > +Example: > + sdmmc1: sdmmc at 52007000 { mmc at ... > + compatible = "st,stm32h7-sdmmc"; > + reg = <0x52007000 0x1000>; > + interrupts = <49>; > + clocks = <&rcc SDMMC1_CK>; > + resets = <&rcc SDMMC1_R>; > + bus-width = <4>; > + cap-sd-highspeed; > + cap-mmc-highspeed; > + }; > -- > 2.7.4 >