From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH nf] netfilter: IDLETIMER: be syzkaller friendly
Date: Mon, 19 Feb 2018 18:27:16 +0100 [thread overview]
Message-ID: <20180219172716.vf4chjy5rgoyvhwm@salvia> (raw)
In-Reply-To: <1518838588.55655.10.camel@gmail.com>
On Fri, Feb 16, 2018 at 07:36:28PM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> We had one report from syzkaller [1]
>
> First issue is that INIT_WORK() should be done before mod_timer()
> or we risk timer being fired too soon, even with a 1 second timer.
>
> Second issue is that we need to reject too big info->timeout
> to avoid overflows in msecs_to_jiffies(info->timeout * 1000), or
> risk looping, if result after overflow is 0.
Applied, thanks!
prev parent reply other threads:[~2018-02-19 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 3:36 [PATCH nf] netfilter: IDLETIMER: be syzkaller friendly Eric Dumazet
2018-02-19 17:27 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219172716.vf4chjy5rgoyvhwm@salvia \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.