From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932205AbeBSWqK (ORCPT ); Mon, 19 Feb 2018 17:46:10 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46578 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932180AbeBSWqK (ORCPT ); Mon, 19 Feb 2018 17:46:10 -0500 From: Enric Balletbo i Serra To: Lee Jones Cc: groeck@chromium.org, gwendal@chromium.org, bleung@chromium.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Vincent Palatin Subject: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC Date: Mon, 19 Feb 2018 23:46:02 +0100 Message-Id: <20180219224602.22582-1-enric.balletbo@collabora.com> X-Mailer: git-send-email 2.16.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vincent Palatin If we cannot communicate with the EC chip to detect the protocol version and its features, it's very likely useless to continue. Else we will commit all kind of uninformed mistakes (using the wrong protocol, the wrong buffer size, mixing the EC with other chips). Signed-off-by: Vincent Palatin Acked-by: Benson Leung Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index d61024141e2b..74780f2964a1 100644 --- a/drivers/mfd/cros_ec.c +++ b/drivers/mfd/cros_ec.c @@ -112,7 +112,11 @@ int cros_ec_register(struct cros_ec_device *ec_dev) mutex_init(&ec_dev->lock); - cros_ec_query_all(ec_dev); + err = cros_ec_query_all(ec_dev); + if (err) { + dev_err(dev, "Cannot identify the EC: error %d\n", err); + return err; + } if (ec_dev->irq) { err = request_threaded_irq(ec_dev->irq, NULL, ec_irq_thread, -- 2.16.1