From: Andrew Jeffery <andrew@aj.id.au>
To: joel@jms.id.au, jk@ozlabs.org, eajames@linux.vnet.ibm.com,
bradleyb@fuzziesquirrel.com, cbostic@linux.vnet.ibm.com
Cc: Andrew Jeffery <andrew@aj.id.au>, openbmc@lists.ozlabs.org
Subject: [PATCH linux dev-4.13 00/16] Locking fixes for FSI, SBEFIFO, OCC
Date: Tue, 20 Feb 2018 14:48:28 +1030 [thread overview]
Message-ID: <20180220041844.13228-1-andrew@aj.id.au> (raw)
Hello,
This is a forward-port to dev-4.13 of my dev-4.10 series aimed at fixing the
locking and work scheduling for the OCC stack:
Cover Letter: https://lists.ozlabs.org/pipermail/openbmc/2018-February/010793.html
Patch Series: http://patchwork.ozlabs.org/project/openbmc/list/?series=28746&state=%2A&archive=both
The dev-4.13 series adds several new patches:
0001-dts-fsi-Make-OCC-description-match-expected-hierarch.patch
dev-4.13 as it stood failed to get the OCC driver stack up and running due to
broken descriptions in the devicetree with respect to the drivers'
implementations. Patch 1 fixes this by making the devicetree reflect what the
drivers expect, but the fact remains that this is an abuse of the devicetree.
We need to have a discussion about how best to instantiate the hwmon driver and
fix what we're doing here.
0002-hwmon-p9_sbe-Initialise-device-spin-lock.patch
Patch 2 fixes what appears to be an oversight in lock initialisation in the
p9_sbe OCC hwmon implementation.
0011-hwmon-p9_sbe-Add-static-key-to-satisfy-lockdep.patch
Finally, patch 11 shuts up lockdep in the p9_sbe OCC hwmon implementation,
which was whinging due to dynamic mutex allocation. Kernel locking experts
should feel free to chime in as I don't know that this is actually the right
fix.
Beyond that, the series has been lightly tested on a Witherspoon system and
nothing was obviously broken.
Please review!
Cheers,
Andrew
Andrew Jeffery (12):
dts: fsi: Make OCC description match expected hierarchy
hwmon (p9_sbe): Initialise device spin lock
fsi: sbefifo: Rename sbefifo_release_client() for consistency
fsi: sbefifo: Add tracing of transfers
fsi: gpio: Trace busy count
fsi: occ: Add tracepoints
hwmon (p9_sbe): Rename context variable
hwmon (p9_sbe): Rename lock member of struct p9_sbe_occ
hwmon (p9_sbe): Convert client_lock from a spinlock to a mutex
hwmon (p9_sbe): Add static key to satisfy lockdep
fsi: sbefifo: Switch list_lock from spinlock to mutex
fsi: gpio: Remove unused 'id' variable
Eddie James (3):
fsi: sbefifo: don't delete canceled xfrs in write
fsi: sbefifo: Avoid using a timer to drive FIFO transfers
fsi: sbefifo: Switch to mutex in work function
Jeremy Kerr (1):
fsi: gpio: Use a mutex to protect transfers
arch/arm/boot/dts/ibm-power9-cfam.dtsi | 12 +++-
drivers/fsi/fsi-master-gpio.c | 94 +++++++++++++++++++-------
drivers/fsi/fsi-occ.c | 9 +++
drivers/fsi/fsi-sbefifo.c | 119 +++++++++++++++++++++++----------
drivers/hwmon/occ/p9_sbe.c | 54 ++++++++-------
include/trace/events/fsi_master_gpio.h | 16 +++++
include/trace/events/fsi_occ.h | 86 ++++++++++++++++++++++++
include/trace/events/sbefifo.h | 93 ++++++++++++++++++++++++++
8 files changed, 394 insertions(+), 89 deletions(-)
create mode 100644 include/trace/events/fsi_occ.h
create mode 100644 include/trace/events/sbefifo.h
--
2.14.1
next reply other threads:[~2018-02-20 4:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 4:18 Andrew Jeffery [this message]
2018-02-20 4:18 ` [PATCH linux dev-4.13 01/16] dts: fsi: Make OCC description match expected hierarchy Andrew Jeffery
2018-02-22 20:25 ` Eddie James
2018-02-23 0:15 ` Andrew Jeffery
2018-02-20 4:18 ` [PATCH linux dev-4.13 02/16] hwmon (p9_sbe): Initialise device spin lock Andrew Jeffery
2018-02-22 20:26 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 03/16] fsi: sbefifo: Rename sbefifo_release_client() for consistency Andrew Jeffery
2018-02-22 20:28 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 04/16] fsi: sbefifo: Add tracing of transfers Andrew Jeffery
2018-02-22 20:28 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 05/16] fsi: gpio: Trace busy count Andrew Jeffery
2018-02-22 20:29 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 06/16] fsi: occ: Add tracepoints Andrew Jeffery
2018-02-22 20:29 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 07/16] fsi: sbefifo: don't delete canceled xfrs in write Andrew Jeffery
2018-02-20 4:18 ` [PATCH linux dev-4.13 08/16] hwmon (p9_sbe): Rename context variable Andrew Jeffery
2018-02-22 20:30 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 09/16] hwmon (p9_sbe): Rename lock member of struct p9_sbe_occ Andrew Jeffery
2018-02-22 20:31 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 10/16] hwmon (p9_sbe): Convert client_lock from a spinlock to a mutex Andrew Jeffery
2018-02-22 20:31 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 11/16] hwmon (p9_sbe): Add static key to satisfy lockdep Andrew Jeffery
2018-02-22 20:32 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 12/16] fsi: sbefifo: Avoid using a timer to drive FIFO transfers Andrew Jeffery
2018-02-20 4:18 ` [PATCH linux dev-4.13 13/16] fsi: sbefifo: Switch to mutex in work function Andrew Jeffery
2018-02-20 4:18 ` [PATCH linux dev-4.13 14/16] fsi: sbefifo: Switch list_lock from spinlock to mutex Andrew Jeffery
2018-02-22 20:35 ` Eddie James
2018-02-20 4:18 ` [PATCH linux dev-4.13 15/16] fsi: gpio: Remove unused 'id' variable Andrew Jeffery
2018-02-20 4:18 ` [PATCH linux dev-4.13 16/16] fsi: gpio: Use a mutex to protect transfers Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220041844.13228-1-andrew@aj.id.au \
--to=andrew@aj.id.au \
--cc=bradleyb@fuzziesquirrel.com \
--cc=cbostic@linux.vnet.ibm.com \
--cc=eajames@linux.vnet.ibm.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.