All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: David Lechner <david@lechnology.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Monk Liu" <monk.liu@amd.com>,
	"Michel Dänzer" <michel.daenzer@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm: drm_memory: fix compiler warning on 32-bit targets
Date: Tue, 20 Feb 2018 11:49:17 +0100	[thread overview]
Message-ID: <20180220104917.GI23425@ulmo> (raw)
In-Reply-To: <1519081734-16572-1-git-send-email-david@lechnology.com>


[-- Attachment #1.1: Type: text/plain, Size: 425 bytes --]

On Mon, Feb 19, 2018 at 05:08:54PM -0600, David Lechner wrote:
> The end field of struct resource is resource_size_t, so on 32-bit
> targets, this is a 32-bit value.

That's not quite correct. resource_size_t is a phys_addr_t, which can be
64-bit also on 32-bit targets (if they've got CONFIG_PHYS_ADDR_T_64BIT
enabled, which is used for example with PAE).

With that fixed:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2018-02-20 10:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 23:08 [PATCH v2] drm: drm_memory: fix compiler warning on 32-bit targets David Lechner
2018-02-20 10:49 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180220104917.GI23425@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=david@lechnology.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=michel.daenzer@amd.com \
    --cc=monk.liu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.