All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 5/5] drm/doc: Use new substruct support
Date: Tue, 20 Feb 2018 14:25:33 +0100	[thread overview]
Message-ID: <20180220132533.GT22199@phenom.ffwll.local> (raw)
In-Reply-To: <20180220112218.GA9556@ulmo>

On Tue, Feb 20, 2018 at 12:22:18PM +0100, Thierry Reding wrote:
> On Tue, Feb 20, 2018 at 12:10:35PM +0100, Daniel Vetter wrote:
> > On Tue, Feb 20, 2018 at 10:49:52AM +0100, Thierry Reding wrote:
> > > On Mon, Feb 19, 2018 at 11:53:56PM +0100, Daniel Vetter wrote:
> > > > Note: This is untested because the new stuff hasn't landed in upstream
> > > > yet. But it should work.
> > 
> > Ok Jani put the patch into topic/core-for-CI temporarily, so I could test.
> > It works.
> > 
> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > ---
> > > >  include/drm/drm_vblank.h | 16 ++++++++++++++++
> > > >  1 file changed, 16 insertions(+)
> > > 
> > > I couldn't find a reference to the new stuff, so maybe this was already
> > > discussed, but wouldn't it be possible for the parser to figure out the
> > > substruct by itself? That way the event. prefix could be avoided.
> > 
> > https://lkml.org/lkml/2018/2/16/339
> > 
> > Jon said he pulled it all in already, I guess this way was simplest, the
> > actual fix is a one-liner:
> > 
> > https://lkml.org/lkml/2018/2/16/344
> > 
> > The reason for this is likely that you'll end up with name clashes
> > everywhere if you don't insist on the fully qualified name.
> 
> Thanks for the pointers. I would've thought that the parser could simply
> stick the prefix onto the name itself to make it fully qualified and
> thereby avoid any name clashes.
> 
> But looking at the patches and the parser a little, this will have to do
> for now:
> 
> Reviewed-by: Thierry Reding <treding@nvidia.com>

Thanks for your review, patch applied.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-02-20 13:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 22:53 [PATCH 1/5] drm/docs: Discourage adding more to kms-properties.csv Daniel Vetter
2018-02-19 22:53 ` [PATCH 2/5] drm/docs: Align layout of optional plane blending properties Daniel Vetter
2018-02-20  9:42   ` Thierry Reding
2018-02-19 22:53 ` [PATCH 3/5] drm/docs: Document "scaling mode" property better Daniel Vetter
2018-02-20  9:45   ` Thierry Reding
2018-02-19 22:53 ` [PATCH 4/5] drm/doc: Polish for drm_mode_parse_command_line_for_connector Daniel Vetter
2018-02-20  9:46   ` Thierry Reding
2018-02-19 22:53 ` [PATCH 5/5] drm/doc: Use new substruct support Daniel Vetter
2018-02-20  9:49   ` Thierry Reding
2018-02-20 11:10     ` Daniel Vetter
2018-02-20 11:22       ` Thierry Reding
2018-02-20 13:25         ` Daniel Vetter [this message]
2018-02-20 11:23     ` Jani Nikula
2018-02-20  9:41 ` [PATCH 1/5] drm/docs: Discourage adding more to kms-properties.csv Thierry Reding
2018-02-21  0:23 ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180220132533.GT22199@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.