From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 3/3] drm/i915: Collect aux ch vfunc setup into intel_dp_aux_init() Date: Tue, 20 Feb 2018 11:35:56 -0800 Message-ID: <20180220193556.GF27433@intel.com> References: <20180220170524.12303-1-ville.syrjala@linux.intel.com> <20180220170524.12303-3-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43A886E12F for ; Tue, 20 Feb 2018 19:35:58 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180220170524.12303-3-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBGZWIgMjAsIDIwMTggYXQgMDc6MDU6MjRQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IENvbGxlY3QgYWxsIHRoZSBhdXggY2ggdmZ1bmMgYXNzaWdubWVudHMgaW50byBp bnRlbF9kcF9hdXhfaW5pdCgpCj4gaW5zdGVhZCBvZiBoYXZpbmcgaXQgc3ByZWFkIGFyb3VuZC4K Ck1ha2VzIHNlbnNlIGFuZCBzZWVtcyBjbGVhbmVyIGFuZCByaWdodC4KCj4gCj4gU2lnbmVkLW9m Zi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClJl dmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+CgoKPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDUzICsrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25z KCspLCAyOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCBl YTQxNDc2NmY4MmIuLjAwNTczNWE3ZmMyOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ IEBAIC0xNTAwLDkgKzE1MDAsMjAgQEAgc3RhdGljIGk5MTVfcmVnX3Qgc2tsX2F1eF9kYXRhX3Jl ZyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBpbnQgaW5kZXgpCj4gIAl9Cj4gIH0KPiAgCj4g LXN0YXRpYyB2b2lkIGludGVsX2F1eF9yZWdfaW5pdChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw KQo+ICtzdGF0aWMgdm9pZAo+ICtpbnRlbF9kcF9hdXhfZmluaShzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwKQo+ICt7Cj4gKwlrZnJlZShpbnRlbF9kcC0+YXV4Lm5hbWUpOwo+ICt9Cj4gKwo+ICtz dGF0aWMgdm9pZAo+ICtpbnRlbF9kcF9hdXhfaW5pdChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGlu dGVsX2RwX3RvX2RldihpbnRlbF9kcCkpOwo+ICsJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29k ZXIgPSAmZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApLT5iYXNlOwo+ICsKPiArCWludGVsX2RwLT5h dXhfY2ggPSBpbnRlbF9hdXhfY2goaW50ZWxfZHApOwo+ICsJaW50ZWxfZHAtPmF1eF9wb3dlcl9k b21haW4gPSBpbnRlbF9hdXhfcG93ZXJfZG9tYWluKGludGVsX2RwKTsKPiAgCj4gIAlpZiAoSU5U RUxfR0VOKGRldl9wcml2KSA+PSA5KSB7Cj4gIAkJaW50ZWxfZHAtPmF1eF9jaF9jdGxfcmVnID0g c2tsX2F1eF9jdGxfcmVnOwo+IEBAIC0xNTE0LDIzICsxNTI1LDIxIEBAIHN0YXRpYyB2b2lkIGlu dGVsX2F1eF9yZWdfaW5pdChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJCWludGVsX2Rw LT5hdXhfY2hfY3RsX3JlZyA9IGc0eF9hdXhfY3RsX3JlZzsKPiAgCQlpbnRlbF9kcC0+YXV4X2No X2RhdGFfcmVnID0gZzR4X2F1eF9kYXRhX3JlZzsKPiAgCX0KPiAtfQo+ICAKPiAtc3RhdGljIHZv aWQKPiAtaW50ZWxfZHBfYXV4X2Zpbmkoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAtewo+ IC0Ja2ZyZWUoaW50ZWxfZHAtPmF1eC5uYW1lKTsKPiAtfQo+IC0KPiAtc3RhdGljIHZvaWQKPiAt aW50ZWxfZHBfYXV4X2luaXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAtewo+IC0Jc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIgPSAmZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApLT5i YXNlOwo+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkKPiArCQlpbnRlbF9kcC0+Z2V0 X2F1eF9jbG9ja19kaXZpZGVyID0gc2tsX2dldF9hdXhfY2xvY2tfZGl2aWRlcjsKPiArCWVsc2Ug aWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSVNfSEFTV0VMTChkZXZfcHJpdikpCj4gKwkJ aW50ZWxfZHAtPmdldF9hdXhfY2xvY2tfZGl2aWRlciA9IGhzd19nZXRfYXV4X2Nsb2NrX2Rpdmlk ZXI7Cj4gKwllbHNlIGlmIChIQVNfUENIX1NQTElUKGRldl9wcml2KSkKPiArCQlpbnRlbF9kcC0+ Z2V0X2F1eF9jbG9ja19kaXZpZGVyID0gaWxrX2dldF9hdXhfY2xvY2tfZGl2aWRlcjsKPiArCWVs c2UKPiArCQlpbnRlbF9kcC0+Z2V0X2F1eF9jbG9ja19kaXZpZGVyID0gZzR4X2dldF9hdXhfY2xv Y2tfZGl2aWRlcjsKPiAgCj4gLQlpbnRlbF9kcC0+YXV4X2NoID0gaW50ZWxfYXV4X2NoKGludGVs X2RwKTsKPiAtCWludGVsX2RwLT5hdXhfcG93ZXJfZG9tYWluID0gaW50ZWxfYXV4X3Bvd2VyX2Rv bWFpbihpbnRlbF9kcCk7Cj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ICsJCWlu dGVsX2RwLT5nZXRfYXV4X3NlbmRfY3RsID0gc2tsX2dldF9hdXhfc2VuZF9jdGw7Cj4gKwllbHNl Cj4gKwkJaW50ZWxfZHAtPmdldF9hdXhfc2VuZF9jdGwgPSBnNHhfZ2V0X2F1eF9zZW5kX2N0bDsK PiAgCj4gLQlpbnRlbF9hdXhfcmVnX2luaXQoaW50ZWxfZHApOwo+ICAJZHJtX2RwX2F1eF9pbml0 KCZpbnRlbF9kcC0+YXV4KTsKPiAgCj4gIAkvKiBGYWlsdXJlIHRvIGFsbG9jYXRlIG91ciBwcmVm ZXJyZWQgbmFtZSBpcyBub3QgY3JpdGljYWwgKi8KPiBAQCAtNjMzOCwyMCArNjM0Nyw2IEBAIGlu dGVsX2RwX2luaXRfY29ubmVjdG9yKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2Rp Z19wb3J0LAo+ICAJaW50ZWxfZHAtPmFjdGl2ZV9waXBlID0gSU5WQUxJRF9QSVBFOwo+ICAKPiAg CS8qIGludGVsX2RwIHZmdW5jcyAqLwo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkK PiAtCQlpbnRlbF9kcC0+Z2V0X2F1eF9jbG9ja19kaXZpZGVyID0gc2tsX2dldF9hdXhfY2xvY2tf ZGl2aWRlcjsKPiAtCWVsc2UgaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8IElTX0JST0FEV0VM TChkZXZfcHJpdikpCj4gLQkJaW50ZWxfZHAtPmdldF9hdXhfY2xvY2tfZGl2aWRlciA9IGhzd19n ZXRfYXV4X2Nsb2NrX2RpdmlkZXI7Cj4gLQllbHNlIGlmIChIQVNfUENIX1NQTElUKGRldl9wcml2 KSkKPiAtCQlpbnRlbF9kcC0+Z2V0X2F1eF9jbG9ja19kaXZpZGVyID0gaWxrX2dldF9hdXhfY2xv Y2tfZGl2aWRlcjsKPiAtCWVsc2UKPiAtCQlpbnRlbF9kcC0+Z2V0X2F1eF9jbG9ja19kaXZpZGVy ID0gZzR4X2dldF9hdXhfY2xvY2tfZGl2aWRlcjsKPiAtCj4gLQlpZiAoSU5URUxfR0VOKGRldl9w cml2KSA+PSA5KQo+IC0JCWludGVsX2RwLT5nZXRfYXV4X3NlbmRfY3RsID0gc2tsX2dldF9hdXhf c2VuZF9jdGw7Cj4gLQllbHNlCj4gLQkJaW50ZWxfZHAtPmdldF9hdXhfc2VuZF9jdGwgPSBnNHhf Z2V0X2F1eF9zZW5kX2N0bDsKPiAtCj4gIAlpZiAoSEFTX0RESShkZXZfcHJpdikpCj4gIAkJaW50 ZWxfZHAtPnByZXBhcmVfbGlua19yZXRyYWluID0gaW50ZWxfZGRpX3ByZXBhcmVfbGlua19yZXRy YWluOwo+ICAKPiAtLSAKPiAyLjEzLjYKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==