From: Peter Backes <rtc@helen.PLASMA.Xg8.DE>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: Git should preserve modification times at least on request
Date: Tue, 20 Feb 2018 22:05:54 +0100 [thread overview]
Message-ID: <20180220210554.GA24474@helen.PLASMA.Xg8.DE> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1802201127140.31@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
Hi Johannes,
On Tue, Feb 20, 2018 at 11:46:38AM +0100, Johannes Schindelin wrote:
> If I were you [...]
It seems all pretty straight forward, except for
> I would probably invent a file format (`<mtime><TAB><path><LF>`)
I'm stuck there because of <path> being munged.
To obtain or set the mtime of the file, I need the unmunged path.
How to get it?
----
What follows is irrelevant for progress.
> I don't think that code was ever there. Maybe you heard about some file
> mode being preserved overzealously (we stored the octal file mode
> verbatim, but then decided to store only 644 or 755).
I'm not sure. I'm not able to find that source anymore, though.
> As you can see from the code decoding a tree entry:
>
> https://github.com/git-for-windows/git/blob/e1848984d/tree-walk.c#L25-L52
>
> there is no mtime at all in the on-disk format of tree objects. There is
> the hash, the mode, and the file name.
I didn't comletely get the code in tree-walk.c since the parsing
architecture seems to pass around pointers via global variables.
It seems that in addition to hash, mode and file name, the on-disk
format has at least the object type, see git cat-file -p master^{tree}
Perhaps I got it wrong.
Best wishes
Peter
--
Peter Backes, rtc@helen.PLASMA.Xg8.DE
next prev parent reply other threads:[~2018-02-20 21:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 21:22 Git should preserve modification times at least on request Peter Backes
2018-02-19 21:58 ` Johannes Schindelin
2018-02-19 22:08 ` Peter Backes
2018-02-20 1:22 ` Theodore Ts'o
2018-02-20 10:46 ` Johannes Schindelin
2018-02-20 11:53 ` Peter Backes
2018-02-20 21:05 ` Peter Backes [this message]
2018-02-20 22:32 ` Johannes Schindelin
2018-02-20 22:48 ` Peter Backes
2018-02-21 21:30 ` Phillip Wood
2018-02-19 22:37 ` Randall S. Becker
2018-02-19 23:22 ` Hilco Wijbenga
2018-02-20 16:42 ` Hilco Wijbenga
2018-02-20 21:16 ` Jeff King
2018-02-20 22:05 ` Peter Backes
2018-02-21 9:48 ` Jacob Keller
2018-02-20 23:40 ` Junio C Hamano
2018-02-21 21:03 ` Derek Fawcus
2018-02-21 21:33 ` Ævar Arnfjörð Bjarmason
2018-02-21 22:14 ` Peter Backes
2018-02-21 22:44 ` Ævar Arnfjörð Bjarmason
2018-02-21 23:12 ` Peter Backes
2018-02-21 23:58 ` Randall S. Becker
2018-02-22 2:05 ` 'Peter Backes'
2018-02-26 10:56 ` Andreas Krey
2018-02-26 11:04 ` 'Peter Backes'
2018-02-22 23:24 ` Derek Fawcus
2018-02-23 12:28 ` Konstantin Khomoutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220210554.GA24474@helen.PLASMA.Xg8.DE \
--to=rtc@helen.plasma.xg8.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.