From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Fsync parent directories
Date: Wed, 21 Feb 2018 08:11:38 -0800 [thread overview]
Message-ID: <20180221161138.GA2779@infradead.org> (raw)
In-Reply-To: <20180220215115.GA1807@rh>
On Wed, Feb 21, 2018 at 08:51:15AM +1100, Dave Chinner wrote:
> IOWs, if the filesystem is designed with strictly ordered metadata,
> then fsync()ing a new file also implies that all references to the
> new file are also on stable storage because they happened before the
> fsync on the file was issued. i.e. the directory is fsync'd
> implicitly because it was modified by the same operation that
> created the file. Hence if the file creation is made stable, so must
> be the directory modification done during file creation.
>
> This has nothing to do with POSIX or what the "linux standard" is -
> this is testing whether the implementation of strictly ordered
> metadata journalling is correct or not. If gfs2 does not have
> strictly ordered metadata journalling, then it probably shouldn't
> run these tests....
Exactly. Also this is not just for new entries but also things like
rename. So trying to come up with some adjocs hacks here seems
wrong.
That being said as far as I know gfs2 does transactional metadata
updates and has one single global log. Why doesn't it get these
things right by default?
next prev parent reply other threads:[~2018-02-21 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 23:22 [Cluster-devel] [PATCH] gfs2: Fsync parent directories Andreas Gruenbacher
2018-02-20 15:32 ` Bob Peterson
2018-02-20 19:46 ` Christoph Hellwig
2018-02-20 20:53 ` Andreas Gruenbacher
2018-02-20 21:51 ` Dave Chinner
2018-02-21 16:11 ` Christoph Hellwig [this message]
2018-02-26 17:17 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221161138.GA2779@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.