All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 8/9] keymap: record multiple keysym -> keycode mappings
Date: Thu, 22 Feb 2018 11:23:16 +0100	[thread overview]
Message-ID: <20180222102317.25776-9-kraxel@redhat.com> (raw)
In-Reply-To: <20180222102317.25776-1-kraxel@redhat.com>

Sometimes the same keysym can be created using different key
combinations.  Record them all in the reverse keymap, not only
the first one.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20180222070513.8740-5-kraxel@redhat.com
---
 ui/keymaps.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/ui/keymaps.c b/ui/keymaps.c
index cbdd65c767..1eba6d7057 100644
--- a/ui/keymaps.c
+++ b/ui/keymaps.c
@@ -29,7 +29,8 @@
 #include "qemu/error-report.h"
 
 struct keysym2code {
-    uint16_t keycode;
+    uint32_t count;
+    uint16_t keycodes[4];
 };
 
 struct kbd_layout_t {
@@ -62,11 +63,18 @@ static void add_keysym(char *line, int keysym, int keycode, kbd_layout_t *k)
 
     keysym2code = g_hash_table_lookup(k->hash, GINT_TO_POINTER(keysym));
     if (keysym2code) {
+        if (keysym2code->count < ARRAY_SIZE(keysym2code->keycodes)) {
+            keysym2code->keycodes[keysym2code->count++] = keycode;
+        } else {
+            warn_report("more than %zd keycodes for keysym %d",
+                        ARRAY_SIZE(keysym2code->keycodes), keysym);
+        }
         return;
     }
 
     keysym2code = g_new0(struct keysym2code, 1);
-    keysym2code->keycode = keycode;
+    keysym2code->keycodes[0] = keycode;
+    keysym2code->count = 1;
     g_hash_table_replace(k->hash, GINT_TO_POINTER(keysym), keysym2code);
     trace_keymap_add(keysym, keycode, line);
 }
@@ -185,7 +193,7 @@ int keysym2scancode(kbd_layout_t *k, int keysym)
         return 0;
     }
 
-    return keysym2code->keycode;
+    return keysym2code->keycodes[0];
 }
 
 int keycode_is_keypad(kbd_layout_t *k, int keycode)
-- 
2.9.3

  parent reply	other threads:[~2018-02-22 10:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 10:23 [Qemu-devel] [PULL 0/9] Ui 20180222 patches Gerd Hoffmann
2018-02-22 10:23 ` [Qemu-devel] [PULL 1/9] sdl2: fix hotkey keyup Gerd Hoffmann
2018-02-22 10:23 ` [Qemu-devel] [PULL 2/9] console/opengl: split up dpy_gl_cursor ops Gerd Hoffmann
2018-02-22 10:23 ` [Qemu-devel] [PULL 3/9] egl-headless: cursor_dmabuf: handle NULL cursor Gerd Hoffmann
2018-02-22 10:23 ` [Qemu-devel] [PULL 4/9] egl-helpers: add alpha channel to texture format Gerd Hoffmann
2018-02-22 10:23 ` [Qemu-devel] [PULL 5/9] keymap: make struct kbd_layout_t private to ui/keymaps.c Gerd Hoffmann
2018-02-22 10:23 ` [Qemu-devel] [PULL 6/9] keymap: use glib hash for kbd_layout_t Gerd Hoffmann
2018-02-22 10:23 ` [Qemu-devel] [PULL 7/9] keymap: numpad keysyms and keycodes are fixed Gerd Hoffmann
2018-02-22 10:23 ` Gerd Hoffmann [this message]
2018-02-22 10:23 ` [Qemu-devel] [PULL 9/9] keymap: consider modifier state when picking a mapping Gerd Hoffmann
2018-02-22 15:41 ` [Qemu-devel] [PULL 0/9] Ui 20180222 patches Peter Maydell
2018-02-24 14:10 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222102317.25776-9-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.