From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH v4 33/40] KVM: arm64: Configure c15, PMU, and debug register traps on cpu load/put for VHE Date: Thu, 22 Feb 2018 16:51:02 +0100 Message-ID: <20180222155102.6t4ptrtt7yvewn47@kamzik.brq.redhat.com> References: <20180215210332.8648-1-christoffer.dall@linaro.org> <20180215210332.8648-34-christoffer.dall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marc Zyngier , kvmarm@lists.cs.columbia.edu, Yury Norov , linux-arm-kernel@lists.infradead.org, Dave Martin , Shih-Wei Li To: Christoffer Dall Return-path: Content-Disposition: inline In-Reply-To: <20180215210332.8648-34-christoffer.dall@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On Thu, Feb 15, 2018 at 10:03:25PM +0100, Christoffer Dall wrote: > We do not have to change the c15 trap setting on each switch to/from the > guest on VHE systems, because this setting only affects EL0. > > The PMU and debug trap configuration can also be done on vcpu load/put > instead, because they don't affect how the host kernel can access the > debug registers while executing KVM kernel code. > > Signed-off-by: Christoffer Dall > --- > arch/arm64/include/asm/kvm_hyp.h | 3 +++ > arch/arm64/kvm/hyp/switch.c | 31 ++++++++++++++++++++++--------- > arch/arm64/kvm/hyp/sysreg-sr.c | 4 ++++ > 3 files changed, 29 insertions(+), 9 deletions(-) > The last patch 32/40 probably should have been closer to 13/40 in this series. That would allow this patch to directly follow it's preparatory patch 31/40, but I'm just whiny reviewer... Reviewed-by: Andrew Jones From mboxrd@z Thu Jan 1 00:00:00 1970 From: drjones@redhat.com (Andrew Jones) Date: Thu, 22 Feb 2018 16:51:02 +0100 Subject: [PATCH v4 33/40] KVM: arm64: Configure c15, PMU, and debug register traps on cpu load/put for VHE In-Reply-To: <20180215210332.8648-34-christoffer.dall@linaro.org> References: <20180215210332.8648-1-christoffer.dall@linaro.org> <20180215210332.8648-34-christoffer.dall@linaro.org> Message-ID: <20180222155102.6t4ptrtt7yvewn47@kamzik.brq.redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Feb 15, 2018 at 10:03:25PM +0100, Christoffer Dall wrote: > We do not have to change the c15 trap setting on each switch to/from the > guest on VHE systems, because this setting only affects EL0. > > The PMU and debug trap configuration can also be done on vcpu load/put > instead, because they don't affect how the host kernel can access the > debug registers while executing KVM kernel code. > > Signed-off-by: Christoffer Dall > --- > arch/arm64/include/asm/kvm_hyp.h | 3 +++ > arch/arm64/kvm/hyp/switch.c | 31 ++++++++++++++++++++++--------- > arch/arm64/kvm/hyp/sysreg-sr.c | 4 ++++ > 3 files changed, 29 insertions(+), 9 deletions(-) > The last patch 32/40 probably should have been closer to 13/40 in this series. That would allow this patch to directly follow it's preparatory patch 31/40, but I'm just whiny reviewer... Reviewed-by: Andrew Jones