From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [DPU PATCH] drm/msm: Remove dpu_plane_state->defer_prepare_fb Date: Thu, 22 Feb 2018 16:00:25 -0500 Message-ID: <20180222210025.GG223881@art_vandelay> References: <20180221194342.120351-1-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Rob Clark Cc: freedreno , "Kristian H. Kristensen" , Sean Paul , Jeykumar Sankaran , linux-arm-msm List-Id: linux-arm-msm@vger.kernel.org T24gVGh1LCBGZWIgMjIsIDIwMTggYXQgMDM6MDI6NDRQTSAtMDUwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uIFdlZCwgRmViIDIxLCAyMDE4IGF0IDI6NDMgUE0sIFNlYW4gUGF1bCA8c2VhbnBhdWxA Y2hyb21pdW0ub3JnPiB3cm90ZToKPiA+IEl0J3MgbmV2ZXIgc2V0IHRvIHRydWUsIHNvIG5vbmUg b2YgdGhpcyBjb2RlIGlzIGV2ZXIgcnVuLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1 bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IEkgZ3Vlc3MgaWYgaXQgd2FzIGV2ZXIgc2V0 IHRvIHRydWUsIHRoYXQgZ290IHJpcHBlZCBvdXQgd2l0aCB0aGUKPiBzZWN1cmUgYnVmZmVyIHN1 cHBvcnQuICBBbmQgd2hlbiB0aGF0IGV2ZXIgZ2V0cyByZS1pbnRyb2R1Y2VkLCBJIGhvcGUKPiB3 ZSBjYW4gYXZvaWQgdGhlIG5lZWQgZm9yIHRyYW5zaXRpb25zLCBzaW5jZSBpdCBkb2VzIHNlZW0g dG8gaW50cm9kdWNlCj4gYSBsb3QgbW9yZSBjb21wbGV4aXR5LgoKWWVhaCwgSSB0aGluayB3ZSdk IHdhbnQgdG8gcmUtZXZhbHVhdGUgYW55d2F5cyBzaW5jZSBpdCBzZWVtZWQgbGlrZSBhIGxvdCBv Zgpjb3B5cGFzdGEgc3ByaW5rbGVkIGFyb3VuZC4gQXQgdGhlIF92ZXJ5IGxlYXN0XyB3ZSdkIHdh bnQgdG8gYWRkIGEgaGVscGVyIHRvCmhhbmRsZSB0aGUgcHJlcGFyZSBhbmQgc3RhdGUgdHJhY2tp bmcuCgo+IAo+IFJldmlld2VkLWJ5OiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5jb20+CgpU aGFua3MhCgpTZWFuCgo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw dTEvZHB1X3BsYW5lLmMgfCA2NSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIGRyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5oIHwgIDIgLQo+ID4gIDIgZmlsZXMgY2hh bmdlZCwgNjcgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw dTEvZHB1X3BsYW5lLmMKPiA+IGluZGV4IDliNjg0ZTk0ZThhYS4uY2JkYTdkYmY4NzI1IDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X3BsYW5lLmMKPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jCj4gPiBAQCAt ODk0LDIyICs4OTQsNiBAQCBzdGF0aWMgaW5saW5lIHZvaWQgX2RwdV9wbGFuZV9zZXRfc2Nhbm91 dChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAgICAgICAgICAgICAgICByZXR1cm47Cj4g PiAgICAgICAgIH0KPiA+Cj4gPiAtICAgICAgIC8qCj4gPiAtICAgICAgICAqIGZyYW1lYnVmZmVy IHByZXBhcmUgaXMgZGVmZXJyZWQgZm9yIHByZXBhcmVfZmIgY2FsbHMgdGhhdAo+ID4gLSAgICAg ICAgKiBoYXBwZW4gZHVyaW5nIHRoZSB0cmFuc2l0aW9uIGZyb20gc2VjdXJlIHRvIG5vbi1zZWN1 cmUuCj4gPiAtICAgICAgICAqIEhhbmRsZSB0aGUgcHJlcGFyZSBhdCB0aGlzIHBvaW50IGZvciBz dWNoIGNhc2VzLiBUaGlzIGNhbiBiZQo+ID4gLSAgICAgICAgKiBleHBlY3RlZCBmb3Igb25lIG9y IHR3byBmcmFtZXMgZHVyaW5nIHRoZSB0cmFuc2l0aW9uLgo+ID4gLSAgICAgICAgKi8KPiA+IC0g ICAgICAgaWYgKGFzcGFjZSAmJiBwc3RhdGUtPmRlZmVyX3ByZXBhcmVfZmIpIHsKPiA+IC0gICAg ICAgICAgICAgICByZXQgPSBtc21fZnJhbWVidWZmZXJfcHJlcGFyZShmYiwgcHN0YXRlLT5hc3Bh Y2UpOwo+ID4gLSAgICAgICAgICAgICAgIGlmIChyZXQpIHsKPiA+IC0gICAgICAgICAgICAgICAg ICAgICAgIERQVV9FUlJPUl9QTEFORShwZHB1LAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiZmFpbGVkIHRvIHByZXBhcmUgZnJhbWVidWZmZXIgJWRcbiIsIHJldCk7Cj4gPiAt ICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47Cj4gPiAtICAgICAgICAgICAgICAgfQo+ID4g LSAgICAgICAgICAgICAgIHBzdGF0ZS0+ZGVmZXJfcHJlcGFyZV9mYiA9IGZhbHNlOwo+ID4gLSAg ICAgICB9Cj4gPiAtCj4gPiAgICAgICAgIHJldCA9IGRwdV9mb3JtYXRfcG9wdWxhdGVfbGF5b3V0 KGFzcGFjZSwgZmIsICZwaXBlX2NmZy0+bGF5b3V0KTsKPiA+ICAgICAgICAgaWYgKHJldCA9PSAt RUFHQUlOKQo+ID4gICAgICAgICAgICAgICAgIERQVV9ERUJVR19QTEFORShwZHB1LCAibm90IHVw ZGF0aW5nIHNhbWUgc3JjIGFkZHJzXG4iKTsKPiA+IEBAIC0yMTAzLDEzICsyMDg3LDYgQEAgc3Rh dGljIGludCBkcHVfcGxhbmVfcm90X3ByZXBhcmVfZmIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUs Cj4gPiAgICAgICAgICAgICAgICAgfQo+ID4gICAgICAgICB9Cj4gPgo+ID4gLSAgICAgICBpZiAo bmV3X3BzdGF0ZS0+ZGVmZXJfcHJlcGFyZV9mYikgewo+ID4gLSAgICAgICAgICAgICAgIERQVV9E RUJVRygKPiA+IC0gICAgICAgICAgICAgICAgICAgInBsYW5lJWQsIGRvbWFpbiBub3QgYXR0YWNo ZWQsIHByZXBhcmUgZmIgaGFuZGxlZCBsYXRlclxuIiwKPiA+IC0gICAgICAgICAgICAgICAgICAg cGxhbmUtPmJhc2UuaWQpOwo+ID4gLSAgICAgICAgICAgICAgIHJldHVybiAwOwo+ID4gLSAgICAg ICB9Cj4gPiAtCj4gPiAgICAgICAgIC8qIHByZXBhcmUgcm90YXRvciBpbnB1dCBidWZmZXIgKi8K PiA+ICAgICAgICAgcmV0ID0gbXNtX2ZyYW1lYnVmZmVyX3ByZXBhcmUobmV3X3N0YXRlLT5mYiwg bmV3X3BzdGF0ZS0+YXNwYWNlKTsKPiA+ICAgICAgICAgaWYgKHJldCkgewo+ID4gQEAgLTI0MDEs MzQgKzIzNzgsNiBAQCBzdGF0aWMgdm9pZCBkcHVfcGxhbmVfcm90X2F0b21pY191cGRhdGUoc3Ry dWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPiAgICAgICAgIGlmICghcnN0YXRlLT5vdXRfc2J1ZiB8 fCAhcnN0YXRlLT5yb3RfaHcpCj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4KPiA+IC0g ICAgICAgLyoKPiA+IC0gICAgICAgICogZnJhbWVidWZmZXIgcHJlcGFyZSBpcyBkZWZlcnJlZCBm b3IgcHJlcGFyZV9mYiBjYWxscyB0aGF0Cj4gPiAtICAgICAgICAqIGhhcHBlbiBkdXJpbmcgdGhl IHRyYW5zaXRpb24gZnJvbSBzZWN1cmUgdG8gbm9uLXNlY3VyZS4KPiA+IC0gICAgICAgICogSGFu ZGxlIHRoZSBwcmVwYXJlIGF0IHRoaXMgcG9pbnQgZm9yIHJvdGF0b3IgaW4gc3VjaCBjYXNlcy4K PiA+IC0gICAgICAgICogVGhpcyBjYW4gYmUgZXhwZWN0ZWQgZm9yIG9uZSBvciB0d28gZnJhbWVz IGR1cmluZyB0aGUgdHJhbnNpdGlvbi4KPiA+IC0gICAgICAgICovCj4gPiAtICAgICAgIGlmIChw c3RhdGUtPmFzcGFjZSAmJiBwc3RhdGUtPmRlZmVyX3ByZXBhcmVfZmIpIHsKPiA+IC0gICAgICAg ICAgICAgICAvKiBwcmVwYXJlIHJvdGF0b3IgaW5wdXQgYnVmZmVyICovCj4gPiAtICAgICAgICAg ICAgICAgcmV0ID0gbXNtX2ZyYW1lYnVmZmVyX3ByZXBhcmUoc3RhdGUtPmZiLCBwc3RhdGUtPmFz cGFjZSk7Cj4gPiAtICAgICAgICAgICAgICAgaWYgKHJldCkgewo+ID4gLSAgICAgICAgICAgICAg ICAgICAgICAgRFBVX0VSUk9SKCJwJWQgZmFpbGVkIHRvIHByZXBhcmUgaW5wdXQgZmIgJWRcbiIs Cj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHBsYW5lLT5iYXNlLmlkLCByZXQpOwo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuOwo+ID4gLSAgICAgICAgICAgICAgIH0KPiA+IC0KPiA+IC0gICAgICAgICAgICAgICAvKiBw cmVwYXJlIHJvdGF0b3Igb3V0cHV0IGJ1ZmZlciAqLwo+ID4gLSAgICAgICAgICAgICAgIGlmIChk cHVfcGxhbmVfZW5hYmxlZChzdGF0ZSkgJiYgcnN0YXRlLT5vdXRfZmIpIHsKPiA+IC0gICAgICAg ICAgICAgICAgICAgICAgIHJldCA9IG1zbV9mcmFtZWJ1ZmZlcl9wcmVwYXJlKHJzdGF0ZS0+b3V0 X2ZiLAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cHN0YXRlLT5hc3BhY2UpOwo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgaWYgKHJldCkgewo+ ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEUFVfRVJST1IoCj4gPiAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgInAlZCBmYWlsZWQgdG8gcHJlcGFyZSBpbmxpbmUg ZmIgJWRcbiIsCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGxhbmUtPmJh c2UuaWQsIHJldCk7Cj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8gZXJy b3JfcHJlcGFyZV9vdXRwdXRfYnVmZmVyOwo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgfQo+ ID4gLSAgICAgICAgICAgICAgIH0KPiA+IC0gICAgICAgfQo+ID4gLQo+ID4gICAgICAgICBkcHVf cGxhbmVfcm90X3N1Ym1pdF9jb21tYW5kKHBsYW5lLCBzdGF0ZSwgRFBVX0hXX1JPVF9DTURfQ09N TUlUKTsKPiA+Cj4gPiAgICAgICAgIHJldHVybjsKPiA+IEBAIC0yNzk2LDI2ICsyNzQ1LDEyIEBA IHN0YXRpYyBpbnQgZHB1X3BsYW5lX3ByZXBhcmVfZmIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUs Cj4gPiAgICAgICAgIC8qIGNhY2hlIGFzcGFjZSAqLwo+ID4gICAgICAgICBwc3RhdGUtPmFzcGFj ZSA9IGFzcGFjZTsKPiA+Cj4gPiAtICAgICAgIC8qCj4gPiAtICAgICAgICAqIHdoZW4gdHJhbnNp dGlvbmluZyBmcm9tIHNlY3VyZSB0byBub24tc2VjdXJlLAo+ID4gLSAgICAgICAgKiBwbGFuZS0+ cHJlcGFyZV9mYiBoYXBwZW5zIGJlZm9yZSB0aGUgY29tbWl0LiBJbiBzdWNoIGNhc2UsCj4gPiAt ICAgICAgICAqIGRlZmVyIHRoZSBwcmVwYXJlX2ZiIGFuZCBoYW5kbGVkIGl0IGxhdGUsIGR1cmlu ZyB0aGUgY29tbWl0Cj4gPiAtICAgICAgICAqIGFmdGVyIGF0dGFjaGluZyB0aGUgZG9tYWlucyBh cyBwYXJ0IG9mIHRoZSB0cmFuc2l0aW9uCj4gPiAtICAgICAgICAqLwo+ID4gLSAgICAgICBwc3Rh dGUtPmRlZmVyX3ByZXBhcmVfZmIgPSBmYWxzZTsKPiA+IC0KPiA+ICAgICAgICAgcmV0ID0gZHB1 X3BsYW5lX3JvdF9wcmVwYXJlX2ZiKHBsYW5lLCBuZXdfc3RhdGUpOwo+ID4gICAgICAgICBpZiAo cmV0KSB7Cj4gPiAgICAgICAgICAgICAgICAgRFBVX0VSUk9SKCJmYWlsZWQgdG8gcHJlcGFyZSBy b3QgZnJhbWVidWZmZXJcbiIpOwo+ID4gICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiAg ICAgICAgIH0KPiA+Cj4gPiAtICAgICAgIGlmIChwc3RhdGUtPmRlZmVyX3ByZXBhcmVfZmIpIHsK PiA+IC0gICAgICAgICAgICAgICBEUFVfREVCVUdfUExBTkUocGRwdSwKPiA+IC0gICAgICAgICAg ICAgICAgICAgImRvbWFpbiBub3QgYXR0YWNoZWQsIHByZXBhcmVfZmIgaGFuZGxlZCBsYXRlclxu Iik7Cj4gPiAtICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4gPiAtICAgICAgIH0KPiA+IC0KPiA+ ICAgICAgICAgbmV3X3JzdGF0ZSA9ICZ0b19kcHVfcGxhbmVfc3RhdGUobmV3X3N0YXRlKS0+cm90 Owo+ID4KPiA+ICAgICAgICAgaWYgKHBzdGF0ZS0+YXNwYWNlKSB7Cj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X3BsYW5lLmggYi9kcml2ZXJzL2dwdS9k cm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuaAo+ID4gaW5kZXggOGM0OTQxMmQ0NjBkLi43MTdk ZmUwNWM2ZWUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9k cHVfcGxhbmUuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X3Bs YW5lLmgKPiA+IEBAIC0xMjksNyArMTI5LDYgQEAgZW51bSBkcHVfcGxhbmVfc2NsY2hlY2tfc3Rh dGUgewo+ID4gICAqIEBtdWx0aXJlY3RfaW5kZXg6IGluZGV4IG9mIHRoZSByZWN0YW5nbGUgb2Yg U1NQUAo+ID4gICAqIEBtdWx0aXJlY3RfbW9kZTogcGFyYWxsZWwgb3IgdGltZSBtdWx0aXBsZXgg bXVsdGlyZWN0IG1vZGUKPiA+ICAgKiBAcGVuZGluZzogICB3aGV0aGVyIHRoZSBjdXJyZW50IHVw ZGF0ZSBpcyBzdGlsbCBwZW5kaW5nCj4gPiAtICogQGRlZmVyX3ByZXBhcmVfZmI6ICBpbmRpY2F0 ZSBpZiBwcmVwYXJlX2ZiIGNhbGwgd2FzIGRlZmVycmVkCj4gPiAgICogQHNjYWxlcjNfY2ZnOiBj b25maWd1cmF0aW9uIGRhdGEgZm9yIHNjYWxlcjMKPiA+ICAgKiBAcGl4ZWxfZXh0OiBjb25maWd1 cmF0aW9uIGRhdGEgZm9yIHBpeGVsIGV4dGVuc2lvbnMKPiA+ICAgKiBAc2NhbGVyX2NoZWNrX3N0 YXRlOiBpbmRpY2F0ZXMgc3RhdHVzIG9mIHVzZXIgcHJvdmlkZWQgcGl4ZWwgZXh0ZW5zaW9uIGRh dGEKPiA+IEBAIC0xNDcsNyArMTQ2LDYgQEAgc3RydWN0IGRwdV9wbGFuZV9zdGF0ZSB7Cj4gPiAg ICAgICAgIHVpbnQzMl90IG11bHRpcmVjdF9pbmRleDsKPiA+ICAgICAgICAgdWludDMyX3QgbXVs dGlyZWN0X21vZGU7Cj4gPiAgICAgICAgIGJvb2wgcGVuZGluZzsKPiA+IC0gICAgICAgYm9vbCBk ZWZlcl9wcmVwYXJlX2ZiOwo+ID4KPiA+ICAgICAgICAgLyogc2NhbGVyIGNvbmZpZ3VyYXRpb24g Ki8KPiA+ICAgICAgICAgc3RydWN0IGRwdV9od19zY2FsZXIzX2NmZyBzY2FsZXIzX2NmZzsKPiA+ IC0tCj4gPiAyLjE2LjEuMjkxLmc0NDM3ZjNmMTMyLWdvb2cKPiA+CgotLSAKU2VhbiBQYXVsLCBT b2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRyZW5vIG1haWxpbmcgbGlzdApGcmVl ZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5vCg==