From: Ben Crocker <bcrocker-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Ben Crocker <bcrocker-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE
Date: Thu, 22 Feb 2018 17:52:19 -0500 [thread overview]
Message-ID: <20180222225219.3223-1-bcrocker@redhat.com> (raw)
In-Reply-To: <20180222215101.3962-1-bcrocker-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
In radeon_device_init, set the need_dma32 flag for Cedar chips
(e.g. FirePro 2270). This fixes, or at least works around, a bug
on PowerPC exposed by last year's commits
8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey)
and
253fd51e2f533552ae35a0c661705da6c4842c1b (Alistair Popple)
which enabled the 64-bit DMA iommu bypass.
This caused the device to freeze, in some cases unrecoverably, and is
the subject of several bug reports internal to Red Hat.
Signed-off-by: Ben Crocker <bcrocker@redhat.com>
---
drivers/gpu/drm/radeon/radeon_device.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
index ffc10cadcf34..32b577c776b9 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -1397,6 +1397,10 @@ int radeon_device_init(struct radeon_device *rdev,
if ((rdev->flags & RADEON_IS_PCI) &&
(rdev->family <= CHIP_RS740))
rdev->need_dma32 = true;
+#ifdef CONFIG_PPC64
+ if (rdev->family == CHIP_CEDAR)
+ rdev->need_dma32 = true;
+#endif
dma_bits = rdev->need_dma32 ? 32 : 40;
r = pci_set_dma_mask(rdev->pdev, DMA_BIT_MASK(dma_bits));
--
2.13.6
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-02-22 22:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <to=<20180221234154.6877-1-bcrocker@redhat.com>
2018-02-22 21:51 ` [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE Ben Crocker
[not found] ` <20180222215101.3962-1-bcrocker-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-02-22 16:56 ` Alex Deucher
2018-02-22 22:52 ` Ben Crocker [this message]
2018-02-23 4:38 ` Alex Deucher
2018-02-21 23:41 [PATCH] drm/radeon: insist on 32-bit DMA for Cedar Ben Crocker
2018-02-22 21:57 ` [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE Ben Crocker
2018-02-22 17:04 ` Michel Dänzer
2018-02-22 17:37 ` Ben Crocker
[not found] ` <CALk+eRew=1nHZXRtXR430eFStOiQFUDgrp8VfsBAfcp8W9qAOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-22 17:56 ` Michel Dänzer
[not found] ` <CALk+eRc+EOry_G6Ovy0Z-pvE7jQWy5gSx+1kpHA4q3A0oEZs1w@mail.gmail.com>
[not found] ` <CALk+eRc+EOry_G6Ovy0Z-pvE7jQWy5gSx+1kpHA4q3A0oEZs1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-22 23:39 ` Ben Crocker
[not found] ` <CALk+eReghDHuv23-62pD0PbdBt6p+g_XeE+_c2gRdkoaOQh+CQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-23 1:39 ` Ben Crocker
[not found] ` <1bcf5b27-aa25-deb6-85e9-161dd038276b-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-02-23 7:45 ` Christian König
2018-02-23 16:02 ` Ben Crocker
2018-02-23 16:37 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222225219.3223-1-bcrocker@redhat.com \
--to=bcrocker-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.