From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] libxfs: don't return cnt as failure from XFS_BUF_SET_PTR
Date: Thu, 22 Feb 2018 15:02:30 -0800 [thread overview]
Message-ID: <20180222230230.GI9827@magnolia> (raw)
In-Reply-To: <9dee9e11-3480-8406-1d8e-8fc14220371b@redhat.com>
On Thu, Feb 22, 2018 at 04:41:17PM -0600, Eric Sandeen wrote:
> On 2/22/18 3:46 PM, Darrick J. Wong wrote:
> > On Thu, Feb 22, 2018 at 03:33:04PM -0600, Eric Sandeen wrote:
> >> We must not get here very often, because any test of an error
> >> from XFS_BUF_SET_PTR will fail because it returns whatever
> >> is sent in as cnt. Fix the macro to return 0 so that
> >> "error = XFS_BUF_SET_PTR()" works as expected.
> >>
> >> Should probably make this xfs_buf_associate_memory() to be
> >> more like kernelspace, but for now just fix up the bug.
> >>
> >> Found this via xfs_logprint failing for no good reason.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >> ---
> >>
> >> diff --git a/libxfs/libxfs_io.h b/libxfs/libxfs_io.h
> >> index 81d2804..0ae7a28 100644
> >> --- a/libxfs/libxfs_io.h
> >> +++ b/libxfs/libxfs_io.h
> >> @@ -105,6 +105,7 @@ enum xfs_buf_flags_t { /* b_flags bits */
> >> #define XFS_BUF_SET_PTR(bp,p,cnt) ({ \
> >> (bp)->b_addr = (char *)(p); \
> >> XFS_BUF_SET_COUNT(bp,cnt); \
> >> + 0; \
> >
> > There are only two callers of this macro and it's not exported to
> > xfslibs headers, so why not just fix them not to care about the return
> > value?
>
> because it marginally matches kernel code ... *shrug* I'd rather
> have libxlog diverge less from kernel, not more, overall.
Uhh... well in that case, I think you should rename XFS_BUF_SET_PTR
with xfs_buf_associate_memory (the helper function that
xlog_bread_offset uses in the kernel).
--D
>
> -Eric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-22 23:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 21:33 [PATCH] libxfs: don't return cnt as failure from XFS_BUF_SET_PTR Eric Sandeen
2018-02-22 21:46 ` Darrick J. Wong
2018-02-22 22:41 ` Eric Sandeen
2018-02-22 23:02 ` Darrick J. Wong [this message]
2018-02-22 23:10 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222230230.GI9827@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.