From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: disable WOL per default
Date: Fri, 23 Feb 2018 12:29:36 -0500 (EST) [thread overview]
Message-ID: <20180223.122936.1464670138063346448.davem@davemloft.net> (raw)
In-Reply-To: <5e11c46e-8e36-e850-052b-6fa9cb17c711@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 22 Feb 2018 21:22:40 +0100
> Currently, if BIOS enables WOL in the chip, settings are inconsistent
> because the device isn't marked as wakeup-enabled (if not done
> explicitly via userspace tools). This causes issues with suspend/
> resume because mdio_bus_phy_may_suspend() checks whether device is
> wakeup-enabled. In detail MDIO bus access in phy_suspend() can fail
> because the MDIO bus is disabled.
>
> In the history of the driver we find two competing approaches:
> 8f9d5138035d "r8169: remember WOL preferences on driver load" prefers
> to preserve what the BIOS may have set, whilst bde135a672bf
> "r8169: only enable PCI wakeups when WOL is active" disabled PCI
> wakeup per default to work around a bug on one platform.
>
> Seems like nobody complained after the latter patch about non-working
> WOL, what makes me think that nobody uses WOL w/o configuring it
> explicitly.
>
> My opinion:
> Vast majority of users doesn't use WOL even if the BIOS enables it in
> the chip. And having WOL being active keeps the PHY(s) from powering
> down if being idle.
> If somebody needs WOL, he can enable it during boot, e.g. by
> configuring systemd.link/WakeOnLan.
>
> Therefore, to make WOL consistent again, disable it per default.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
prev parent reply other threads:[~2018-02-23 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 20:22 [PATCH net-next] r8169: disable WOL per default Heiner Kallweit
2018-02-23 17:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223.122936.1464670138063346448.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.