All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Ulf Magnusson <ulfalizer@gmail.com>
Cc: helgaas@kernel.org, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org, tfiga@chromium.org,
	paul.burton@mips.com, m.szyprowski@samsung.com,
	egtvedt@samfundet.no, linus.walleij@linaro.org,
	vgupta@synopsys.com, mgorman@techsingularity.net, hch@lst.de,
	mina86@mina86.com, robh@kernel.org, sboyd@codeaurora.org,
	paulus@ozlabs.org, will.deacon@arm.com, tony@atomide.com,
	npiggin@gmail.com, yamada.masahiro@socionext.com,
	bhelgaas@google.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default
Date: Fri, 23 Feb 2018 11:52:50 +0000	[thread overview]
Message-ID: <20180223115242.GA21946@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20180206221106.16620-1-ulfalizer@gmail.com>

On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
> 
> Remove the default instead of changing it. bool and tristate symbols
> implicitly default to n.
> 
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.

I have remove this link - it can become stale so I do not think it is
worth adding it to the log.

I have also reworded the $SUBJECT.

Applied to pci/host/misc for v4.17, let me know if that's fine for you.

Thanks,
Lorenzo

> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> Changes in v2:
> Make it clear that Kconfig is involved.
> 
>  drivers/pci/host/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
>  config VMD
>  	depends on PCI_MSI && X86_64 && SRCU
>  	tristate "Intel Volume Management Device Driver"
> -	default N
>  	---help---
>  	  Adds support for the Intel Volume Management Device (VMD). VMD is a
>  	  secondary PCI host bridge that allows PCI Express root ports,
> -- 
> 2.14.1
> 

      parent reply	other threads:[~2018-02-23 11:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0180206191126.GB98765@bhelgaas-glaptop.roam.corp.google.com>
2018-02-06 22:11 ` [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default Ulf Magnusson
2018-02-22 23:00   ` Bjorn Helgaas
2018-02-22 23:42     ` Ulf Magnusson
2018-02-23  0:21       ` Bjorn Helgaas
2018-02-23 10:35         ` Lorenzo Pieralisi
2018-02-23 11:52   ` Lorenzo Pieralisi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180223115242.GA21946@e107981-ln.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=bhelgaas@google.com \
    --cc=egtvedt@samfundet.no \
    --cc=hch@lst.de \
    --cc=helgaas@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mgorman@techsingularity.net \
    --cc=mina86@mina86.com \
    --cc=npiggin@gmail.com \
    --cc=paul.burton@mips.com \
    --cc=paulus@ozlabs.org \
    --cc=robh@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=tfiga@chromium.org \
    --cc=tony@atomide.com \
    --cc=ulfalizer@gmail.com \
    --cc=vgupta@synopsys.com \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.