From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epFiS-00053q-Hl for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:56:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epFiR-0001Xl-Jb for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:56:56 -0500 Date: Fri, 23 Feb 2018 16:56:47 +0100 From: Kevin Wolf Message-ID: <20180223155647.GD3470@localhost.localdomain> References: <20180221135404.27598-1-kwolf@redhat.com> <20180221135404.27598-19-kwolf@redhat.com> <80aaebea-b192-333f-aa35-3cdf0e71aef3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80aaebea-b192-333f-aa35-3cdf0e71aef3@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 18/36] rbd: Fix use after free in qemu_rbd_set_keypairs() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-block@nongnu.org, mreitz@redhat.com, pkrempa@redhat.com, jcody@redhat.com, jdurgin@redhat.com, mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org Am 23.02.2018 um 16:15 hat Eric Blake geschrieben: > On 02/21/2018 07:53 AM, Kevin Wolf wrote: > > If we want to include the invalid option name in the error message, we > > can't free the string earlier than that. > > > > Signed-off-by: Kevin Wolf > > --- > > block/rbd.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > D'oh. Should this one be cc'd to qemu-stable? Yes, good point. Adding the CC to this reply, and also adding a Cc: line in the commit message. Kevin