From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbeBWQQZ (ORCPT ); Fri, 23 Feb 2018 11:16:25 -0500 Received: from smtp.eu.citrix.com ([185.25.65.24]:20504 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381AbeBWQQY (ORCPT ); Fri, 23 Feb 2018 11:16:24 -0500 X-IronPort-AV: E=Sophos;i="5.47,383,1515456000"; d="scan'208";a="68476018" Date: Fri, 23 Feb 2018 16:15:00 +0000 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: Dongwon Kim CC: , , , , , Subject: Re: [Xen-devel] [RFC PATCH v2 2/9] hyper_dmabuf: architecture specification and reference guide Message-ID: <20180223161500.xpbqnpsxihoxi5o4@MacBook-Pro-de-Roger.local> References: <20180214015008.9513-1-dongwon.kim@intel.com> <20180214015008.9513-3-dongwon.kim@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180214015008.9513-3-dongwon.kim@intel.com> User-Agent: NeoMutt/20171215 X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 13, 2018 at 05:50:01PM -0800, Dongwon Kim wrote: > Reference document for hyper_DMABUF driver > > Documentation/hyper-dmabuf-sharing.txt This should likely be patch 1 in order for reviewers to have the appropriate context. > > Signed-off-by: Dongwon Kim > --- > Documentation/hyper-dmabuf-sharing.txt | 734 +++++++++++++++++++++++++++++++++ > 1 file changed, 734 insertions(+) > create mode 100644 Documentation/hyper-dmabuf-sharing.txt > > diff --git a/Documentation/hyper-dmabuf-sharing.txt b/Documentation/hyper-dmabuf-sharing.txt > new file mode 100644 > index 000000000000..928e411931e3 > --- /dev/null > +++ b/Documentation/hyper-dmabuf-sharing.txt > @@ -0,0 +1,734 @@ > +Linux Hyper DMABUF Driver > + > +------------------------------------------------------------------------------ > +Section 1. Overview > +------------------------------------------------------------------------------ > + > +Hyper_DMABUF driver is a Linux device driver running on multiple Virtual > +achines (VMs), which expands DMA-BUF sharing capability to the VM environment > +where multiple different OS instances need to share same physical data without > +data-copy across VMs. > + > +To share a DMA_BUF across VMs, an instance of the Hyper_DMABUF drv on the > +exporting VM (so called, “exporter”) imports a local DMA_BUF from the original > +producer of the buffer, The usage of export and import in the above sentence makes it almost impossible to understand. > then re-exports it with an unique ID, hyper_dmabuf_id > +for the buffer to the importing VM (so called, “importer”). And this is even worse. Maybe it would help to have some kind of flow diagram of all this import/export operations, but please read below. > + > +Another instance of the Hyper_DMABUF driver on importer registers > +a hyper_dmabuf_id together with reference information for the shared physical > +pages associated with the DMA_BUF to its database when the export happens. > + > +The actual mapping of the DMA_BUF on the importer’s side is done by > +the Hyper_DMABUF driver when user space issues the IOCTL command to access > +the shared DMA_BUF. The Hyper_DMABUF driver works as both an importing and > +exporting driver as is, that is, no special configuration is required. > +Consequently, only a single module per VM is needed to enable cross-VM DMA_BUF > +exchange. IMHO I need a more generic view of the problem you are trying to solve in the overview section. I've read the full overview, and I still have no idea why you need all this. I think the overview should contain at least: 1. A description of the problem you are trying to solve. 2. A high level description of the proposed solution. 3. How the proposed solution deals with the problem described in 1. This overview is not useful for people that don't know which problem you are trying to solve, like myself. Thanks, Roger. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [RFC PATCH v2 2/9] hyper_dmabuf: architecture specification and reference guide Date: Fri, 23 Feb 2018 16:15:00 +0000 Message-ID: <20180223161500.xpbqnpsxihoxi5o4@MacBook-Pro-de-Roger.local> References: <20180214015008.9513-1-dongwon.kim@intel.com> <20180214015008.9513-3-dongwon.kim@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180214015008.9513-3-dongwon.kim@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Dongwon Kim Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, mateuszx.potrola@intel.com, xen-devel@lists.xenproject.org, sumit.semwal@linaro.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMTMsIDIwMTggYXQgMDU6NTA6MDFQTSAtMDgwMCwgRG9uZ3dvbiBLaW0gd3Jv dGU6Cj4gUmVmZXJlbmNlIGRvY3VtZW50IGZvciBoeXBlcl9ETUFCVUYgZHJpdmVyCj4gCj4gRG9j dW1lbnRhdGlvbi9oeXBlci1kbWFidWYtc2hhcmluZy50eHQKClRoaXMgc2hvdWxkIGxpa2VseSBi ZSBwYXRjaCAxIGluIG9yZGVyIGZvciByZXZpZXdlcnMgdG8gaGF2ZSB0aGUKYXBwcm9wcmlhdGUg Y29udGV4dC4KCj4gCj4gU2lnbmVkLW9mZi1ieTogRG9uZ3dvbiBLaW0gPGRvbmd3b24ua2ltQGlu dGVsLmNvbT4KPiAtLS0KPiAgRG9jdW1lbnRhdGlvbi9oeXBlci1kbWFidWYtc2hhcmluZy50eHQg fCA3MzQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2Vk LCA3MzQgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9o eXBlci1kbWFidWYtc2hhcmluZy50eHQKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9o eXBlci1kbWFidWYtc2hhcmluZy50eHQgYi9Eb2N1bWVudGF0aW9uL2h5cGVyLWRtYWJ1Zi1zaGFy aW5nLnR4dAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi45Mjhl NDExOTMxZTMKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9oeXBlci1kbWFi dWYtc2hhcmluZy50eHQKPiBAQCAtMCwwICsxLDczNCBAQAo+ICtMaW51eCBIeXBlciBETUFCVUYg RHJpdmVyCj4gKwo+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiArU2VjdGlvbiAxLiBPdmVydmll dwo+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiArCj4gK0h5cGVyX0RNQUJVRiBkcml2ZXIgaXMg YSBMaW51eCBkZXZpY2UgZHJpdmVyIHJ1bm5pbmcgb24gbXVsdGlwbGUgVmlydHVhbAo+ICthY2hp bmVzIChWTXMpLCB3aGljaCBleHBhbmRzIERNQS1CVUYgc2hhcmluZyBjYXBhYmlsaXR5IHRvIHRo ZSBWTSBlbnZpcm9ubWVudAo+ICt3aGVyZSBtdWx0aXBsZSBkaWZmZXJlbnQgT1MgaW5zdGFuY2Vz IG5lZWQgdG8gc2hhcmUgc2FtZSBwaHlzaWNhbCBkYXRhIHdpdGhvdXQKPiArZGF0YS1jb3B5IGFj cm9zcyBWTXMuCj4gKwo+ICtUbyBzaGFyZSBhIERNQV9CVUYgYWNyb3NzIFZNcywgYW4gaW5zdGFu Y2Ugb2YgdGhlIEh5cGVyX0RNQUJVRiBkcnYgb24gdGhlCj4gK2V4cG9ydGluZyBWTSAoc28gY2Fs bGVkLCDigJxleHBvcnRlcuKAnSkgaW1wb3J0cyBhIGxvY2FsIERNQV9CVUYgZnJvbSB0aGUgb3Jp Z2luYWwKPiArcHJvZHVjZXIgb2YgdGhlIGJ1ZmZlciwKClRoZSB1c2FnZSBvZiBleHBvcnQgYW5k IGltcG9ydCBpbiB0aGUgYWJvdmUgc2VudGVuY2UgbWFrZXMgaXQgYWxtb3N0CmltcG9zc2libGUg dG8gdW5kZXJzdGFuZC4KCj4gdGhlbiByZS1leHBvcnRzIGl0IHdpdGggYW4gdW5pcXVlIElELCBo eXBlcl9kbWFidWZfaWQKPiArZm9yIHRoZSBidWZmZXIgdG8gdGhlIGltcG9ydGluZyBWTSAoc28g Y2FsbGVkLCDigJxpbXBvcnRlcuKAnSkuCgpBbmQgdGhpcyBpcyBldmVuIHdvcnNlLgoKTWF5YmUg aXQgd291bGQgaGVscCB0byBoYXZlIHNvbWUga2luZCBvZiBmbG93IGRpYWdyYW0gb2YgYWxsIHRo aXMKaW1wb3J0L2V4cG9ydCBvcGVyYXRpb25zLCBidXQgcGxlYXNlIHJlYWQgYmVsb3cuCgo+ICsK PiArQW5vdGhlciBpbnN0YW5jZSBvZiB0aGUgSHlwZXJfRE1BQlVGIGRyaXZlciBvbiBpbXBvcnRl ciByZWdpc3RlcnMKPiArYSBoeXBlcl9kbWFidWZfaWQgdG9nZXRoZXIgd2l0aCByZWZlcmVuY2Ug aW5mb3JtYXRpb24gZm9yIHRoZSBzaGFyZWQgcGh5c2ljYWwKPiArcGFnZXMgYXNzb2NpYXRlZCB3 aXRoIHRoZSBETUFfQlVGIHRvIGl0cyBkYXRhYmFzZSB3aGVuIHRoZSBleHBvcnQgaGFwcGVucy4K PiArCj4gK1RoZSBhY3R1YWwgbWFwcGluZyBvZiB0aGUgRE1BX0JVRiBvbiB0aGUgaW1wb3J0ZXLi gJlzIHNpZGUgaXMgZG9uZSBieQo+ICt0aGUgSHlwZXJfRE1BQlVGIGRyaXZlciB3aGVuIHVzZXIg c3BhY2UgaXNzdWVzIHRoZSBJT0NUTCBjb21tYW5kIHRvIGFjY2Vzcwo+ICt0aGUgc2hhcmVkIERN QV9CVUYuIFRoZSBIeXBlcl9ETUFCVUYgZHJpdmVyIHdvcmtzIGFzIGJvdGggYW4gaW1wb3J0aW5n IGFuZAo+ICtleHBvcnRpbmcgZHJpdmVyIGFzIGlzLCB0aGF0IGlzLCBubyBzcGVjaWFsIGNvbmZp Z3VyYXRpb24gaXMgcmVxdWlyZWQuCj4gK0NvbnNlcXVlbnRseSwgb25seSBhIHNpbmdsZSBtb2R1 bGUgcGVyIFZNIGlzIG5lZWRlZCB0byBlbmFibGUgY3Jvc3MtVk0gRE1BX0JVRgo+ICtleGNoYW5n ZS4KCklNSE8gSSBuZWVkIGEgbW9yZSBnZW5lcmljIHZpZXcgb2YgdGhlIHByb2JsZW0geW91IGFy ZSB0cnlpbmcgdG8gc29sdmUKaW4gdGhlIG92ZXJ2aWV3IHNlY3Rpb24uIEkndmUgcmVhZCB0aGUg ZnVsbCBvdmVydmlldywgYW5kIEkgc3RpbGwgaGF2ZQpubyBpZGVhIHdoeSB5b3UgbmVlZCBhbGwg dGhpcy4KCkkgdGhpbmsgdGhlIG92ZXJ2aWV3IHNob3VsZCBjb250YWluIGF0IGxlYXN0OgoKMS4g QSBkZXNjcmlwdGlvbiBvZiB0aGUgcHJvYmxlbSB5b3UgYXJlIHRyeWluZyB0byBzb2x2ZS4KMi4g QSBoaWdoIGxldmVsIGRlc2NyaXB0aW9uIG9mIHRoZSBwcm9wb3NlZCBzb2x1dGlvbi4KMy4gSG93 IHRoZSBwcm9wb3NlZCBzb2x1dGlvbiBkZWFscyB3aXRoIHRoZSBwcm9ibGVtIGRlc2NyaWJlZCBp biAxLgoKVGhpcyBvdmVydmlldyBpcyBub3QgdXNlZnVsIGZvciBwZW9wbGUgdGhhdCBkb24ndCBr bm93IHdoaWNoIHByb2JsZW0KeW91IGFyZSB0cnlpbmcgdG8gc29sdmUsIGxpa2UgbXlzZWxmLgoK VGhhbmtzLCBSb2dlci4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2 ZWw=