All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Jarry <robin.jarry@6wind.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 2/2] objtool: use host flags to detect if libelf is missing
Date: Fri, 23 Feb 2018 17:22:55 +0100	[thread overview]
Message-ID: <20180223162255.cakkzdi3jpkh4vmi@6wind.com> (raw)
In-Reply-To: <20180223153720.glun6fa2a3jde7mi@treble>

2018-02-23, Josh Poimboeuf:
> Hi Robin,
> 
> Did you test this?  I see some issues:
> 
> a) I don't see where the host_cflags variable comes from (and btw, it's
>    misspelled...)

Hi Josh,

Shame on me... Last minute fix. I had tested this first by forcing
HOSTCC="gcc <CFLAGS> <LDFLAGS>" but I found it rather dirty. As it turns
out, my patch is not better.

> b) I don't see where objtool uses HOSTLDFLAGS.

Indeed, I also missed this (see above).

It looks like objtool does not use HOSTCFLAGS nor HOSTLDFLAGS (defined
in top Makefile). Do you see a reason why? Maybe it would be a good idea
to share these flags (adding some specific ones for objtool, if needed).

What do you think?

-- 
Robin

  reply	other threads:[~2018-02-23 16:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23 14:22 [PATCH 0/2] objtool: fix libelf detection in non-standard locations Robin Jarry
2018-02-23 14:22 ` [PATCH 1/2] kbuild: introduce HOST_EXTRALDFLAGS Robin Jarry
2018-02-23 14:22 ` [PATCH 2/2] objtool: use host flags to detect if libelf is missing Robin Jarry
2018-02-23 15:37   ` Josh Poimboeuf
2018-02-23 16:22     ` Robin Jarry [this message]
2018-02-23 16:34       ` Josh Poimboeuf
2018-02-26 18:41 ` [PATCH v2 0/3] kbuild: fix host progs build with libs in non standard locations Robin Jarry
2018-02-26 18:41   ` [PATCH v2 1/3] kbuild: introduce HOST_{C,LD}FLAGS Robin Jarry
2018-02-26 18:41   ` [PATCH v2 2/3] kbuild: use HOSTLDFLAGS for single .c executables Robin Jarry
2018-04-05 14:23     ` Masahiro Yamada
2018-02-26 18:41   ` [PATCH v2 3/3] objtool: use global host flags for compilation Robin Jarry
2018-02-27 17:49     ` Josh Poimboeuf
2018-02-27 20:55       ` Robin Jarry
2018-02-27 21:41         ` Josh Poimboeuf
2018-02-27 17:45   ` [PATCH v2 0/3] kbuild: fix host progs build with libs in non standard locations Josh Poimboeuf
2018-02-27 20:52     ` Robin Jarry
2018-02-27 21:38       ` Josh Poimboeuf
2018-02-28  0:23         ` Randy Dunlap
2018-02-28 10:22     ` Masahiro Yamada
2018-02-28 17:24       ` Robin Jarry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180223162255.cakkzdi3jpkh4vmi@6wind.com \
    --to=robin.jarry@6wind.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.