From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752842AbeBZLoe (ORCPT ); Mon, 26 Feb 2018 06:44:34 -0500 Received: from mail.skyhub.de ([5.9.137.197]:53120 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752264AbeBZLob (ORCPT ); Mon, 26 Feb 2018 06:44:31 -0500 Date: Mon, 26 Feb 2018 12:44:09 +0100 From: Borislav Petkov To: Wanpeng Li Cc: LKML , kvm , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: X86: Allow userspace to define the microcode version Message-ID: <20180226114409.GD4377@pd.tnic> References: <1519629838-4898-1-git-send-email-wanpengli@tencent.com> <20180226094148.GA15539@pd.tnic> <20180226104921.GA4377@pd.tnic> <20180226111630.GB4377@pd.tnic> <20180226113000.GC4377@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 26, 2018 at 07:37:32PM +0800, Wanpeng Li wrote: > The guest write is ignored as the original kvm implementation before the patch. That will never work because there's no virtualized microcode loader. Which will be a dumb idea anyway. Goes to show that dealing with microcode revisions for a guest is the wrong approach. > Hmm, the apic_check_deadline_errata() example can be referred to. So that's basically what I'm saying - fix apic_check_deadline_errata() to check whether the kernel runs as a guest. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.