From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:43410 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752383AbeBZNkd (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 26 Feb 2018 08:40:33 -0500
Date: Mon, 26 Feb 2018 14:40:31 +0100
From: Jan Kara <jack@suse.cz>
To: Pali =?iso-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org,
        Steve Kenton <skenton@ou.edu>
Subject: Re: [PATCH 0/5] udf: Improve uid/gid handling
Message-ID: <20180226134031.etmveis34prnvbeo@quack2.suse.cz>
References: <20180222104519.30241-1-jack@suse.cz>
 <20180224115607.towx4f6fmqvfx55a@pali>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180224115607.towx4f6fmqvfx55a@pali>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat 24-02-18 12:56:07, Pali Roh�r wrote:
> On Thursday 22 February 2018 11:45:14 Jan Kara wrote:
> > Hello,
> > 
> > this patch series improves uid and gid handling for UDF filesystems. In
> > particular when uid/gid mount options are used, we make sure even newly created
> > and chowned files still belong to the target user/group (UDF now behaves the
> > same way as FAT in this mode to be easy to use for removable media). Also when
> > the filesystem does not store uid/gid for files, we now present these files as
> > belonging to overflow[ug]id instead of invalid ids if uid/gid mount option are
> > not used so that at least sysadmin can modify the filesystem.
> > 
> > 								Honza
> 
> Looks good, this should improve handling of uid/gid on removable UDF
> filesystems. Add my Reviewed-by: Pali Roh�r <pali.rohar@gmail.com>

Thanks for review!

> Anyway, I would propose backporting patch "[PATCH 4/5] udf: Provide
> saner default for invalid uid / gid" into stable kernels to allow root
> user to modify files without uid/gid.

Also patch 3/5 would be needed to make this change safe in presence of user
namespaces. But as much as the problem is annoying when it happens, I
didn't get many reports of it over the years (just Steve and you when you
tried to modify UDF tools) and it can be worked around by using
uid=<something> mount option so I don't think stable backport is really
warranted.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR