From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device Date: Mon, 26 Feb 2018 17:02:18 -0800 Message-ID: <20180226170218.6b1dcf22@xeon-e3> References: <20180221161105.GC1996@nanopsycho> <20180221165848.GD1996@nanopsycho> <20180221193832.GE1996@nanopsycho> <20180222081115.GC1994@nanopsycho> <20180223155904.27b11865@xeon-e3> <20180226071924.GA2063@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "Duyck, Alexander H" , virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" , Jakub Kicinski , "Samudrala, Sridhar" , Alexander Duyck , virtualization@lists.linux-foundation.org, Siwei Liu , Netdev , David Miller To: Jiri Pirko Return-path: In-Reply-To: <20180226071924.GA2063@nanopsycho> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Mon, 26 Feb 2018 08:19:24 +0100 Jiri Pirko wrote: > Sat, Feb 24, 2018 at 12:59:04AM CET, stephen@networkplumber.org wrote: > >On Thu, 22 Feb 2018 13:30:12 -0800 > >Alexander Duyck wrote: > > > >> > Again, I undertand your motivation. Yet I don't like your solution. > >> > But if the decision is made to do this in-driver bonding. I would like > >> > to see it baing done some generic way: > >> > 1) share the same "in-driver bonding core" code with netvsc > >> > put to net/core. > >> > 2) the "in-driver bonding core" will strictly limit the functionality, > >> > like active-backup mode only, one vf, one backup, vf netdev type > >> > check (so noone could enslave a tap or anything else) > >> > If user would need something more, he should employ team/bond. > > > >Sharing would be good, but netvsc world would really like to only have > >one visible network device. > > Why do you mind? All would be the same, there would be just another > netdevice unused by the vm user (same as the vf netdev). > I mind because our requirement is no changes to userspace. No special udev rules, no bonding script, no setup. Things like cloudinit running on current distro's expect to see a single eth0. The VF device show up can also be an issue because distro's have stupid rules like Network Manager trying to start DHCP on every interface. We deal with that now by doing stuff like udev rules to get it to stop but that is still causing user errors.