All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: "David S. Miller" <davem@davemloft.net>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@mellanox.com>
Cc: Leon Romanovsky <leonro@mellanox.com>,
	Mark Bloch <markb@mellanox.com>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	Leon Romanovsky <leon@kernel.org>,
	Saeed Mahameed <saeedm@mellanox.com>
Subject: [for-next 09/15] IB/mlx5: Listen to netdev register/unresiter events in switchdev mode
Date: Mon, 26 Feb 2018 12:36:11 -0800	[thread overview]
Message-ID: <20180226203617.10242-10-saeedm@mellanox.com> (raw)
In-Reply-To: <20180226203617.10242-1-saeedm@mellanox.com>

From: Mark Bloch <markb@mellanox.com>

Currently we listen to netdev register/unregister event based on PCI
device. When in switchdev mode PF and representors share the same PCI
device, so in order to pair ib device and netdev in switchdev mode
compare the netdev that triggered the event to that of the representor.

Expose a function that lets you receive the netdev associated what
a given representor.

Signed-off-by: Mark Bloch <markb@mellanox.com>
Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
 drivers/infiniband/hw/mlx5/ib_rep.h |  8 ++++++++
 drivers/infiniband/hw/mlx5/main.c   | 15 ++++++++++++---
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/ib_rep.h b/drivers/infiniband/hw/mlx5/ib_rep.h
index 64ab54b82820..923ad4cba941 100644
--- a/drivers/infiniband/hw/mlx5/ib_rep.h
+++ b/drivers/infiniband/hw/mlx5/ib_rep.h
@@ -17,6 +17,8 @@ struct mlx5_eswitch_rep *mlx5_ib_vport_rep(struct mlx5_eswitch *esw,
 					   int vport_index);
 void mlx5_ib_register_vport_reps(struct mlx5_ib_dev *dev);
 void mlx5_ib_unregister_vport_reps(struct mlx5_ib_dev *dev);
+struct net_device *mlx5_ib_get_rep_netdev(struct mlx5_eswitch *esw,
+					  int vport_index);
 #else /* CONFIG_MLX5_ESWITCH */
 static inline u8 mlx5_ib_eswitch_mode(struct mlx5_eswitch *esw)
 {
@@ -39,6 +41,12 @@ struct mlx5_eswitch_rep *mlx5_ib_vport_rep(struct mlx5_eswitch *esw,
 
 static inline void mlx5_ib_register_vport_reps(struct mlx5_ib_dev *dev) {}
 static inline void mlx5_ib_unregister_vport_reps(struct mlx5_ib_dev *dev) {}
+static inline
+struct net_device *mlx5_ib_get_rep_netdev(struct mlx5_eswitch *esw,
+					  int vport_index)
+{
+	return NULL;
+}
 #endif
 
 static inline
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 5624c5eba2ed..bc97c73704c4 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -155,10 +155,19 @@ static int mlx5_netdev_event(struct notifier_block *this,
 	case NETDEV_REGISTER:
 	case NETDEV_UNREGISTER:
 		write_lock(&roce->netdev_lock);
-
-		if (ndev->dev.parent == &mdev->pdev->dev)
-			roce->netdev = (event == NETDEV_UNREGISTER) ?
+		if (ibdev->rep) {
+			struct mlx5_eswitch *esw = ibdev->mdev->priv.eswitch;
+			struct net_device *rep_ndev;
+
+			rep_ndev = mlx5_ib_get_rep_netdev(esw,
+							  ibdev->rep->vport);
+			if (rep_ndev == ndev)
+				roce->netdev = (event == NETDEV_UNREGISTER) ?
 					NULL : ndev;
+		} else if (ndev->dev.parent == &ibdev->mdev->pdev->dev) {
+			roce->netdev = (event == NETDEV_UNREGISTER) ?
+				NULL : ndev;
+		}
 		write_unlock(&roce->netdev_lock);
 		break;
 
-- 
2.14.3

  parent reply	other threads:[~2018-02-26 20:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 20:36 [pull request][for-next 00/15] Mellanox, mlx5 RDMA E-Switch representors 2018-02-23 Saeed Mahameed
2018-02-26 20:36 ` [for-next 01/15] net/mlx5: E-Switch, Add callback to get representor device Saeed Mahameed
2018-02-26 20:36 ` [for-next 02/15] net/mlx5: E-Switch, Move representors definition to a global scope Saeed Mahameed
2018-02-26 20:36 ` [for-next 03/15] net/mlx5: E-Switch, Increase number of FTEs in FDB in switchdev mode Saeed Mahameed
2018-02-26 20:36 ` [for-next 04/15] net/mlx5: E-Switch, Optimize HW steering tables " Saeed Mahameed
2018-02-26 20:36 ` [for-next 05/15] net/mlx5: E-Switch, Add definition of IB representor Saeed Mahameed
2018-02-26 20:36 ` [for-next 06/15] IB/mlx5: Add basic regiser/unregister representors code Saeed Mahameed
2018-02-26 20:36 ` [for-next 07/15] IB/mlx5: Allocate flow DB only on PF IB device Saeed Mahameed
2018-02-26 20:36 ` [for-next 08/15] IB/mlx5: Add match on vport when in switchdev mode Saeed Mahameed
2018-02-26 20:36 ` Saeed Mahameed [this message]
2018-02-26 20:36 ` [for-next 10/15] IB/mlx5: When in switchdev mode, expose only raw packet capabilities Saeed Mahameed
2018-02-26 20:36 ` [for-next 11/15] IB/mlx5: Don't expose MR cache in switchdev mode Saeed Mahameed
2018-02-26 20:36 ` [for-next 12/15] IB/mlx5: E-Switch, Add rule to forward traffic to vport Saeed Mahameed
2018-02-26 20:36 ` [for-next 13/15] IB/mlx5: Add proper representors support Saeed Mahameed
2018-02-26 20:36 ` [for-next 14/15] net/mlx5: E-Switch, Reload IB interface when switching devlink modes Saeed Mahameed
2018-02-26 20:36 ` [for-next 15/15] IB/mlx5: Disable self loopback check when in switchdev mode Saeed Mahameed
2018-02-28  3:50 ` [pull request][for-next 00/15] Mellanox, mlx5 RDMA E-Switch representors 2018-02-23 Doug Ledford
2018-02-28 14:55 ` David Miller
2018-02-28 18:39   ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180226203617.10242-10-saeedm@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=jgg@mellanox.com \
    --cc=leon@kernel.org \
    --cc=leonro@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=markb@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.