All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Jean Delvare <jdelvare@suse.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zoltan Boszormenyi <zboszor@pr.hu>
Subject: Re: [PATCH v2 2/2] i2c: piix4: Use request_muxed_region
Date: Mon, 26 Feb 2018 14:28:58 -0800	[thread overview]
Message-ID: <20180226222858.GB5924@roeck-us.net> (raw)
In-Reply-To: <20180226214414.6jbloibqkidr66de@ninjato>

On Mon, Feb 26, 2018 at 10:44:14PM +0100, Wolfram Sang wrote:
> On Mon, Feb 26, 2018 at 10:43:07PM +0100, Wolfram Sang wrote:
> > 
> > > It is an alternate and somewhat simpler solution which does not
> > > attempt to change the kernel API. My primary goal was to find
> > > a solution for the immediate problem between the watchdog and
> > > i2c drivers. My solution does not attempt to fix the access problem
> > > for (initialization) functions with no return code. At the same time,
> > > I prefer to use functions which _do_ return an error if that is possible
> > > since it _may_ after all be that there are other users calling
> > > request_region().
> > > 
> > > Having said that, I'll be just as happy if Zoltan's series is accepted
> > > instead of this patch (except for patch #5; the watchdog driver has
> > > already been converted to use request_muxed_region).
> > 
> > Thanks for the explanation!
> > 
> > So, as I understand: I can apply this patch to fix the immediate (and
> > long standing) problem and decouple it from the API change. The latter
> > can then still be worked on and the changes for the piix driver should
> > then be minimal. Correct?
> 
> And we should have Zoltan on CC.
> 
Yes. Sorry, things are a bit hectic today.

Guenter

  reply	other threads:[~2018-02-26 22:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 20:46 [PATCH v2 1/2] i2c: piix4: Use usleep_range() Guenter Roeck
2018-02-26 20:46 ` [PATCH v2 2/2] i2c: piix4: Use request_muxed_region Guenter Roeck
2018-02-26 20:52   ` Wolfram Sang
2018-02-26 21:34     ` Guenter Roeck
2018-02-26 21:43       ` Wolfram Sang
2018-02-26 21:44         ` Wolfram Sang
2018-02-26 22:28           ` Guenter Roeck [this message]
2018-02-26 22:28         ` Guenter Roeck
2018-03-01 10:57   ` Jean Delvare
2018-03-02 10:17   ` Wolfram Sang
2018-03-01 11:04 ` [PATCH v2 1/2] i2c: piix4: Use usleep_range() Jean Delvare
2018-03-02 10:17 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180226222858.GB5924@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    --cc=zboszor@pr.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.