From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqimr-0004ez-T5 for qemu-devel@nongnu.org; Tue, 27 Feb 2018 12:11:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqimo-0005Or-OI for qemu-devel@nongnu.org; Tue, 27 Feb 2018 12:11:33 -0500 Received: from smtp.citrix.com ([66.165.176.89]:55862) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqimo-0005Ne-F7 for qemu-devel@nongnu.org; Tue, 27 Feb 2018 12:11:30 -0500 Date: Tue, 27 Feb 2018 16:41:47 +0000 From: Anthony PERARD Message-ID: <20180227164147.GB1799@perard.uk.xensource.com> References: <20171207101812.23602-1-haozhong.zhang@intel.com> <20171207101812.23602-4-haozhong.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171207101812.23602-4-haozhong.zhang@intel.com> Subject: Re: [Qemu-devel] [RFC QEMU PATCH v4 03/10] hostmem-xen: add a host memory backend for Xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Haozhong Zhang Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Konrad Rzeszutek Wilk , Dan Williams , Chao Peng , Eduardo Habkost , Igor Mammedov , "Michael S. Tsirkin" On Thu, Dec 07, 2017 at 06:18:05PM +0800, Haozhong Zhang wrote: > diff --git a/backends/hostmem.c b/backends/hostmem.c > index ee2c2d5bfd..ba13a52994 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -12,6 +12,7 @@ > #include "qemu/osdep.h" > #include "sysemu/hostmem.h" > #include "hw/boards.h" > +#include "hw/xen/xen.h" > #include "qapi/error.h" > #include "qapi/visitor.h" > #include "qapi-types.h" > @@ -277,6 +278,14 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) > goto out; > } > > + /* > + * The backend storage of MEMORY_BACKEND_XEN is managed by Xen, > + * so no further work in this function is needed. > + */ > + if (xen_enabled() && !backend->mr.ram_block) { > + goto out; > + } > + > ptr = memory_region_get_ram_ptr(&backend->mr); > sz = memory_region_size(&backend->mr); > > diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c > index 66eace5a5c..dcbfce33d5 100644 > --- a/hw/mem/pc-dimm.c > +++ b/hw/mem/pc-dimm.c > @@ -28,6 +28,7 @@ > #include "sysemu/kvm.h" > #include "trace.h" > #include "hw/virtio/vhost.h" > +#include "hw/xen/xen.h" > > typedef struct pc_dimms_capacity { > uint64_t size; > @@ -108,7 +109,10 @@ void pc_dimm_memory_plug(DeviceState *dev, MemoryHotplugState *hpms, > } > > memory_region_add_subregion(&hpms->mr, addr - hpms->base, mr); > - vmstate_register_ram(vmstate_mr, dev); > + /* memory-backend-xen is not backed by RAM. */ > + if (!xen_enabled()) { Is it possible to have the same condition as the one used in host_memory_backend_memory_complete? i.e. base on whether the memory region is mapped or not (backend->mr.ram_block). > + vmstate_register_ram(vmstate_mr, dev); > + } > numa_set_mem_node_id(addr, memory_region_size(mr), dimm->node); > > out: > -- > 2.15.1 > -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [RFC QEMU PATCH v4 03/10] hostmem-xen: add a host memory backend for Xen Date: Tue, 27 Feb 2018 16:41:47 +0000 Message-ID: <20180227164147.GB1799@perard.uk.xensource.com> References: <20171207101812.23602-1-haozhong.zhang@intel.com> <20171207101812.23602-4-haozhong.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqiK8-0005Xt-8g for xen-devel@lists.xenproject.org; Tue, 27 Feb 2018 16:41:52 +0000 Content-Disposition: inline In-Reply-To: <20171207101812.23602-4-haozhong.zhang@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Haozhong Zhang Cc: Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Igor Mammedov , Chao Peng , xen-devel@lists.xenproject.org, Dan Williams List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBEZWMgMDcsIDIwMTcgYXQgMDY6MTg6MDVQTSArMDgwMCwgSGFvemhvbmcgWmhhbmcg d3JvdGU6Cj4gZGlmZiAtLWdpdCBhL2JhY2tlbmRzL2hvc3RtZW0uYyBiL2JhY2tlbmRzL2hvc3Rt ZW0uYwo+IGluZGV4IGVlMmMyZDViZmQuLmJhMTNhNTI5OTQgMTAwNjQ0Cj4gLS0tIGEvYmFja2Vu ZHMvaG9zdG1lbS5jCj4gKysrIGIvYmFja2VuZHMvaG9zdG1lbS5jCj4gQEAgLTEyLDYgKzEyLDcg QEAKPiAgI2luY2x1ZGUgInFlbXUvb3NkZXAuaCIKPiAgI2luY2x1ZGUgInN5c2VtdS9ob3N0bWVt LmgiCj4gICNpbmNsdWRlICJody9ib2FyZHMuaCIKPiArI2luY2x1ZGUgImh3L3hlbi94ZW4uaCIK PiAgI2luY2x1ZGUgInFhcGkvZXJyb3IuaCIKPiAgI2luY2x1ZGUgInFhcGkvdmlzaXRvci5oIgo+ ICAjaW5jbHVkZSAicWFwaS10eXBlcy5oIgo+IEBAIC0yNzcsNiArMjc4LDE0IEBAIGhvc3RfbWVt b3J5X2JhY2tlbmRfbWVtb3J5X2NvbXBsZXRlKFVzZXJDcmVhdGFibGUgKnVjLCBFcnJvciAqKmVy cnApCj4gICAgICAgICAgICAgIGdvdG8gb3V0Owo+ICAgICAgICAgIH0KPiAgCj4gKyAgICAgICAg LyoKPiArICAgICAgICAgKiBUaGUgYmFja2VuZCBzdG9yYWdlIG9mIE1FTU9SWV9CQUNLRU5EX1hF TiBpcyBtYW5hZ2VkIGJ5IFhlbiwKPiArICAgICAgICAgKiBzbyBubyBmdXJ0aGVyIHdvcmsgaW4g dGhpcyBmdW5jdGlvbiBpcyBuZWVkZWQuCj4gKyAgICAgICAgICovCj4gKyAgICAgICAgaWYgKHhl bl9lbmFibGVkKCkgJiYgIWJhY2tlbmQtPm1yLnJhbV9ibG9jaykgewo+ICsgICAgICAgICAgICBn b3RvIG91dDsKPiArICAgICAgICB9Cj4gKwo+ICAgICAgICAgIHB0ciA9IG1lbW9yeV9yZWdpb25f Z2V0X3JhbV9wdHIoJmJhY2tlbmQtPm1yKTsKPiAgICAgICAgICBzeiA9IG1lbW9yeV9yZWdpb25f c2l6ZSgmYmFja2VuZC0+bXIpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvaHcvbWVtL3BjLWRpbW0uYyBi L2h3L21lbS9wYy1kaW1tLmMKPiBpbmRleCA2NmVhY2U1YTVjLi5kY2JmY2UzM2Q1IDEwMDY0NAo+ IC0tLSBhL2h3L21lbS9wYy1kaW1tLmMKPiArKysgYi9ody9tZW0vcGMtZGltbS5jCj4gQEAgLTI4 LDYgKzI4LDcgQEAKPiAgI2luY2x1ZGUgInN5c2VtdS9rdm0uaCIKPiAgI2luY2x1ZGUgInRyYWNl LmgiCj4gICNpbmNsdWRlICJody92aXJ0aW8vdmhvc3QuaCIKPiArI2luY2x1ZGUgImh3L3hlbi94 ZW4uaCIKPiAgCj4gIHR5cGVkZWYgc3RydWN0IHBjX2RpbW1zX2NhcGFjaXR5IHsKPiAgICAgICB1 aW50NjRfdCBzaXplOwo+IEBAIC0xMDgsNyArMTA5LDEwIEBAIHZvaWQgcGNfZGltbV9tZW1vcnlf cGx1ZyhEZXZpY2VTdGF0ZSAqZGV2LCBNZW1vcnlIb3RwbHVnU3RhdGUgKmhwbXMsCj4gICAgICB9 Cj4gIAo+ICAgICAgbWVtb3J5X3JlZ2lvbl9hZGRfc3VicmVnaW9uKCZocG1zLT5tciwgYWRkciAt IGhwbXMtPmJhc2UsIG1yKTsKPiAtICAgIHZtc3RhdGVfcmVnaXN0ZXJfcmFtKHZtc3RhdGVfbXIs IGRldik7Cj4gKyAgICAvKiBtZW1vcnktYmFja2VuZC14ZW4gaXMgbm90IGJhY2tlZCBieSBSQU0u ICovCj4gKyAgICBpZiAoIXhlbl9lbmFibGVkKCkpIHsKCklzIGl0IHBvc3NpYmxlIHRvIGhhdmUg dGhlIHNhbWUgY29uZGl0aW9uIGFzIHRoZSBvbmUgdXNlZCBpbgpob3N0X21lbW9yeV9iYWNrZW5k X21lbW9yeV9jb21wbGV0ZT8gaS5lLiBiYXNlIG9uIHdoZXRoZXIgdGhlIG1lbW9yeQpyZWdpb24g aXMgbWFwcGVkIG9yIG5vdCAoYmFja2VuZC0+bXIucmFtX2Jsb2NrKS4KCj4gKyAgICAgICAgdm1z dGF0ZV9yZWdpc3Rlcl9yYW0odm1zdGF0ZV9tciwgZGV2KTsKPiArICAgIH0KPiAgICAgIG51bWFf c2V0X21lbV9ub2RlX2lkKGFkZHIsIG1lbW9yeV9yZWdpb25fc2l6ZShtciksIGRpbW0tPm5vZGUp Owo+ICAKPiAgb3V0Ogo+IC0tIAo+IDIuMTUuMQo+IAoKLS0gCkFudGhvbnkgUEVSQVJECgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFp bGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhl bnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs