From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:37493 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbeB0UWZ (ORCPT ); Tue, 27 Feb 2018 15:22:25 -0500 Date: Tue, 27 Feb 2018 22:22:12 +0200 From: Ido Schimmel To: Jiri Benc Cc: Ido Schimmel , netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com, dsahern@gmail.com, mlxsw@mellanox.com Subject: Re: [PATCH net-next] team: Use extack to report enslavement failures Message-ID: <20180227202212.GA14835@splinter> References: <20180227153808.10740-1-idosch@mellanox.com> <20180227204235.7d4ab738@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180227204235.7d4ab738@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Feb 27, 2018 at 08:42:35PM +0100, Jiri Benc wrote: > On Tue, 27 Feb 2018 17:38:08 +0200, Ido Schimmel wrote: > > if (port_dev->flags & IFF_LOOPBACK) { > > + NL_SET_ERR_MSG(extack, "Loopback device can't be added as a team port"); > > netdev_err(dev, "Device %s is loopback device. Loopback devices can't be added as a team port\n", > > portname); > > Aren't the netdev_errs unnecessary now? > > Or do you keep them for people using old config tools with a new kernel? Yes, that's the intention. I checked bond that was also converted to use extack and the same thing happens there. > If so, for how long? They should certainly be removed eventually. How > do we ensure we don't forget? > > Seems to me it would be better to remove them right now. I can do that unless someone objects.