From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42552 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751632AbeB0Tmi (ORCPT ); Tue, 27 Feb 2018 14:42:38 -0500 Date: Tue, 27 Feb 2018 20:42:35 +0100 From: Jiri Benc To: Ido Schimmel Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com, dsahern@gmail.com, mlxsw@mellanox.com Subject: Re: [PATCH net-next] team: Use extack to report enslavement failures Message-ID: <20180227204235.7d4ab738@redhat.com> In-Reply-To: <20180227153808.10740-1-idosch@mellanox.com> References: <20180227153808.10740-1-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 27 Feb 2018 17:38:08 +0200, Ido Schimmel wrote: > if (port_dev->flags & IFF_LOOPBACK) { > + NL_SET_ERR_MSG(extack, "Loopback device can't be added as a team port"); > netdev_err(dev, "Device %s is loopback device. Loopback devices can't be added as a team port\n", > portname); Aren't the netdev_errs unnecessary now? Or do you keep them for people using old config tools with a new kernel? If so, for how long? They should certainly be removed eventually. How do we ensure we don't forget? Seems to me it would be better to remove them right now. Thanks, Jiri