From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:46582 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752517AbeB1O2i (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 28 Feb 2018 09:28:38 -0500
Date: Wed, 28 Feb 2018 09:28:34 -0500 (EST)
Message-Id: <20180228.092834.1580156018372298323.davem@davemloft.net>
To: jiri@resnulli.us
Cc: kubakici@wp.pl, idosch@idosch.org, jbenc@redhat.com,
        idosch@mellanox.com, netdev@vger.kernel.org, jiri@mellanox.com,
        dsahern@gmail.com, mlxsw@mellanox.com
Subject: Re: [PATCH net-next] team: Use extack to report enslavement
 failures
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180228071241.GC19654@nanopsycho>
References: <20180227202212.GA14835@splinter>
        <20180227154959.47c80d57@cakuba.netronome.com>
        <20180228071241.GC19654@nanopsycho>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 28 Feb 2018 08:12:41 +0100

> Wed, Feb 28, 2018 at 12:49:59AM CET, kubakici@wp.pl wrote:
>>On Tue, 27 Feb 2018 22:22:12 +0200, Ido Schimmel wrote:
>>> > If so, for how long? They should certainly be removed eventually. How
>>> > do we ensure we don't forget?
>>> > 
>>> > Seems to me it would be better to remove them right now.  
>>> 
>>> I can do that unless someone objects.
>>
>>I don't object, but FWIW keep in mind extack errors don't show if
>>libmnl is not installed..
> 
> Yeah, or if you have an older iproute2 package. I would keep the existing
> dmesg msgs for now. In the future, when everyone is used to exacks, then
> we can remove them.

That's how I feel about this as well.