From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:48300 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752891AbeB1QCd (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 28 Feb 2018 11:02:33 -0500
Date: Wed, 28 Feb 2018 11:02:31 -0500 (EST)
Message-Id: <20180228.110231.1205854776682453634.davem@davemloft.net>
To: idosch@mellanox.com
Cc: netdev@vger.kernel.org, jiri@mellanox.com, dsahern@gmail.com,
        mlxsw@mellanox.com
Subject: Re: [PATCH net-next] team: Use extack to report enslavement
 failures
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180227153808.10740-1-idosch@mellanox.com>
References: <20180227153808.10740-1-idosch@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Ido Schimmel <idosch@mellanox.com>
Date: Tue, 27 Feb 2018 17:38:08 +0200

> Use extack inside team's enslavement function and also propagate it to
> the netdevice notifier to allow enslaved ports to report the failure
> reason. Example:
> 
> $ teamd -t team0 -d -c '{"runner": {"name": "lacp"}}'
> $ ip link set dev lo master team0
> Error: Loopback device can't be added as a team port.
> 
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>

Applied, thank you.

David A., when you ACK patches, please start your Acked-by:
tag on the first column of a line.

Don't put things like "LGTM. " before it.

Otherwise patchwork won't automatically pick it up.

Thanks.