From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f174.google.com ([209.85.128.174]:37884 "EHLO
        mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750968AbeB1HMn (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 28 Feb 2018 02:12:43 -0500
Received: by mail-wr0-f174.google.com with SMTP id z12so1232416wrg.4
        for <netdev@vger.kernel.org>; Tue, 27 Feb 2018 23:12:43 -0800 (PST)
Date: Wed, 28 Feb 2018 08:12:41 +0100
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: Ido Schimmel <idosch@idosch.org>, Jiri Benc <jbenc@redhat.com>,
        Ido Schimmel <idosch@mellanox.com>, netdev@vger.kernel.org,
        davem@davemloft.net, jiri@mellanox.com, dsahern@gmail.com,
        mlxsw@mellanox.com
Subject: Re: [PATCH net-next] team: Use extack to report enslavement failures
Message-ID: <20180228071241.GC19654@nanopsycho>
References: <20180227153808.10740-1-idosch@mellanox.com>
 <20180227204235.7d4ab738@redhat.com>
 <20180227202212.GA14835@splinter>
 <20180227154959.47c80d57@cakuba.netronome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180227154959.47c80d57@cakuba.netronome.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Wed, Feb 28, 2018 at 12:49:59AM CET, kubakici@wp.pl wrote:
>On Tue, 27 Feb 2018 22:22:12 +0200, Ido Schimmel wrote:
>> > If so, for how long? They should certainly be removed eventually. How
>> > do we ensure we don't forget?
>> > 
>> > Seems to me it would be better to remove them right now.  
>> 
>> I can do that unless someone objects.
>
>I don't object, but FWIW keep in mind extack errors don't show if
>libmnl is not installed..

Yeah, or if you have an older iproute2 package. I would keep the existing
dmesg msgs for now. In the future, when everyone is used to exacks, then
we can remove them.